René's URL Explorer Experiment


Title: Preserve live set traversal during deterministic marshal serialization by youknowdot · Pull Request #9876 · RustPython/RustPython · GitHub

Open Graph Title: Preserve live set traversal during deterministic marshal serialization by youknowdot · Pull Request #9876 · RustPython/RustPython

X Title: Preserve live set traversal during deterministic marshal serialization by youknowdot · Pull Request #9876 · RustPython/RustPython

Description: Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the live mutable set rather than a precomputed snapshot while making deterministic serialization keys. As in CPython 3.15.2 marshal.c, retain the initial cardinality, stop at an extra entry and reject a short traversal. Each entry is owned and no set lock crosses recursive serialization/callbacks. Frozen sets retain their existing immutable snapshot path; stable byte-key sorting and shared-reference serialization are unchanged. Validation status Rust formatting, diff checks and configured commit hooks passed. Fresh Linux native build passed. An earlier separate cargo-check attempt was killed (SIGKILL, no Rust diagnostic); the subsequent serialized native build completed successfully. Unmodified CPython 3.15.2 set-mutation test: all 14 grow/shrink/version subcases now pass, compared with 14 failures on the baseline. Focused set group: 6 tests, 2 huge-memory skips; 4 deterministic-set subcase failures remain identically on baseline/candidate because the test expects repr order to change under hash seeds, before comparing serialization. Normal sets and unorderable-set-item cases pass. External roundtrip/shared-reference identity and mutating-buffer callback-error/unlocked-mutation probes pass in all 7 marshal versions on both the candidate and actual CPython 3.15.2. Canonical test_marshal.py updated via scripts/update_lib quick to CPython 3.15.2. Final suite: 82 run, 16 skipped, 2 expected failures, zero failures/XPASS. Existing deterministic-set marker retained; only the separate complex-constant-folding case gets a new expectedFailure. Assertions/bodies are unchanged. Full workspace/C-API tests, Clippy and cross-platform CI remain pending. This is a draft, not ready for review or merge. No performance result is claimed. The related canonical Lib/test update is now included and verified with the native candidate. Source comparison: CPython v3.15.2 Python/marshal.c set handling, lines 635–714. The separate compiler-folding test issue is outside this patch. AI assistance: Codex reconstructed the patch and prepared this description at the maintainer's direction. Summary by CodeRabbit Improvements Set and frozenset serialization now processes elements through iteration. If a set changes size during serialization, an error is reported instead of silently producing inconsistent output.

Open Graph Description: Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the l...

X Description: Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the l...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9876

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c22aeda0-3681-6e07-cf0c-965673d5362f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDF0:361639:2E4B3B5:3DCD085:6B01DE47
html-safe-nonce45a2811c2c3bcbfa67098010f43df7a6b9aaa1f4195f6b013ac08c3eb7179296
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREYwOjM2MTYzOToyRTRCM0I1OjNEQ0QwODU6NkIwMURFNDciLCJ2aXNpdG9yX2lkIjoiNDE4NTc4OTkyNDkxNTY2NjUwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c9bfd441f09fb909ce19bb841a62eff03eb629bb8fff6a9a6c4d99e2757e261
hovercard-subject-tagpull_request:5337225305
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9876/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altScope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9876/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9876%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9876%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9876/files
Reloadhttps://github.com/RustPython/RustPython/pull/9876/files
Reloadhttps://github.com/RustPython/RustPython/pull/9876/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/marshal-live-set-20261116https://github.com/youknowdot/RustPython/tree/fix/marshal-live-set-20261116
Conversation 3 https://github.com/RustPython/RustPython/pull/9876
Commits 2 https://github.com/RustPython/RustPython/pull/9876/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9876/checks
Files changed https://github.com/RustPython/RustPython/pull/9876/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9876/files
Preserve live set traversal during deterministic marshal serialization https://github.com/RustPython/RustPython/pull/9876/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9876/files
06d76d7 Detect marshal set changes during live entry traversal youknowone Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9876/commits/06d76d7c17b7795ea810bb8b9e5b87a5415b4ce3
e82409f Update canonical marshal tests to CPython 3.15.2 youknowone Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9876/commits/e82409faca9ac6f95f9366976213f86d4811e594
Clear filters https://github.com/RustPython/RustPython/pull/9876/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9876/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9876/files
test_marshal.py https://github.com/RustPython/RustPython/pull/9876/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
set.rs https://github.com/RustPython/RustPython/pull/9876/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
marshal.rs https://github.com/RustPython/RustPython/pull/9876/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
Lib/test/test_marshal.pyhttps://github.com/RustPython/RustPython/pull/9876/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
View file https://github.com/youknowdot/RustPython/blob/e82409faca9ac6f95f9366976213f86d4811e594/Lib/test/test_marshal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9876/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9876/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/RustPython/RustPython/pull/9876/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/RustPython/RustPython/pull/9876/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
https://github.com/RustPython/RustPython/pull/9876/files#diff-8201bccab835556960180c83492e252bf18bc045bc0dfacf9b290613a4d46269
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/9876/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/youknowdot/RustPython/blob/e82409faca9ac6f95f9366976213f86d4811e594/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9876/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9876/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9876/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
crates/vm/src/stdlib/marshal.rshttps://github.com/RustPython/RustPython/pull/9876/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
View file https://github.com/youknowdot/RustPython/blob/e82409faca9ac6f95f9366976213f86d4811e594/crates/vm/src/stdlib/marshal.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9876/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9876/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
https://github.com/RustPython/RustPython/pull/9876/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
https://github.com/RustPython/RustPython/pull/9876/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
https://github.com/RustPython/RustPython/pull/9876/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9876/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.