Title: Preserve live set traversal during deterministic marshal serialization by youknowdot · Pull Request #9876 · RustPython/RustPython · GitHub
Open Graph Title: Preserve live set traversal during deterministic marshal serialization by youknowdot · Pull Request #9876 · RustPython/RustPython
X Title: Preserve live set traversal during deterministic marshal serialization by youknowdot · Pull Request #9876 · RustPython/RustPython
Description: Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the live mutable set rather than a precomputed snapshot while making deterministic serialization keys. As in CPython 3.15.2 marshal.c, retain the initial cardinality, stop at an extra entry and reject a short traversal. Each entry is owned and no set lock crosses recursive serialization/callbacks. Frozen sets retain their existing immutable snapshot path; stable byte-key sorting and shared-reference serialization are unchanged. Validation status Rust formatting, diff checks and configured commit hooks passed. Fresh Linux native build passed. An earlier separate cargo-check attempt was killed (SIGKILL, no Rust diagnostic); the subsequent serialized native build completed successfully. Unmodified CPython 3.15.2 set-mutation test: all 14 grow/shrink/version subcases now pass, compared with 14 failures on the baseline. Focused set group: 6 tests, 2 huge-memory skips; 4 deterministic-set subcase failures remain identically on baseline/candidate because the test expects repr order to change under hash seeds, before comparing serialization. Normal sets and unorderable-set-item cases pass. External roundtrip/shared-reference identity and mutating-buffer callback-error/unlocked-mutation probes pass in all 7 marshal versions on both the candidate and actual CPython 3.15.2. Canonical test_marshal.py updated via scripts/update_lib quick to CPython 3.15.2. Final suite: 82 run, 16 skipped, 2 expected failures, zero failures/XPASS. Existing deterministic-set marker retained; only the separate complex-constant-folding case gets a new expectedFailure. Assertions/bodies are unchanged. Full workspace/C-API tests, Clippy and cross-platform CI remain pending. This is a draft, not ready for review or merge. No performance result is claimed. The related canonical Lib/test update is now included and verified with the native candidate. Source comparison: CPython v3.15.2 Python/marshal.c set handling, lines 635–714. The separate compiler-folding test issue is outside this patch. AI assistance: Codex reconstructed the patch and prepared this description at the maintainer's direction. Summary by CodeRabbit Improvements Set and frozenset serialization now processes elements through iteration. If a set changes size during serialization, an error is reported instead of silently producing inconsistent output.
Open Graph Description: Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the l...
X Description: Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the l...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9876
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c22aeda0-3681-6e07-cf0c-965673d5362f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDF0:361639:2E4B3B5:3DCD085:6B01DE47 |
| html-safe-nonce | 45a2811c2c3bcbfa67098010f43df7a6b9aaa1f4195f6b013ac08c3eb7179296 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREYwOjM2MTYzOToyRTRCM0I1OjNEQ0QwODU6NkIwMURFNDciLCJ2aXNpdG9yX2lkIjoiNDE4NTc4OTkyNDkxNTY2NjUwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6c9bfd441f09fb909ce19bb841a62eff03eb629bb8fff6a9a6c4d99e2757e261 |
| hovercard-subject-tag | pull_request:5337225305 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9876/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Scope WIP reconstruction of the previously unsubmitted marshal set-mutation fix. This is not a recovery of the former patch and does not inherit its validation results. Use owned entries from the l... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width