René's URL Explorer Experiment


Title: Dispatch ElementTree DOCTYPE callbacks and parser warnings by youknowdot · Pull Request #9874 · RustPython/RustPython · GitHub

Open Graph Title: Dispatch ElementTree DOCTYPE callbacks and parser warnings by youknowdot · Pull Request #9874 · RustPython/RustPython

X Title: Dispatch ElementTree DOCTYPE callbacks and parser warnings by youknowdot · Pull Request #9874 · RustPython/RustPython

Description: Summary Restore the missing native ElementTree DOCTYPE dispatch as one callback/warning fix: Register StartDoctypeDeclHandler and call the cached target's doctype(name, pubid, system). Match CPython 3.15.2 _elementtree.c conversion/order and prefer the target callback over the ignored-parser-method warning. Propagate descriptor, callback and warnings-as-errors exceptions without holding the parser state lock across Python calls. This is a reconstruction of previously unsubmitted work after workspace loss, not a claim that its old test evidence validates this commit. Validation and remaining work cargo fmt --all, git diff --check, configured commit hooks (rustfmt/cspell): passed. cargo check -p rustpython-stdlib --locked: passed (Linux x86-64, Rust 1.99). Fresh Linux native build passed after providing the existing system libffi shared-library link privately. Existing focused accelerator doctype/warning/lookup cases: 5 passed. Full python -m unittest test.test_xml_etree_c: 249 run, 12 skipped, 12 retained expected failures, no failures or XPASS, with the final accelerator-only marker overrides. Full workspace/C-API tests, Clippy and cross-platform CI remain pending. No performance measurement is claimed. The shared canonical expected-failure markers remain; two existing accelerator cases are marked expectedSuccess: pure-Python ElementTree's DefaultHandler-based DOCTYPE handling is a separate pyexpat limitation. No assertions are weakened and no duplicate tests are added. Draft for continued verification, not ready-to-merge. AI assistance: Codex reconstructed the patch, compared CPython source, prepared validation and this description at the maintainer's direction. Summary by CodeRabbit New Features XML parsing now supports doctype declarations, passing the declaration name and identifiers to a registered doctype handler. Bug Fixes Parsers with a doctype attribute but no registered handler now receive a warning that the method is ignored.

Open Graph Description: Summary Restore the missing native ElementTree DOCTYPE dispatch as one callback/warning fix: Register StartDoctypeDeclHandler and call the cached target's doctype(name, pubid, system). Match C...

X Description: Summary Restore the missing native ElementTree DOCTYPE dispatch as one callback/warning fix: Register StartDoctypeDeclHandler and call the cached target's doctype(name, pubid, system). Mat...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9874

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:96c9e72c-47fc-b4b5-217f-b5d8bd4aa800
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE230:158DF1:10AC9A0:160AA7E:6B01DE5D
html-safe-nonce7613524eb9eb56a968cf65122cfb50fdcecf785492025fcffeb3a12803a0e7bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjMwOjE1OERGMToxMEFDOUEwOjE2MEFBN0U6NkIwMURFNUQiLCJ2aXNpdG9yX2lkIjoiMzY4ODA2OTA2NTc0Nzg0ODc5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac87985a6e3a9c43242671f1e34232e62b6e03014aff1d4cbea14cd79e90d5ffca
hovercard-subject-tagpull_request:5337133851
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9874/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Restore the missing native ElementTree DOCTYPE dispatch as one callback/warning fix: Register StartDoctypeDeclHandler and call the cached target's doctype(name, pubid, system). Match C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9874/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9874%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9874%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9874/files
Reloadhttps://github.com/RustPython/RustPython/pull/9874/files
Reloadhttps://github.com/RustPython/RustPython/pull/9874/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/elementtree-doctype-20261116https://github.com/youknowdot/RustPython/tree/fix/elementtree-doctype-20261116
Conversation 4 https://github.com/RustPython/RustPython/pull/9874
Commits 2 https://github.com/RustPython/RustPython/pull/9874/commits
Checks 21 https://github.com/RustPython/RustPython/pull/9874/checks
Files changed https://github.com/RustPython/RustPython/pull/9874/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9874/files
Dispatch ElementTree DOCTYPE callbacks and parser warnings https://github.com/RustPython/RustPython/pull/9874/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9874/files
bce91f8 Dispatch ElementTree doctype target callbacks and parser warnings youknowone Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9874/commits/bce91f8e586446808484df5919f787f7dbb0e2e2
4ea8d0c Enable native ElementTree doctype canonical cases youknowone Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9874/commits/4ea8d0c62f57583a1cd2eec23aa27fc906016e62
Clear filters https://github.com/RustPython/RustPython/pull/9874/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9874/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9874/files
test_xml_etree_c.py https://github.com/RustPython/RustPython/pull/9874/files#diff-f6a8b0add3c473134d7ff3bebba5693bb02a850fcfa6e27800925f849e221285
elementtree.rs https://github.com/RustPython/RustPython/pull/9874/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
Lib/test/test_xml_etree_c.pyhttps://github.com/RustPython/RustPython/pull/9874/files#diff-f6a8b0add3c473134d7ff3bebba5693bb02a850fcfa6e27800925f849e221285
View file https://github.com/youknowdot/RustPython/blob/4ea8d0c62f57583a1cd2eec23aa27fc906016e62/Lib/test/test_xml_etree_c.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9874/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9874/files#diff-f6a8b0add3c473134d7ff3bebba5693bb02a850fcfa6e27800925f849e221285
https://github.com/RustPython/RustPython/pull/9874/files#diff-f6a8b0add3c473134d7ff3bebba5693bb02a850fcfa6e27800925f849e221285
crates/stdlib/src/elementtree.rshttps://github.com/RustPython/RustPython/pull/9874/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
View file https://github.com/youknowdot/RustPython/blob/4ea8d0c62f57583a1cd2eec23aa27fc906016e62/crates/stdlib/src/elementtree.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9874/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9874/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9874/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9874/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9874/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9874/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.