René's URL Explorer Experiment


Title: Restore Windows API audit boundaries by youknowdot · Pull Request #9873 · RustPython/RustPython · GitHub

Open Graph Title: Restore Windows API audit boundaries by youknowdot · Pull Request #9873 · RustPython/RustPython

X Title: Restore Windows API audit boundaries by youknowdot · Pull Request #9873 · RustPython/RustPython

Description: Summary Restore the twelve _winapi audit sites from CPython 3.15 together: file, pipe, process, event, mutex, junction, and CopyFile2 operations. Audit vetoes run before native side effects, with the corresponding argument payloads. Convert LPCWSTR arguments once at their binding position, preserving the original string owner without an additional reference-count increment. Use C-int semantics for BOOL arguments, preserving their integer audit payload rather than applying Python truth testing. Preserve CreateJunction's invalid-prefix check before audit and CreateProcess's audit-before-startup/environment processing order. Extend the existing audit snippet with eleven APIs' veto/payload checks plus NUL-conversion, BOOL-conversion, and junction-prefix boundaries. Keep the canonical expectedFailure marker until actual Windows execution confirms it can be removed. Reference and limits Reference: CPython 3.15 Modules/_winapi.c and generated Clinic wrappers. This is not a claim of complete _winapi parity. Existing DWORD/UINT argument conversion differences (strict Rust u32 versus CPython bitfield conversion) remain outside this patch. Current CPython 3.15 source passes a PyObject *command_line to a "uuu" CreateProcess audit format. This patch does not reproduce that unsafe pointer interpretation: it emits the intended (application_name, command_line, current_directory) objects safely. The shared snippet deliberately does not exercise that reference-implementation path; Windows runtime comparison for CreateProcess remains outstanding. Validation Windows GNU cross-target VM Clippy with default features and threading: passed; four warnings remain in unchanged nt.rs/os.rs under this package-only configuration. rustfmt, Python syntax, diff checks, and normal repository hooks: passed. Actual Windows execution, full workspace/C-API tests, complete snippets and performance measurement have not run locally; draft CI will provide target execution coverage. No benchmark result is claimed. Independent of #9871, based directly on main. Summary by CodeRabbit Bug Fixes Windows API calls now validate string arguments, reject embedded null characters, and consistently convert integer flags to boolean values. Process creation requires the command line to be a string or None and converts environment mappings during the call. Junction creation rejects paths with an unsupported Windows prefix. Successful process termination now returns None. New Features Added audit events for selected Windows API calls, including process creation, file operations, and process termination. Tests Added Windows-specific tests for audit events and invalid argument handling.

Open Graph Description: Summary Restore the twelve _winapi audit sites from CPython 3.15 together: file, pipe, process, event, mutex, junction, and CopyFile2 operations. Audit vetoes run before native side effects, with t...

X Description: Summary Restore the twelve _winapi audit sites from CPython 3.15 together: file, pipe, process, event, mutex, junction, and CopyFile2 operations. Audit vetoes run before native side effects, with t...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9873

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:32c29474-4049-532a-4128-7683cd2a5336
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE90A:313081:11F68B3:17BB61D:6B01E3F5
html-safe-nonce1c7bb4370beaa6eeb846d64cd750449e2a94b3b647a3a6890fab3faa4a7ed1c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTBBOjMxMzA4MToxMUY2OEIzOjE3QkI2MUQ6NkIwMUUzRjUiLCJ2aXNpdG9yX2lkIjoiNTAzMDAyNjQyNjI0MjQyNTg0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9e7924024121313016ebe9d5199b239993e7b1ae76bd4bf6fe9144262dcec383
hovercard-subject-tagpull_request:5337117357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9873/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Restore the twelve _winapi audit sites from CPython 3.15 together: file, pipe, process, event, mutex, junction, and CopyFile2 operations. Audit vetoes run before native side effects, with t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9873/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9873%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9873%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9873/files
Reloadhttps://github.com/RustPython/RustPython/pull/9873/files
Reloadhttps://github.com/RustPython/RustPython/pull/9873/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/winapi-audit-boundarieshttps://github.com/youknowdot/RustPython/tree/fix/winapi-audit-boundaries
Conversation 4 https://github.com/RustPython/RustPython/pull/9873
Commits 3 https://github.com/RustPython/RustPython/pull/9873/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9873/checks
Files changed https://github.com/RustPython/RustPython/pull/9873/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9873/files
Restore Windows API audit boundaries https://github.com/RustPython/RustPython/pull/9873/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9873/files
2b73afc Restore Windows API audit boundaries youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9873/commits/2b73afc9b5bdcbe75bcc53de4dbf0a1e17909604
601e1df Enable the passing CreateNamedPipe audit test youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9873/commits/601e1df21b1649495d3406b423a5255d1e31135c
064c082 Cover CreateProcess audit denial before argument processing codex Nov 17, 2026 https://github.com/RustPython/RustPython/pull/9873/commits/064c082cb436c0f7a227dbf04ccdd6750770d792
Clear filters https://github.com/RustPython/RustPython/pull/9873/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9873/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9873/files
test_audit.py https://github.com/RustPython/RustPython/pull/9873/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
_winapi.rs https://github.com/RustPython/RustPython/pull/9873/files#diff-97cc2c90c1227b573945558c6c4684b975fb88fd8c4097e212a5594ded208b9a
stdlib_sys_audit.py https://github.com/RustPython/RustPython/pull/9873/files#diff-53931be7c5d2819bc8e4df20334aaa1b3149fc9cc7af20939511eb9d94b7b1b7
Lib/test/test_audit.pyhttps://github.com/RustPython/RustPython/pull/9873/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
View file https://github.com/youknowdot/RustPython/blob/064c082cb436c0f7a227dbf04ccdd6750770d792/Lib/test/test_audit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9873/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9873/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
https://github.com/RustPython/RustPython/pull/9873/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9873/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9873/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.