René's URL Explorer Experiment


Title: Align Windows registry audits and handle ownership by youknowdot · Pull Request #9871 · RustPython/RustPython · GitHub

Open Graph Title: Align Windows registry audits and handle ownership by youknowdot · Pull Request #9871 · RustPython/RustPython

X Title: Align Windows registry audits and handle ownership by youknowdot · Pull Request #9871 · RustPython/RustPython

Description: Summary Align a coherent group of registry handle and auditing boundaries with CPython 3.15 PC/winreg.c: Keep converted PyHKEY owners alive across later conversions and audit hooks, transferring the existing reference rather than cloning it. Reuse this converter for integer handles. Accept CloseKey(None/int/PyHKEY), preserve Windows error codes, enforce the three context-exit arguments, and audit Detach before changing the handle, including veto and reentrancy. Add the missing registry audit events and close newly acquired handles when a result hook rejects them. Build audit arguments lazily. Support nullable CreateKey/CreateKeyEx subkeys and C-int conversion boundaries for access/reserved arguments. Extend the existing audit snippet with veto, conversion-order, reentrant detach, temporary-owner and result-cleanup cases. This does not claim complete winreg parity. Other String-based API conversion and output-format differences are outside this patch. _winapi is unchanged. Verification Windows GNU VM cargo check passed (--no-default-features --features host_env,gc). This reduced configuration emitted 22 warnings outside the changed code. Windows GNU VM Clippy with default features and threading passed. Four warnings remain in unchanged nt.rs/os.rs. Required commit hooks passed after accepting their formatting fixes; Python syntax and git diff --check passed. Independently reviewed handle ownership, audit rejection/reentrancy, signed-handle payloads and native call ordering against CPython. Pending: actual Windows execution of test_audit, test_winreg and the snippet in CI. The canonical expectedFailure marker is deliberately retained until Windows results establish it can be removed. A resulting XPASS will be addressed in this PR. Local full workspace/C-API tests and performance benchmarks were not run; cross-compilation is not runtime or performance validation. AI assistance: OpenAI Codex assisted implementation, regression tests and review. The contribution is made at the maintainer's direction; commit attribution is recorded with Assisted-by.

Open Graph Description: Summary Align a coherent group of registry handle and auditing boundaries with CPython 3.15 PC/winreg.c: Keep converted PyHKEY owners alive across later conversions and audit hooks, transferring t...

X Description: Summary Align a coherent group of registry handle and auditing boundaries with CPython 3.15 PC/winreg.c: Keep converted PyHKEY owners alive across later conversions and audit hooks, transferring t...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9871

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f55790a3-89d4-6a93-e41a-8b815257320b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA848:1CCECA:E0F5A6:12C684A:6B01DE3C
html-safe-noncea5c9ecd58ce4306873a79a12e2037ba94cb94fd9a9797c52604c774ec86a8186
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODQ4OjFDQ0VDQTpFMEY1QTY6MTJDNjg0QTo2QjAxREUzQyIsInZpc2l0b3JfaWQiOiI4NjM5OTE4MzcwOTE5MTQ1MDIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac90c56f5f38ef0ba94752cf1031253f55d6e1e8a81c9fa7c0d06a4d5706b21ab3
hovercard-subject-tagpull_request:5336459665
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9871/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Align a coherent group of registry handle and auditing boundaries with CPython 3.15 PC/winreg.c: Keep converted PyHKEY owners alive across later conversions and audit hooks, transferring t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9871/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9871%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9871%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9871/files
Reloadhttps://github.com/RustPython/RustPython/pull/9871/files
Reloadhttps://github.com/RustPython/RustPython/pull/9871/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/winreg-handle-audithttps://github.com/youknowdot/RustPython/tree/fix/winreg-handle-audit
Conversation 6 https://github.com/RustPython/RustPython/pull/9871
Commits 5 https://github.com/RustPython/RustPython/pull/9871/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9871/checks
Files changed https://github.com/RustPython/RustPython/pull/9871/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9871/files
Align Windows registry audits and handle ownership https://github.com/RustPython/RustPython/pull/9871/files#top
Show all changes 5 commits https://github.com/RustPython/RustPython/pull/9871/files
00e3f27 Align Windows registry audits and handle ownership youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9871/commits/00e3f274c6bb1bab96bc5927bac33d71270d6287
4d5c221 Match registry value conversion failures to CPython youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9871/commits/4d5c2216e14e398d600c3646b9a776b51f00210e
deafd5c Account for CPython 3.15.0 registry audit handle leak codex Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9871/commits/deafd5cd006232bd48c70fdafff57509784c65fa
08257f5 Probe rejected registry handles without query access youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9871/commits/08257f5c56afa4a6450174b585fa920e57c28bef
b61ec83 Remove passing Windows registry audit failure marker youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9871/commits/b61ec8360453ebde80e50373e8cf9fc5928ce8bc
Clear filters https://github.com/RustPython/RustPython/pull/9871/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9871/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9871/files
test_audit.py https://github.com/RustPython/RustPython/pull/9871/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
winreg.rs https://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
winreg.rs https://github.com/RustPython/RustPython/pull/9871/files#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a
stdlib_sys_audit.py https://github.com/RustPython/RustPython/pull/9871/files#diff-53931be7c5d2819bc8e4df20334aaa1b3149fc9cc7af20939511eb9d94b7b1b7
Lib/test/test_audit.pyhttps://github.com/RustPython/RustPython/pull/9871/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
View file https://github.com/youknowdot/RustPython/blob/b61ec8360453ebde80e50373e8cf9fc5928ce8bc/Lib/test/test_audit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9871/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9871/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
https://github.com/RustPython/RustPython/pull/9871/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
crates/host_env/src/winreg.rshttps://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
View file https://github.com/youknowdot/RustPython/blob/b61ec8360453ebde80e50373e8cf9fc5928ce8bc/crates/host_env/src/winreg.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9871/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
https://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
https://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
https://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
https://github.com/RustPython/RustPython/pull/9871/files#diff-fe15b3e713597f9cee065f34f9655011be6903aaba5c9ece0d7720ce5c283dc6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9871/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9871/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.