René's URL Explorer Experiment


Title: Restore Windows cyclic I/O collection coverage by youknowdot · Pull Request #9848 · RustPython/RustPython · GitHub

Open Graph Title: Restore Windows cyclic I/O collection coverage by youknowdot · Pull Request #9848 · RustPython/RustPython

X Title: Restore Windows cyclic I/O collection coverage by youknowdot · Pull Request #9848 · RustPython/RustPython

Description: Summary Restore the six canonical I/O cyclic-collection regressions hidden by five Windows-only RustPython skip decorators. The tests cover FileIO (native and Python implementations), BufferedReader, BufferedWriter, BufferedRandom, and TextIOWrapper. Only obsolete skips are removed; the upstream test bodies and their assertions are unchanged. No duplicate custom tests or runtime changes are added. Why these skips can be revisited The old reason says cyclic GC is unsupported. Current main runs object finalizers before clearing an unreachable cycle. The I/O types route finalization through iobase_finalize and close; FileIO takes ownership of its descriptor with fd.swap(-1) and closes it through the host-owned descriptor path, including the Windows CRT implementation. The canonical tests check collection and buffered flushes. This is not a claim that Linux validates Windows file locking. The PR is a draft so Windows CI can run the restored tests. No individual commit is claimed to have fixed the historical issue without bisection. Validation Clean main-runtime release build (4f65ad070 plus only these skip removals) succeeds. All six restored tests pass in 25 repetitions: 150 successful test executions. Complete -m test test_io: 1,044 tests run, 52 existing skips, no failures. An external diagnostic exercised collection and descriptor closure for 250 cyclic FileIO/buffered/text handles; all were closed. This diagnostic is not added as a duplicate test. The same 150 test executions and handle diagnostic pass with CPython 3.15.0. prek run --files ... and git diff --check pass. Windows/macOS execution is pending CI. Full workspace/C-API suites, Clippy and a benchmark are not run for this tests-only change. CI follow-up Windows job 132726496229 on head 12eea208f2dc90b4a62d0c03abb86cba4e352ce6 completed successfully. Its actual regrtest log confirms test.test_io.test_general, test.test_io.test_bufferedio, and test.test_io.test_textio ran and passed, rather than merely relying on a green aggregate check. Windows, Linux, and macOS Rust/Python jobs passed. Change-filtered cross-build/Clippy/Miri/WASM-package jobs and the base/head/CPython comparison were skipped; no performance improvement is claimed.

Open Graph Description: Summary Restore the six canonical I/O cyclic-collection regressions hidden by five Windows-only RustPython skip decorators. The tests cover FileIO (native and Python implementations), BufferedReade...

X Description: Summary Restore the six canonical I/O cyclic-collection regressions hidden by five Windows-only RustPython skip decorators. The tests cover FileIO (native and Python implementations), BufferedReade...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9848

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4fbce5a8-4700-752f-af26-5df75fd5b869
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A84:A71F9:2A5EA95:35A4FC7:6B01DE78
html-safe-noncee140113732b1331eb34216bc4b492bc7569c66ca0a04fff6bc5edd4646718f51
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTg0OkE3MUY5OjJBNUVBOTU6MzVBNEZDNzo2QjAxREU3OCIsInZpc2l0b3JfaWQiOiI0NzgxNDM0NzQ5OTQyMDk1NDgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a8e2a6f343d0ed46997d3b5dc21a24659128832be6e3d32516540f42589a3ec
hovercard-subject-tagpull_request:5320210240
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9848/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Restore the six canonical I/O cyclic-collection regressions hidden by five Windows-only RustPython skip decorators. The tests cover FileIO (native and Python implementations), BufferedReade...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9848/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9848%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9848%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9848/files
Reloadhttps://github.com/RustPython/RustPython/pull/9848/files
Reloadhttps://github.com/RustPython/RustPython/pull/9848/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/io-gc-regressions-20261115https://github.com/youknowdot/RustPython/tree/fix/io-gc-regressions-20261115
Conversation 4 https://github.com/RustPython/RustPython/pull/9848
Commits 1 https://github.com/RustPython/RustPython/pull/9848/commits
Checks 21 https://github.com/RustPython/RustPython/pull/9848/checks
Files changed https://github.com/RustPython/RustPython/pull/9848/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9848/files
Restore Windows cyclic I/O collection coverage https://github.com/RustPython/RustPython/pull/9848/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9848/files
12eea20 Restore cyclic I/O collection tests on Windows codex Nov 15, 2026 https://github.com/RustPython/RustPython/pull/9848/commits/12eea208f2dc90b4a62d0c03abb86cba4e352ce6
Clear filters https://github.com/RustPython/RustPython/pull/9848/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9848/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9848/files
test_bufferedio.py https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
test_general.py https://github.com/RustPython/RustPython/pull/9848/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
test_textio.py https://github.com/RustPython/RustPython/pull/9848/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Lib/test/test_io/test_bufferedio.pyhttps://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
View file https://github.com/youknowdot/RustPython/blob/12eea208f2dc90b4a62d0c03abb86cba4e352ce6/Lib/test/test_io/test_bufferedio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9848/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
https://github.com/RustPython/RustPython/pull/9848/files#diff-476088eb5a1c740688919c90c1c29143f7ec860a9087c72e87db405836826e0f
Lib/test/test_io/test_general.pyhttps://github.com/RustPython/RustPython/pull/9848/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
View file https://github.com/youknowdot/RustPython/blob/12eea208f2dc90b4a62d0c03abb86cba4e352ce6/Lib/test/test_io/test_general.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9848/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9848/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
https://github.com/RustPython/RustPython/pull/9848/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
Lib/test/test_io/test_textio.pyhttps://github.com/RustPython/RustPython/pull/9848/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
View file https://github.com/youknowdot/RustPython/blob/12eea208f2dc90b4a62d0c03abb86cba4e352ce6/Lib/test/test_io/test_textio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9848/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9848/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
https://github.com/RustPython/RustPython/pull/9848/files#diff-871737268f0629fa5bc32f116d3c5f1a37accc05d5505883c9f0f21bf6ac7ee3
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9848/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.