René's URL Explorer Experiment


Title: Restore six skipped weakref concurrency regressions by youknowdot · Pull Request #9846 · RustPython/RustPython · GitHub

Open Graph Title: Restore six skipped weakref concurrency regressions by youknowdot · Pull Request #9846 · RustPython/RustPython

X Title: Restore six skipped weakref concurrency regressions by youknowdot · Pull Request #9846 · RustPython/RustPython

Description: Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and weak-value dictionary copy/deepcopy during collection. Only the six skip decorators are removed. Test bodies, their original 100,000 iteration / 70,000 entry workloads, threading guards and CPU-resource guards are unchanged. There is no interpreter change and no duplicate custom regression suite. Rationale Current main passes these tests repeatedly. The existing implementation already uses conditional dead-weakref deletion, snapshot-based dictionary copying, synchronized weakref publication/callback ownership, and a stopped-world final liveness/weakref-closure phase. Relevant earlier work includes #9168 and #9215. This PR does not claim that #9842, or any single commit, was proven by bisection to have fixed the historical intermittent crashes. Validation Linux release: 10 rounds of all six tests, 60 successful test executions without skips. Linux release and debug: complete -m test test_weakref -u cpu -v, 138 tests with seven existing CPython-only skips. Linux debug: an additional round of all six, without skips. CPython 3.15.0: the same six tests pass. prek run --files Lib/test/test_weakref.py and git diff --check pass. The initial release/debug runs used main 4f65ad070 plus unrelated pyexpat changes. A subsequent serialized cargo build --release -j1 from main 4f65ad070 with only these six skip removals also succeeded. On that clean-runtime build, all six tests passed again and the full module passed (138 tests, the same seven CPython-only skips). The first concurrent build attempt was killed with SIGKILL; serializing the build resolved that resource failure. Not run here: ASan/TSan, Windows/macOS, a benchmark, full workspace/C-API test suites, or full Clippy. This remains a draft for cross-platform CI; repeated successful runs are evidence, not proof that every possible race is absent. The existing CPU-resource conditions still control whether the four expensive copy tests execute in a given CI job.

Open Graph Description: Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and w...

X Description: Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and w...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9846

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:308629b4-a66c-74fa-38b3-0ac47de96d7e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF3A:34DB8F:2D2840A:3C6606B:6B01DE29
html-safe-noncee1e7463574fdf2bc57a4099722ada6bdc485361a07b78112fff1adeb91e52918
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjNBOjM0REI4RjoyRDI4NDBBOjNDNjYwNkI6NkIwMURFMjkiLCJ2aXNpdG9yX2lkIjoiNTI3MTA2NzUzMjg1NjUxNjEzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca894876d597ead6f4884a51493e82e478d73876a536015a1131c554e81458d35
hovercard-subject-tagpull_request:5320050286
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9846/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9846/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9846%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9846%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9846/files
Reloadhttps://github.com/RustPython/RustPython/pull/9846/files
Reloadhttps://github.com/RustPython/RustPython/pull/9846/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/weakref-gc-regressions-20261115https://github.com/youknowdot/RustPython/tree/fix/weakref-gc-regressions-20261115
Conversation 4 https://github.com/RustPython/RustPython/pull/9846
Commits 1 https://github.com/RustPython/RustPython/pull/9846/commits
Checks 21 https://github.com/RustPython/RustPython/pull/9846/checks
Files changed https://github.com/RustPython/RustPython/pull/9846/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9846/files
Restore six skipped weakref concurrency regressions https://github.com/RustPython/RustPython/pull/9846/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9846/files
31051f5 Restore six weakref concurrency regression tests youknowdot Nov 15, 2026 https://github.com/RustPython/RustPython/pull/9846/commits/31051f5aacefd601a4b1d2e0d3ca387309753f7e
Clear filters https://github.com/RustPython/RustPython/pull/9846/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9846/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9846/files
Lib/test/test_weakref.pyhttps://github.com/RustPython/RustPython/pull/9846/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575
View file https://github.com/youknowdot/RustPython/blob/31051f5aacefd601a4b1d2e0d3ca387309753f7e/Lib/test/test_weakref.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9846/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9846/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575
https://github.com/RustPython/RustPython/pull/9846/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575
https://github.com/RustPython/RustPython/pull/9846/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575
https://github.com/RustPython/RustPython/pull/9846/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575
https://github.com/RustPython/RustPython/pull/9846/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9846/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.