Title: Restore six skipped weakref concurrency regressions by youknowdot · Pull Request #9846 · RustPython/RustPython · GitHub
Open Graph Title: Restore six skipped weakref concurrency regressions by youknowdot · Pull Request #9846 · RustPython/RustPython
X Title: Restore six skipped weakref concurrency regressions by youknowdot · Pull Request #9846 · RustPython/RustPython
Description: Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and weak-value dictionary copy/deepcopy during collection. Only the six skip decorators are removed. Test bodies, their original 100,000 iteration / 70,000 entry workloads, threading guards and CPU-resource guards are unchanged. There is no interpreter change and no duplicate custom regression suite. Rationale Current main passes these tests repeatedly. The existing implementation already uses conditional dead-weakref deletion, snapshot-based dictionary copying, synchronized weakref publication/callback ownership, and a stopped-world final liveness/weakref-closure phase. Relevant earlier work includes #9168 and #9215. This PR does not claim that #9842, or any single commit, was proven by bisection to have fixed the historical intermittent crashes. Validation Linux release: 10 rounds of all six tests, 60 successful test executions without skips. Linux release and debug: complete -m test test_weakref -u cpu -v, 138 tests with seven existing CPython-only skips. Linux debug: an additional round of all six, without skips. CPython 3.15.0: the same six tests pass. prek run --files Lib/test/test_weakref.py and git diff --check pass. The initial release/debug runs used main 4f65ad070 plus unrelated pyexpat changes. A subsequent serialized cargo build --release -j1 from main 4f65ad070 with only these six skip removals also succeeded. On that clean-runtime build, all six tests passed again and the full module passed (138 tests, the same seven CPython-only skips). The first concurrent build attempt was killed with SIGKILL; serializing the build resolved that resource failure. Not run here: ASan/TSan, Windows/macOS, a benchmark, full workspace/C-API test suites, or full Clippy. This remains a draft for cross-platform CI; repeated successful runs are evidence, not proof that every possible race is absent. The existing CPU-resource conditions still control whether the four expensive copy tests execute in a given CI job.
Open Graph Description: Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and w...
X Description: Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and w...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9846
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:308629b4-a66c-74fa-38b3-0ac47de96d7e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF3A:34DB8F:2D2840A:3C6606B:6B01DE29 |
| html-safe-nonce | e1e7463574fdf2bc57a4099722ada6bdc485361a07b78112fff1adeb91e52918 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjNBOjM0REI4RjoyRDI4NDBBOjNDNjYwNkI6NkIwMURFMjkiLCJ2aXNpdG9yX2lkIjoiNTI3MTA2NzUzMjg1NjUxNjEzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a894876d597ead6f4884a51493e82e478d73876a536015a1131c554e81458d35 |
| hovercard-subject-tag | pull_request:5320050286 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9846/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Restore six canonical test_weakref concurrency regressions currently hidden by RustPython-specific crash/race skips: weak-value setdefault and consistency during collection; weak-key and w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width