René's URL Explorer Experiment


Title: Honor native XML encodings and declaration callbacks by youknowdot · Pull Request #9845 · RustPython/RustPython · GitHub

Open Graph Title: Honor native XML encodings and declaration callbacks by youknowdot · Pull Request #9845 · RustPython/RustPython

X Title: Honor native XML encodings and declaration callbacks by youknowdot · Pull Request #9845 · RustPython/RustPython

Description: Summary Honor ParserCreate(encoding=...) for the six native XML encodings instead of discarding it. Keep the first Parse input mode when byte/string chunks are mixed. Detect BOM-less UTF-16 before starting the XML backend, including a first code unit split between calls. Preserve XML declaration presence and original attribute values; invoke XmlDeclHandler only after the backend validates the declaration. No declaration does not produce a synthetic callback, and omitted encoding remains None. Restore the three SAX byte/file/InputSource encoding tests together. Add boundary/metadata coverage to the existing pyexpat snippet. The document is still decoded by the native XML backend. This does not add a general Python-codec-to-UTF-8 preprocessor: that would change Expat's codec lookup/callback order and byte positions. Unknown/custom encodings, DTD callbacks, namespace declaration fidelity and existing backend diagnostic differences remain outside this patch. The corresponding expected-failure markers remain. Reference Compared against CPython 3.15 Modules/pyexpat.c (ParserCreate, Parse, XML_SetEncoding, declaration callbacks) and its Expat encoding initialization. This is independent of #9838's character buffering work and based directly on current main. Validation cargo check -p rustpython-stdlib --lib: passed. Release and debug builds: passed. -m test test_pyexpat test_sax test_xml_etree test_xmlrpc test_pulldom: passed, 606 tests, 26 skipped. Updated pyexpat snippet: passed on RustPython release/debug and CPython 3.15. Commit hooks: passed (formatter changes restaged normally). Full snippet suite: 494 passed, 15 subtests passed, 21 failed. Failures are local-environment issues: restricted local sockets/multiprocessing, the uid/chown environment, optional SQLite absent from the RustPython build, and _ctypes/_lzma/_sqlite3 missing from the reference CPython build. The six failing RustPython snippets also fail on the unchanged baseline binary. Workspace tests were attempted, but rustc compiling the VM test target was killed by SIGKILL without a compiler diagnostic during concurrent builds. This is not reported as a passing test run. C-API tests: 149 passed, 2 ignored. C-API Clippy: passed. Workspace Clippy: passed on the local Rust 1.99 toolchain, with existing must_use_candidate warnings in unchanged src/lib.rs and src/main.rs. The latest-head CI is still in progress. Initial Rust 1.100 CI lint diagnostics (chunks_exact_to_as_chunks, manual_is_multiple_of) were corrected in 791fdbc43; no lint suppression was added. The WASM job had failed on these same diagnostics. A small 7-sample XML throughput smoke measurement was run, but concurrent build load made it too noisy to claim a performance result. The comparative CI benchmark job was skipped; its wrapper's green status is not a benchmark pass. No sanitizer, Windows or wasm execution has been performed locally yet.

Open Graph Description: Summary Honor ParserCreate(encoding=...) for the six native XML encodings instead of discarding it. Keep the first Parse input mode when byte/string chunks are mixed. Detect BOM-less UTF-16 before...

X Description: Summary Honor ParserCreate(encoding=...) for the six native XML encodings instead of discarding it. Keep the first Parse input mode when byte/string chunks are mixed. Detect BOM-less UTF-16 before...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9845

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c69d29b4-8d91-8f9b-cda6-9d2cb6ad8e54
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A70:5D487:F966B1:14B3E4A:6B01DE4E
html-safe-nonce66e36b55eb04056e877c2d65feb7d5b88dc29f07b868d799de354c6e484a186f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTcwOjVENDg3OkY5NjZCMToxNEIzRTRBOjZCMDFERTRFIiwidmlzaXRvcl9pZCI6IjE1NDcxNTAwMDg5NzE4MTI0MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac591ad3afd6e251d97c1845e593e023ba853a62a4f357ad17d3ec735cd9554670
hovercard-subject-tagpull_request:5319906497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9845/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Honor ParserCreate(encoding=...) for the six native XML encodings instead of discarding it. Keep the first Parse input mode when byte/string chunks are mixed. Detect BOM-less UTF-16 before...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9845/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9845%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9845%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9845/files
Reloadhttps://github.com/RustPython/RustPython/pull/9845/files
Reloadhttps://github.com/RustPython/RustPython/pull/9845/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/pyexpat-native-encoding-declarationshttps://github.com/youknowdot/RustPython/tree/fix/pyexpat-native-encoding-declarations
Conversation 5 https://github.com/RustPython/RustPython/pull/9845
Commits 2 https://github.com/RustPython/RustPython/pull/9845/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9845/checks
Files changed https://github.com/RustPython/RustPython/pull/9845/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9845/files
Honor native XML encodings and declaration callbacks https://github.com/RustPython/RustPython/pull/9845/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9845/files
ead88d3 Preserve native XML encodings and declaration callbacks youknowdot Nov 15, 2026 https://github.com/RustPython/RustPython/pull/9845/commits/ead88d3e465c4685c7c58e0316f93624f36d8f75
791fdbc Use slice array chunks for XML declaration decoding youknowdot Nov 15, 2026 https://github.com/RustPython/RustPython/pull/9845/commits/791fdbc439ef760d0e5845b312e1256395a1528b
Clear filters https://github.com/RustPython/RustPython/pull/9845/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9845/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9845/files
test_sax.py https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
pyexpat.rs https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
stdlib_pyexpat.py https://github.com/RustPython/RustPython/pull/9845/files#diff-95f9b23dc92cbf099edf103303b2bcf53ee267d9ff01792010896085bc340ac2
Lib/test/test_sax.pyhttps://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
View file https://github.com/youknowdot/RustPython/blob/791fdbc439ef760d0e5845b312e1256395a1528b/Lib/test/test_sax.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9845/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
https://github.com/RustPython/RustPython/pull/9845/files#diff-849099ae522fd1e278d65ffb7cdc29866e97ec8e8b03ea5ef72121b6ccb46d1c
crates/stdlib/src/pyexpat.rshttps://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
View file https://github.com/youknowdot/RustPython/blob/791fdbc439ef760d0e5845b312e1256395a1528b/crates/stdlib/src/pyexpat.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9845/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 15, 2026https://github.com/RustPython/RustPython/pull/9845/files#r4577507792
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/0854bfc38139c0d2b58a9d5d71f5ad92840cf0c17144621e462b474041793354/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50322d79656c6c6f773f7374796c653d666c6174
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9845/files
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
https://github.com/RustPython/RustPython/pull/9845/files#diff-7f4c525df38078045fcc6955c53f774ac806800c790e024f06fd3ce2b188f33b
extra_tests/snippets/stdlib_pyexpat.pyhttps://github.com/RustPython/RustPython/pull/9845/files#diff-95f9b23dc92cbf099edf103303b2bcf53ee267d9ff01792010896085bc340ac2
View file https://github.com/youknowdot/RustPython/blob/791fdbc439ef760d0e5845b312e1256395a1528b/extra_tests/snippets/stdlib_pyexpat.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9845/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9845/files#diff-95f9b23dc92cbf099edf103303b2bcf53ee267d9ff01792010896085bc340ac2
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9845/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.