René's URL Explorer Experiment


Title: Revalidate cached modules after import initialization by youknowdot · Pull Request #9839 · RustPython/RustPython · GitHub

Open Graph Title: Revalidate cached modules after import initialization by youknowdot · Pull Request #9839 · RustPython/RustPython

X Title: Revalidate cached modules after import initialization by youknowdot · Pull Request #9839 · RustPython/RustPython

Description: Summary Revalidate cached modules after inspecting __spec__._initializing or waiting for initialization, following CPython 3.15.2's PyImport_ImportModuleLevelObject. If an import failed and removed or replaced the cached module, retry through _find_and_load instead of returning a stale reference. Preserve the actual import exception. Apply the same identity check to the VM's cached IMPORT_NAME fast path. A reentrant __spec__ getter can change the cache even without threads. Preserve whether initialization was in progress so lazy-submodule cleanup follows CPython's ordering. Restore the existing import-failure race test. Add distinct synchronous replacement coverage to the existing import snippet for direct __import__ and IMPORT_NAME. This adds one necessary cache lookup/identity comparison on cache hits, as CPython does. It does not add a lock, another initialization check, or claim zero runtime cost. The unrelated large-memory parallel-path-hooks test remains unchanged. Validation Reproduced the canonical race failure and synchronous replacement failure on exact main 1d1795739; both pass on CPython 3.15.2. Changed RustPython: canonical race test passed 10 repeated runs; full threaded-import module passed (11 tests, 5 existing large-memory skips). Full test_importlib: 1,219 tests, 55 skips, success. Complete existing import snippet passed. Interpreter build, threading-enabled VM all-target Clippy, and VM library tests passed (234 passed, 2 ignored). All applicable configured pre-commit hooks passed, including rustfmt, Ruff, redundant-test-patch checks and cspell. Full extra_tests pytest: 495 passed, 20 failed, 15 subtests passed. The failures are the same 14 host/CPython and 6 RustPython baseline failures previously reproduced on main; this is not an all-green result. Full workspace and separate C-API tests have not been run locally because of limited disk space. No Windows/WASM-specific validation or performance measurement is claimed. Reference: CPython 3.15.2 import.c. AI assistance: OpenAI Codex assisted diagnosis, implementation, independent source review and testing under maintainer direction. The runtime does not expose the exact model version.

Open Graph Description: Summary Revalidate cached modules after inspecting __spec__._initializing or waiting for initialization, following CPython 3.15.2's PyImport_ImportModuleLevelObject. If an import failed and re...

X Description: Summary Revalidate cached modules after inspecting __spec__._initializing or waiting for initialization, following CPython 3.15.2's PyImport_ImportModuleLevelObject. If an import failed an...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9839

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14b56c32-490f-d921-db39-f3a8bdb0df83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC01E:3C21B:368BFE6:45C0924:6B01DE7E
html-safe-nonce6627e363fa598525dd786d29d1396ffc9ff3e96e3ba7c5848f2425148c8e4e62
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDFFOjNDMjFCOjM2OEJGRTY6NDVDMDkyNDo2QjAxREU3RSIsInZpc2l0b3JfaWQiOiIzNDk2OTM4MTkzNTMyNjA4MTI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace4eb228951dc048c38f569c75ed63d9e08315a1380603a574373a294a96b4143
hovercard-subject-tagpull_request:5312882957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9839/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Revalidate cached modules after inspecting __spec__._initializing or waiting for initialization, following CPython 3.15.2's PyImport_ImportModuleLevelObject. If an import failed and re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9839/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9839%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9839%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9839/files
Reloadhttps://github.com/RustPython/RustPython/pull/9839/files
Reloadhttps://github.com/RustPython/RustPython/pull/9839/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/import-cache-failure-race-20261114https://github.com/youknowdot/RustPython/tree/fix/import-cache-failure-race-20261114
Conversation 7 https://github.com/RustPython/RustPython/pull/9839
Commits 1 https://github.com/RustPython/RustPython/pull/9839/commits
Checks 29 https://github.com/RustPython/RustPython/pull/9839/checks
Files changed https://github.com/RustPython/RustPython/pull/9839/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9839/files
Revalidate cached modules after import initialization https://github.com/RustPython/RustPython/pull/9839/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9839/files
f5ca35e Revalidate cached modules after import initialization youknowdot Nov 14, 2026 https://github.com/RustPython/RustPython/pull/9839/commits/f5ca35e328017c34500028656e433d212246b26d
Clear filters https://github.com/RustPython/RustPython/pull/9839/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9839/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9839/files
test_threaded_import.py https://github.com/RustPython/RustPython/pull/9839/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
import.rs https://github.com/RustPython/RustPython/pull/9839/files#diff-fdf183809931dc08d13609a0577f60effd521a60f8659606569d495720eb97d3
mod.rs https://github.com/RustPython/RustPython/pull/9839/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
import.py https://github.com/RustPython/RustPython/pull/9839/files#diff-85ef8168839714584019f1a98c9a3103ff03e6f2e1882d26401ba242bf693ab1
Lib/test/test_importlib/test_threaded_import.pyhttps://github.com/RustPython/RustPython/pull/9839/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
View file https://github.com/youknowdot/RustPython/blob/f5ca35e328017c34500028656e433d212246b26d/Lib/test/test_importlib/test_threaded_import.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9839/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9839/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
https://github.com/RustPython/RustPython/pull/9839/files#diff-a1e554f578aaaf3a7232078affdd527a19c86b178d8e3df84de287d335804ab1
crates/vm/src/import.rshttps://github.com/RustPython/RustPython/pull/9839/files#diff-fdf183809931dc08d13609a0577f60effd521a60f8659606569d495720eb97d3
View file https://github.com/youknowdot/RustPython/blob/f5ca35e328017c34500028656e433d212246b26d/crates/vm/src/import.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9839/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9839/files#diff-fdf183809931dc08d13609a0577f60effd521a60f8659606569d495720eb97d3
https://github.com/RustPython/RustPython/pull/9839/files#diff-fdf183809931dc08d13609a0577f60effd521a60f8659606569d495720eb97d3
https://github.com/RustPython/RustPython/pull/9839/files#diff-fdf183809931dc08d13609a0577f60effd521a60f8659606569d495720eb97d3
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 15, 2026https://github.com/RustPython/RustPython/pull/9839/files#r4577504901
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/0854bfc38139c0d2b58a9d5d71f5ad92840cf0c17144621e462b474041793354/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50322d79656c6c6f773f7374796c653d666c6174
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9839/files
https://github.com/RustPython/RustPython/pull/9839/files#diff-fdf183809931dc08d13609a0577f60effd521a60f8659606569d495720eb97d3
crates/vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/9839/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
View file https://github.com/youknowdot/RustPython/blob/f5ca35e328017c34500028656e433d212246b26d/crates/vm/src/vm/mod.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9839/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9839/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
https://github.com/RustPython/RustPython/pull/9839/files#diff-fe30ecf7c6b462e46e0874a55a05ea0edba83cefad5ac7a86e7137fa8f86ba74
extra_tests/snippets/import.pyhttps://github.com/RustPython/RustPython/pull/9839/files#diff-85ef8168839714584019f1a98c9a3103ff03e6f2e1882d26401ba242bf693ab1
View file https://github.com/youknowdot/RustPython/blob/f5ca35e328017c34500028656e433d212246b26d/extra_tests/snippets/import.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9839/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9839/files#diff-85ef8168839714584019f1a98c9a3103ff03e6f2e1882d26401ba242bf693ab1
youknowonehttps://github.com/youknowone
Nov 14, 2026https://github.com/RustPython/RustPython/pull/9839/files#r4574820952
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9839/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9839/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.