Title: Fix decimal digit boundaries without copying oversized integers by youknowdot · Pull Request #9834 · RustPython/RustPython · GitHub
Open Graph Title: Fix decimal digit boundaries without copying oversized integers by youknowdot · Pull Request #9834 · RustPython/RustPython
X Title: Fix decimal digit boundaries without copying oversized integers by youknowdot · Pull Request #9834 · RustPython/RustPython
Description: Summary Preserve all three original commits from Jacob-Met's #9823 unchanged, including the original tests and authorship, then integrate current main and apply our corrective implementation in one follow-up merge commit. The original commits remain in history; their copying/fallback implementation is replaced in the final code. Head b4476738 has exactly the same final tree as the previously tested 8d5edf138; this update changes history only. The diff against main remains limited to int.rs and 22 regression-test lines in builtin_int.py. Like CPython 3.15's long_to_decimal_string_internal, reject definitely oversized integers using bit length before allocating or converting. Use conservative lower/upper decimal bounds: definitely small values also return immediately. Only the uncertain boundary band compares the borrowed magnitude with 10^limit, without copying the input through abs(). Wide bound products and a usize power exponent avoid 32-bit overflow and truncation. The exact boundary is inclusive: 10^limit - 1 is allowed and ±10^limit is rejected. Disabled limits and nondecimal formatting retain their existing paths. CPython uses its own limb precheck and post-conversion size check; this preserves RustPython's shared pre-format validator rather than claiming an identical implementation. Validation Extracted builtin_int.py regression tests pass on CPython 3.15.2. The exact new predicate, extracted from the Rust source and compiled against the same malachite dependency, passes 6,504 signed/boundary/bit-length comparisons against exact powers of ten. Standalone allocation instrumentation: rejecting 1 << 1_000_000 at limit 4,300 allocates 0 bytes in the predicate (excluding Python exception construction). Near the boundary it allocates 6,536 bytes for the threshold; no input-sized copy. This is not a full interpreter benchmark. Formatting and all applicable commit hooks pass. The full interpreter rebuild was stopped before completion when shared workspace free space dropped to 18 MB. Repository-wide tests, C-API tests, interpreter-level RustPython regression tests and Clippy have not run on this head. Hosted CI subsequently passed on the exact updated head (see below); local full-suite/C-API validation remains incomplete, with no broader compatibility claim. The independent compiled predicate checks above are not a substitute for those checks. AI assistance: OpenAI Codex implemented and tested this change (model identifier unavailable). The three original #9823 commits are preserved byte-for-byte with author Cursor Agent cursoragent@cursor.com and their original Assisted-by trailers. Credit to Jacob-Met for the source PR and regression cases. Our follow-up commit is authored by youknowdot and carries its own assistance disclosure. CI result: exact head b4476738 passed all executed checks in run 43589169077, including Linux/macOS/Windows/WASI snippet/CPython jobs, three OS Rust test jobs, Ubuntu Clippy, Miri, WASM package/demo, lint, doc and shear. CodSpeed also passed. Conditional cargo-check/Clippy jobs and pyperformance were skipped, not claimed as executed. This does not claim local C-API validation.
Open Graph Description: Summary Preserve all three original commits from Jacob-Met's #9823 unchanged, including the original tests and authorship, then integrate current main and apply our corrective implementation in...
X Description: Summary Preserve all three original commits from Jacob-Met's #9823 unchanged, including the original tests and authorship, then integrate current main and apply our corrective implementatio...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9834
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6903368a-0f5a-8bbe-ed25-0ceb297a6080 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A1C:27D3AD:34F7349:43441CA:6B01DE72 |
| html-safe-nonce | 99c9f60101744f31e55b5c8730c30a2ae2ef0e5456a87059e46c9afbb1485118 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTFDOjI3RDNBRDozNEY3MzQ5OjQzNDQxQ0E6NkIwMURFNzIiLCJ2aXNpdG9yX2lkIjoiNzA5NjkzMTQ2MjY1NzcyODExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 046a4ac58a0317959b65b7002ebc93a07f0e8759929547258a5a250a4607dd28 |
| hovercard-subject-tag | pull_request:5310153537 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9834/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Preserve all three original commits from Jacob-Met's #9823 unchanged, including the original tests and authorship, then integrate current main and apply our corrective implementation in... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width