René's URL Explorer Experiment


Title: Use aligned control buffers and CMSG macros for ancillary data by youknowone · Pull Request #9818 · RustPython/RustPython · GitHub

Open Graph Title: Use aligned control buffers and CMSG macros for ancillary data by youknowone · Pull Request #9818 · RustPython/RustPython

X Title: Use aligned control buffers and CMSG macros for ancillary data by youknowone · Pull Request #9818 · RustPython/RustPython

Description: Summary pack_ancillary_messages built the sendmsg control buffer in a Vec and wrote cmsghdr fields through CMSG_FIRSTHDR/CMSG_NXTHDR pointers into it. A Vec has byte alignment, so those writes were misaligned. The recvmsg control storage was aligned only to cmsghdr, which is less than the CMSG alignment on some targets (e.g. FreeBSD/OpenBSD _ALIGNBYTES, musl CMSG_ALIGN). To work around unaligned buffers, the receive side used a hand-written parser that emulated per-platform CMSG_NXTHDR behavior. AF_ALG computed header offsets by hand. This PR gives all three paths aligned storage and uses the libc CMSG_* macros on it, following sock_sendmsg, sock_recvmsg_guts and sock_sendmsg_afalg in Modules/socketmodule.c. Control buffer ControlBuffer: owned, zero-initialized msg_control storage aligned to 16 bytes, the alignment PyMem_Malloc provides. sendmsg, recvmsg/recvmsg_into and sendmsg_afalg all use it. sendmsg The total control length is limited to SOCKLEN_T_LIMIT ("too much ancillary data"). Each header comes from CMSG_FIRSTHDR/CMSG_NXTHDR, is checked with cmsg_min_space and get_cmsg_data_space, and the payload is written to CMSG_DATA. RuntimeErrors match: unexpected NULL result from CMSG_FIRSTHDR() / CMSG_NXTHDR(), item size out of range, ancillary data does not fit in calculated space. Errors in the argument iterables and in ancillary data items have the same types and messages as sock_sendmsg/sock_sendmsg_iovec. recvmsg / recvmsg_into Received control messages are walked with CMSG_FIRSTHDR/CMSG_NXTHDR on the msghdr returned by recvmsg, using get_cmsg_data_len. This replaces the emulating parser and its platform-specific branches. A truncated or malformed control message emits RuntimeWarning("received malformed or improperly-truncated ancillary data"). If that warning or any later step raises, received SCM_RIGHTS descriptors are closed. ancbufsize outside 0..=SOCKLEN_T_LIMIT raises ValueError("invalid ancillary data buffer length"). A negative bufsize raises ValueError("negative buffer size in recvmsg()"). sendmsg_afalg (Linux) The control buffer is built with CMSG_FIRSTHDR/CMSG_NXTHDR, with the same cmsg_len values and NULL-header RuntimeErrors as sock_sendmsg_afalg. Arguments are validated the same way: algset is only supported for AF_ALG, Invalid or missing argument 'op', assoclen must be positive. Tests Host unit tests: alignment and empty input packing and parsing round trip truncated and malformed headers a socketpair SCM_RIGHTS round trip through recvmsg (Linux) the AF_ALG header layout test_socket passes on macOS (run=751, skipped=264). It emits the same 12 truncation RuntimeWarnings as CPython on the same machine. AF_ALG code was type-checked with cargo check --target x86_64-unknown-linux-gnu, but not run. Supersedes #9642. 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Improved reporting of complete, truncated, or malformed Unix socket ancillary data. Added clearer errors for invalid or oversized ancillary data and AF_ALG control messages. Improved validation of AF_ALG socket arguments and ancillary data sizes. Receive operations now close received file descriptors if converting the received data fails. New Features AF_ALG control messages can now be built and returned as buffers.

Open Graph Description: Summary pack_ancillary_messages built the sendmsg control buffer in a Vec<u8> and wrote cmsghdr fields through CMSG_FIRSTHDR/CMSG_NXTHDR pointers into it. A Vec<u8> has byte alignment, ...

X Description: Summary pack_ancillary_messages built the sendmsg control buffer in a Vec&lt;u8&gt; and wrote cmsghdr fields through CMSG_FIRSTHDR/CMSG_NXTHDR pointers into it. A Vec&lt;u8&gt; has ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9818

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c8db4eed-02c4-3c10-5451-47c7f06e79b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB670:136CDA:1579DE3:1C6E651:6B01FE55
html-safe-nonce9549abdbc6ef1152134314f5beab6d54419d704ee98fd3579cc5a23fb3b13426
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjcwOjEzNkNEQToxNTc5REUzOjFDNkU2NTE6NkIwMUZFNTUiLCJ2aXNpdG9yX2lkIjoiNzkxOTE5NTY2NjE5MDE2Nzg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5e1573f08bdbde609c0bb0c6245c24c3f2fd49229f0b85987b06564446e367f2
hovercard-subject-tagpull_request:5274642274
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9818/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altSummary pack_ancillary_messages built the sendmsg control buffer in a Vec<u8> and wrote cmsghdr fields through CMSG_FIRSTHDR/CMSG_NXTHDR pointers into it. A Vec<u8> has byte alignment, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9818/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9818%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9818%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9818/files
Reloadhttps://github.com/RustPython/RustPython/pull/9818/files
Reloadhttps://github.com/RustPython/RustPython/pull/9818/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:fix/ancillary-pack-safety-20261103https://github.com/youknowone/RustPython/tree/fix/ancillary-pack-safety-20261103
Conversation 6 https://github.com/RustPython/RustPython/pull/9818
Commits 2 https://github.com/RustPython/RustPython/pull/9818/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9818/checks
Files changed https://github.com/RustPython/RustPython/pull/9818/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9818/files
Use aligned control buffers and CMSG macros for ancillary data https://github.com/RustPython/RustPython/pull/9818/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9818/files
8e8f788 Use aligned control buffers and CMSG macros for ancillary data youknowone Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9818/commits/8e8f7883cf51c5a017aa52462b6990282dc33c10
5cf60a5 Import sendmsg item types only where they are used youknowone Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9818/commits/5cf60a53c34f9c85e8d8dc359dd587eac07a59ef
Clear filters https://github.com/RustPython/RustPython/pull/9818/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9818/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9818/files
socket.rs https://github.com/RustPython/RustPython/pull/9818/files#diff-e700a2482e618f0d67e0b1f7bbc4e5eef1bc7da702aaef7fa30d487372d19b72
socket.rs https://github.com/RustPython/RustPython/pull/9818/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
exceptions.rs https://github.com/RustPython/RustPython/pull/9818/files#diff-f527bc3e68302079a32d6da36816531e3e22dd31ff91ef0ff0f2688673712747
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9818/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9818/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.