René's URL Explorer Experiment


Title: socket: filesystem-encode names passed to if_nametoindex by youknowone · Pull Request #9817 · RustPython/RustPython · GitHub

Open Graph Title: socket: filesystem-encode names passed to if_nametoindex by youknowone · Pull Request #9817 · RustPython/RustPython

X Title: socket: filesystem-encode names passed to if_nametoindex by youknowone · Pull Request #9817 · RustPython/RustPython

Description: Follow-up to #9706, which made if_nameindex and if_indextoname decode interface names with vm.fsdecode. if_nametoindex encoded its argument as UTF-8, so a non-UTF-8 name returned by those functions could not be passed back. FsPath::to_cstring now encodes str arguments with the filesystem encoding and surrogateescape on Unix (PyUnicode_FSConverter). Its only caller is socket.if_nametoindex. A lone surrogate that surrogateescape cannot produce ("\ud800") raises UnicodeEncodeError. "\udcff\udcfe" encodes to raw bytes and fails the lookup with OSError. The snippet test in extra_tests/snippets/stdlib_socket.py passes on both CPython and RustPython. 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Filesystem paths on Unix and WASI now use their operating-system encoding when converted for system interfaces, improving compatibility with paths that the standard byte conversion cannot represent. Other platforms retain their existing behavior. Tests Added checks for socket interface-name conversions, including invalid Unicode input, unresolved names, and converting a valid interface index to a name and back.

Open Graph Description: Follow-up to #9706, which made if_nameindex and if_indextoname decode interface names with vm.fsdecode. if_nametoindex encoded its argument as UTF-8, so a non-UTF-8 name returned by those functions...

X Description: Follow-up to #9706, which made if_nameindex and if_indextoname decode interface names with vm.fsdecode. if_nametoindex encoded its argument as UTF-8, so a non-UTF-8 name returned by those functions...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9817

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4d488e8d-0836-6bcd-09c2-76824ab67a06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD41A:291B58:31106E0:3E40C73:6B02037A
html-safe-nonce3bcd854121a6e265e2ab60d7e16f0d464d7b25ec6059c7be77fa2d0cef8579c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDFBOjI5MUI1ODozMTEwNkUwOjNFNDBDNzM6NkIwMjAzN0EiLCJ2aXNpdG9yX2lkIjoiODgyNDM5NzczMDM2MjI5NTE2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac41aa9c5504cc3265a1cf4bfe098053a79553679edeee6a5c6bfa4e31472899cc
hovercard-subject-tagpull_request:5272011924
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9817/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altFollow-up to #9706, which made if_nameindex and if_indextoname decode interface names with vm.fsdecode. if_nametoindex encoded its argument as UTF-8, so a non-UTF-8 name returned by those functions...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9817/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9817%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9817%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9817/files
Reloadhttps://github.com/RustPython/RustPython/pull/9817/files
Reloadhttps://github.com/RustPython/RustPython/pull/9817/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:socket-ifname-fsencodehttps://github.com/youknowone/RustPython/tree/socket-ifname-fsencode
Conversation 5 https://github.com/RustPython/RustPython/pull/9817
Commits 1 https://github.com/RustPython/RustPython/pull/9817/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9817/checks
Files changed https://github.com/RustPython/RustPython/pull/9817/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9817/files
socket: filesystem-encode names passed to if_nametoindex https://github.com/RustPython/RustPython/pull/9817/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9817/files
ff8c934 socket: filesystem-encode names passed to if_nametoindex youknowone Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9817/commits/ff8c934154efc4f81062bf20711de4e78c956f6b
Clear filters https://github.com/RustPython/RustPython/pull/9817/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9817/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9817/files
fspath.rs https://github.com/RustPython/RustPython/pull/9817/files#diff-7a5f13c4e8426887b40f9e2923e1c265fa14ffa8fa7277132cab9a35a9ecd2aa
stdlib_socket.py https://github.com/RustPython/RustPython/pull/9817/files#diff-c967f666e05a3549586eaea718eb7abb551b5f783f12900950bc0b26440d4dbe
crates/vm/src/function/fspath.rshttps://github.com/RustPython/RustPython/pull/9817/files#diff-7a5f13c4e8426887b40f9e2923e1c265fa14ffa8fa7277132cab9a35a9ecd2aa
View file https://github.com/youknowone/RustPython/blob/ff8c934154efc4f81062bf20711de4e78c956f6b/crates/vm/src/function/fspath.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9817/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9817/files#diff-7a5f13c4e8426887b40f9e2923e1c265fa14ffa8fa7277132cab9a35a9ecd2aa
https://github.com/RustPython/RustPython/pull/9817/files#diff-7a5f13c4e8426887b40f9e2923e1c265fa14ffa8fa7277132cab9a35a9ecd2aa
extra_tests/snippets/stdlib_socket.pyhttps://github.com/RustPython/RustPython/pull/9817/files#diff-c967f666e05a3549586eaea718eb7abb551b5f783f12900950bc0b26440d4dbe
View file https://github.com/youknowone/RustPython/blob/ff8c934154efc4f81062bf20711de4e78c956f6b/extra_tests/snippets/stdlib_socket.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9817/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9817/files#diff-c967f666e05a3549586eaea718eb7abb551b5f783f12900950bc0b26440d4dbe
coderabbitaihttps://github.com/apps/coderabbitai
Nov 12, 2026https://github.com/RustPython/RustPython/pull/9817/files#r4546657939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
raw.githubusercontent.comhttps://raw.githubusercontent.com/RustPython/RustPython/ff8c934154efc4f81062bf20711de4e78c956f6b/Lib/test/test_socket.py
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9817/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9817/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.