René's URL Explorer Experiment


Title: Make wrapped thread mutex acquisition unwind-safe by youknowdot · Pull Request #9813 · RustPython/RustPython · GitHub

Open Graph Title: Make wrapped thread mutex acquisition unwind-safe by youknowdot · Pull Request #9813 · RustPython/RustPython

X Title: Make wrapped thread mutex acquisition unwind-safe by youknowdot · Pull Request #9813 · RustPython/RustPython

Description: Summary ThreadMutex::lock_wrapped and ThreadMutex::try_lock_for_wrapped let a caller wrap the blocking acquisition, e.g. mutex.lock_wrapped(|do_lock| vm.allow_threads(do_lock)). On main the wrapper reported success through () / bool, so safe code could obtain a guard without the raw mutex being locked, and a panic after acquisition left the mutex locked. The callback handed to the wrapper now returns the acquired guard (Option / Result), and the wrapped API returns whatever the wrapper returns. A guard exists only after a real acquisition, so it cannot be fabricated, and unwinding drops it. The wrapper callback types change. In-tree callers (vm.allow_threads(do_lock) in _io) compile unchanged because allow_threads returns the closure's value. RawThreadMutex::lock_wrapped is removed; it had no users and could not express this without trusting the wrapper. Calling the callback again while holding its guard returns None / Err(Current) instead of blocking. The one-second shutdown grace period in _io is unchanged. Validation cargo test -p rustpython-common --features threading lock::thread_mutex cargo clippy -p rustpython-common -p rustpython-vm --all-targets --features rustpython-vm/threading -- -D warnings -m test test_io AI assistance: OpenAI Codex wrote the initial patch; Claude reworked it into the guard-returning API.

Open Graph Description: Summary ThreadMutex::lock_wrapped and ThreadMutex::try_lock_for_wrapped let a caller wrap the blocking acquisition, e.g. mutex.lock_wrapped(|do_lock| vm.allow_threads(do_lock)). On main the wrapper...

X Description: Summary ThreadMutex::lock_wrapped and ThreadMutex::try_lock_for_wrapped let a caller wrap the blocking acquisition, e.g. mutex.lock_wrapped(|do_lock| vm.allow_threads(do_lock)). On main the wrapper...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9813

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:90368ea7-1691-35fb-100b-e5e40fb3d076
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC90:14700E:3B13508:4B02A46:6B01FE65
html-safe-nonce9491c0a4adac84b3fa38b628be69ca4e2848e676620561e52b62854ff693e202
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzkwOjE0NzAwRTozQjEzNTA4OjRCMDJBNDY6NkIwMUZFNjUiLCJ2aXNpdG9yX2lkIjoiNzI4MTMzMjY3ODQ0MzY1OTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac194f1964f6cfe58e5c0ccc0a05d663ce74aea54adef41a0b368ea44efc8e2521
hovercard-subject-tagpull_request:5270256020
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9813/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary ThreadMutex::lock_wrapped and ThreadMutex::try_lock_for_wrapped let a caller wrap the blocking acquisition, e.g. mutex.lock_wrapped(|do_lock| vm.allow_threads(do_lock)). On main the wrapper...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9813/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9813%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9813%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9813/files
Reloadhttps://github.com/RustPython/RustPython/pull/9813/files
Reloadhttps://github.com/RustPython/RustPython/pull/9813/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/thread-mutex-wrapper-safetyhttps://github.com/youknowdot/RustPython/tree/fix/thread-mutex-wrapper-safety
Conversation 11 https://github.com/RustPython/RustPython/pull/9813
Commits 6 https://github.com/RustPython/RustPython/pull/9813/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9813/checks
Files changed https://github.com/RustPython/RustPython/pull/9813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9813/files
Make wrapped thread mutex acquisition unwind-safe https://github.com/RustPython/RustPython/pull/9813/files#top
Show all changes 6 commits https://github.com/RustPython/RustPython/pull/9813/files
7cc324e Make wrapped thread mutex acquisition unwind-safe youknowdot Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9813/commits/7cc324e53b709081db595ed1b4e861ee052155ca
c7ef4f7 Follow test-module and core-import lint conventions youknowdot Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9813/commits/c7ef4f7f275e2154441543cef60feb3fb31739b0
eedb181 Detach I/O threads only for contended locks youknowdot Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9813/commits/eedb181d3056922b084a5ff300ef7a582b8733ff
d46f621 Preserve stop-the-world checkpoints on I/O lock fast paths youknowdot Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9813/commits/d46f621cf14acd65ad998911d00b652e668eb64e
0c04579 Cover reentrant I/O acquisition with a pending stop youknowdot Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9813/commits/0c045795039f5840b38e9ad84aa223b3ea962911
000a31e Return real guards from wrapped thread mutex callbacks youknowone Nov 12, 2026 https://github.com/RustPython/RustPython/pull/9813/commits/000a31e4d15373db9be8830f8a4cda046dc7eec9
Clear filters https://github.com/RustPython/RustPython/pull/9813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9813/files
crates/common/src/lock/thread_mutex.rshttps://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
View file https://github.com/youknowdot/RustPython/blob/000a31e4d15373db9be8830f8a4cda046dc7eec9/crates/common/src/lock/thread_mutex.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9813/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9813/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9813/files
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
https://github.com/RustPython/RustPython/pull/9813/files#diff-037464c3c77d981a319a904278e36a8c9ee055ee4496400260052e725be0579b
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9813/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.