René's URL Explorer Experiment


Title: Normalize source newlines before warnings, compilation and diagnostics by youknowdot · Pull Request #9793 · RustPython/RustPython · GitHub

Open Graph Title: Normalize source newlines before warnings, compilation and diagnostics by youknowdot · Pull Request #9793 · RustPython/RustPython

X Title: Normalize source newlines before warnings, compilation and diagnostics by youknowdot · Pull Request #9793 · RustPython/RustPython

Description: Summary Normalize CRLF and lone CR before parser warnings and compilation, including physical newlines inside string literals. This follows CPython 3.15's _PyTokenizer_translate_newlines / _PyTokenizer_FromUTF8 ordering. This is an independent alternative to close #9762, not stacked on it. The original change fixes literal values but runs after VM parser warnings and leaves diagnostics reading the untranslated input. Share one universal-newline translator between source decoding, compiler entry points, symbol-table compilation, and syntax diagnostics. Translate before VM parser warning collection. Keep diagnostic line lookup consistent with the translated parser source. Borrow CR-free input; otherwise use a single output allocation instead of chained full-string replacements. Preserve the caller's original source bytes in compile audit events. Cover CR/CRLF combinations, ordinary/raw/bytes/f-/t-string literals, docstrings, explicit escape preservation, AST compilation, warnings, error text consistency and audit input. Verification CPython 3.15.1 and RustPython builtin_compile.py / builtin_compile_module.py: pytest 4 passed. RustPython test_compile: passed (187 tests run, 51 skipped). CLI -c physical-CR literal checks: passed. Full workspace Rust tests, separate CAPI tests, workspace/CAPI clippy with -D warnings: passed. Shared normalizer tests and pre-commit hooks: passed. This does not claim full parser diagnostic parity: existing LF-input differences in trailing newlines in SyntaxError.text and warning-as-error precedence for invalid source also remain for CR input. This patch makes the newline forms consistent; it does not hide those independent differences. AI assistance: OpenAI Codex.

Open Graph Description: Summary Normalize CRLF and lone CR before parser warnings and compilation, including physical newlines inside string literals. This follows CPython 3.15's _PyTokenizer_translate_newlines / _PyT...

X Description: Summary Normalize CRLF and lone CR before parser warnings and compilation, including physical newlines inside string literals. This follows CPython 3.15's _PyTokenizer_translate_newlines / ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9793

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e77286c9-2945-017c-87b0-500e3dfa6724
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECF2:6B7DC:6EFAE:8DE7B:6B01EB28
html-safe-noncee453eb5ab89959fd0eacab66cea6bf9e5b39605761e72030dc7d3950955f9e90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0YyOjZCN0RDOjZFRkFFOjhERTdCOjZCMDFFQjI4IiwidmlzaXRvcl9pZCI6IjI1MTY2NTIzMTUyNzI5MzIxMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdc5a01d2de6d544248ebcee880bba344056a5e3d297de2c6cfe54c9cf0cad754
hovercard-subject-tagpull_request:5245417076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9793/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Normalize CRLF and lone CR before parser warnings and compilation, including physical newlines inside string literals. This follows CPython 3.15's _PyTokenizer_translate_newlines / _PyT...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9793/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9793%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9793%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9793/files
Reloadhttps://github.com/RustPython/RustPython/pull/9793/files
Reloadhttps://github.com/RustPython/RustPython/pull/9793/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/pr9762-source-newlineshttps://github.com/youknowdot/RustPython/tree/fix/pr9762-source-newlines
Conversation 3 https://github.com/RustPython/RustPython/pull/9793
Commits 2 https://github.com/RustPython/RustPython/pull/9793/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9793/checks
Files changed https://github.com/RustPython/RustPython/pull/9793/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9793/files
Normalize source newlines before warnings, compilation and diagnostics https://github.com/RustPython/RustPython/pull/9793/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9793/files
b9def6a Normalize physical source newlines before parser warnings and compila… youknowdot Nov 10, 2026 https://github.com/RustPython/RustPython/pull/9793/commits/b9def6ada9b9b1824434dee1a918c6a089afdd9c
b658c0a Mark normalized source result as must-use youknowdot Nov 10, 2026 https://github.com/RustPython/RustPython/pull/9793/commits/b658c0afdaf65935dbbf5e5f79715bddac388178
Clear filters https://github.com/RustPython/RustPython/pull/9793/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9793/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9793/files
lib.rs https://github.com/RustPython/RustPython/pull/9793/files#diff-8bec0fe1d7188e98526698781fb5c7de4719f9c667c0354d29ccec88142b252c
source.rs https://github.com/RustPython/RustPython/pull/9793/files#diff-5278143b07a326cdae979762668ab74796f895ffb4130347be0d74ade5e1113e
lib.rs https://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
compile.rs https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
vm_new.rs https://github.com/RustPython/RustPython/pull/9793/files#diff-0ed409205fe13b41775e66f6be22c13146e9aebf1000a069a10b39293f219a7b
builtin_compile.py https://github.com/RustPython/RustPython/pull/9793/files#diff-732a02ab19c62e7a2988744ef416a3e23a87a9ee8ad7c66f20a9f1dcddc8e186
crates/compiler-core/src/lib.rshttps://github.com/RustPython/RustPython/pull/9793/files#diff-8bec0fe1d7188e98526698781fb5c7de4719f9c667c0354d29ccec88142b252c
View file https://github.com/youknowdot/RustPython/blob/b658c0afdaf65935dbbf5e5f79715bddac388178/crates/compiler-core/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9793/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9793/files#diff-8bec0fe1d7188e98526698781fb5c7de4719f9c667c0354d29ccec88142b252c
https://github.com/RustPython/RustPython/pull/9793/files#diff-8bec0fe1d7188e98526698781fb5c7de4719f9c667c0354d29ccec88142b252c
crates/compiler-core/src/source.rshttps://github.com/RustPython/RustPython/pull/9793/files#diff-5278143b07a326cdae979762668ab74796f895ffb4130347be0d74ade5e1113e
View file https://github.com/youknowdot/RustPython/blob/b658c0afdaf65935dbbf5e5f79715bddac388178/crates/compiler-core/src/source.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9793/{{ revealButtonHref }}
crates/compiler/src/lib.rshttps://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
View file https://github.com/youknowdot/RustPython/blob/b658c0afdaf65935dbbf5e5f79715bddac388178/crates/compiler/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9793/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
https://github.com/RustPython/RustPython/pull/9793/files#diff-560e1ff98a1fe1161356b6c726aeb89f8c5e9764ccd2f4fb4dfa7143508d09e7
crates/vm/src/vm/compile.rshttps://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
View file https://github.com/youknowdot/RustPython/blob/b658c0afdaf65935dbbf5e5f79715bddac388178/crates/vm/src/vm/compile.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9793/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
https://github.com/RustPython/RustPython/pull/9793/files#diff-e7f70f57a7775d5472ffe0e4fe2f28f1c386fad78bef2ba2c46fd7f2224fa89e
crates/vm/src/vm/vm_new.rshttps://github.com/RustPython/RustPython/pull/9793/files#diff-0ed409205fe13b41775e66f6be22c13146e9aebf1000a069a10b39293f219a7b
View file https://github.com/youknowdot/RustPython/blob/b658c0afdaf65935dbbf5e5f79715bddac388178/crates/vm/src/vm/vm_new.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9793/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9793/files#diff-0ed409205fe13b41775e66f6be22c13146e9aebf1000a069a10b39293f219a7b
https://github.com/RustPython/RustPython/pull/9793/files#diff-0ed409205fe13b41775e66f6be22c13146e9aebf1000a069a10b39293f219a7b
extra_tests/snippets/builtin_compile.pyhttps://github.com/RustPython/RustPython/pull/9793/files#diff-732a02ab19c62e7a2988744ef416a3e23a87a9ee8ad7c66f20a9f1dcddc8e186
View file https://github.com/youknowdot/RustPython/blob/b658c0afdaf65935dbbf5e5f79715bddac388178/extra_tests/snippets/builtin_compile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9793/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9793/files#diff-732a02ab19c62e7a2988744ef416a3e23a87a9ee8ad7c66f20a9f1dcddc8e186
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9793/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.