René's URL Explorer Experiment


Title: Count matched keywords in one binding walk by youknowone · Pull Request #9790 · RustPython/RustPython · GitHub

Open Graph Title: Count matched keywords in one binding walk by youknowone · Pull Request #9790 · RustPython/RustPython

X Title: Count matched keywords in one binding walk by youknowone · Pull Request #9790 · RustPython/RustPython

Description: Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only for parameters not filled by position and counts the matches. The duplicate and unexpected-keyword scans run only when fewer keywords matched than were passed, instead of a contains_key per positionally filled parameter plus a recursive parameter scan per keyword on every keyword call. BindingShape carries its &'static [Param], removing BINDING_PARAMS.unwrap() and the Flatten(None) unreachable!(). Removes FromArgs::missing_from, missing_from_params, FromArgs::HAS_REQUIRED_KEYWORD_ONLY and params_have_required_keyword_only (no caller outside tests since #9563), with their forwards in tuple impls, UnpackKeywords and the derive. Adds a snippet case: a duplicate is reported before an unexpected keyword and before converting the first argument. Tested: workspace and capi tests, clippy, vm_argument_errors.py on RustPython and CPython 3.15, and -m test for test_builtin, test_functools, test_inspect, test_itertools, test_math, test_thread, test_threading, test_json, test_mmap, test_datetime, test_keywordonlyarg, test_call, test_extcall, test_list, test_dict, test_str, test_sort. 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Improved function-call argument validation. Duplicate positional and keyword values now report the duplicated argument and its positional index, even when an unexpected keyword is also supplied. Improved diagnostics for missing required arguments when calls include positional or keyword arguments.

Open Graph Description: Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only...

X Description: Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9790

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9123c52e-29b3-ac04-875f-fdaed4945e48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F0E:3A4875:30AD936:40E1D32:6B01E6CC
html-safe-nonceb5d9be0cf904aad09130112b8d4dcf9cd86c8fd5303d3d98a91eb89db7963016
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjBFOjNBNDg3NTozMEFEOTM2OjQwRTFEMzI6NkIwMUU2Q0MiLCJ2aXNpdG9yX2lkIjoiNjIzNzY0Mzc2ODEzMzE4MzE4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac28336f624092d1930b7e2b59f74487cef0064c35858a5c6b8aeeee3faa79a06b
hovercard-subject-tagpull_request:5242988241
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9790/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altFollow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9790/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9790%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9790%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9790/files
Reloadhttps://github.com/RustPython/RustPython/pull/9790/files
Reloadhttps://github.com/RustPython/RustPython/pull/9790/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:fix/bind-missing-argumenthttps://github.com/youknowone/RustPython/tree/fix/bind-missing-argument
Conversation 4 https://github.com/RustPython/RustPython/pull/9790
Commits 2 https://github.com/RustPython/RustPython/pull/9790/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9790/checks
Files changed https://github.com/RustPython/RustPython/pull/9790/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9790/files
Count matched keywords in one binding walk https://github.com/RustPython/RustPython/pull/9790/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9790/files
3271edf Count matched keywords in one binding walk youknowone Nov 10, 2026 https://github.com/RustPython/RustPython/pull/9790/commits/3271edf2098815d3e76353f23e360b5bad735469
0420df5 Keep only the unexpected-keyword scan on the cold path youknowone Nov 10, 2026 https://github.com/RustPython/RustPython/pull/9790/commits/0420df516776f473bc2e8aaca618e9d403e8728b
Clear filters https://github.com/RustPython/RustPython/pull/9790/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9790/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9790/files
from_args.rs https://github.com/RustPython/RustPython/pull/9790/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
argument.rs https://github.com/RustPython/RustPython/pull/9790/files#diff-e9ca87fa93dba19813dc8ace2b1f9cbfd3cb9f29560b80c1e38963101107cfff
mod.rs https://github.com/RustPython/RustPython/pull/9790/files#diff-c2fa22f10e57d8883fb9de7511a7345f799c1c3e87cda5ac557e3d513020d950
vm_argument_errors.py https://github.com/RustPython/RustPython/pull/9790/files#diff-3febfaa9a2cc7b3290172a8395d4c2e7ba34040c336993eb00683537156ac017
crates/derive-impl/src/from_args.rshttps://github.com/RustPython/RustPython/pull/9790/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
View file https://github.com/youknowone/RustPython/blob/0420df516776f473bc2e8aaca618e9d403e8728b/crates/derive-impl/src/from_args.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9790/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9790/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
https://github.com/RustPython/RustPython/pull/9790/files#diff-90c094cca198d94b0145e4a485172fba68de5c77f49fcd05a6b882896721f1c9
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9790/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9790/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.