Title: Count matched keywords in one binding walk by youknowone · Pull Request #9790 · RustPython/RustPython · GitHub
Open Graph Title: Count matched keywords in one binding walk by youknowone · Pull Request #9790 · RustPython/RustPython
X Title: Count matched keywords in one binding walk by youknowone · Pull Request #9790 · RustPython/RustPython
Description: Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only for parameters not filled by position and counts the matches. The duplicate and unexpected-keyword scans run only when fewer keywords matched than were passed, instead of a contains_key per positionally filled parameter plus a recursive parameter scan per keyword on every keyword call. BindingShape carries its &'static [Param], removing BINDING_PARAMS.unwrap() and the Flatten(None) unreachable!(). Removes FromArgs::missing_from, missing_from_params, FromArgs::HAS_REQUIRED_KEYWORD_ONLY and params_have_required_keyword_only (no caller outside tests since #9563), with their forwards in tuple impls, UnpackKeywords and the derive. Adds a snippet case: a duplicate is reported before an unexpected keyword and before converting the first argument. Tested: workspace and capi tests, clippy, vm_argument_errors.py on RustPython and CPython 3.15, and -m test for test_builtin, test_functools, test_inspect, test_itertools, test_math, test_thread, test_threading, test_json, test_mmap, test_datetime, test_keywordonlyarg, test_call, test_extcall, test_list, test_dict, test_str, test_sort. 🤖 Generated with Claude Code Summary by CodeRabbit Bug Fixes Improved function-call argument validation. Duplicate positional and keyword values now report the duplicated argument and its positional index, even when an unexpected keyword is also supplied. Improved diagnostics for missing required arguments when calls include positional or keyword arguments.
Open Graph Description: Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only...
X Description: Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9790
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9123c52e-29b3-ac04-875f-fdaed4945e48 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F0E:3A4875:30AD936:40E1D32:6B01E6CC |
| html-safe-nonce | b5d9be0cf904aad09130112b8d4dcf9cd86c8fd5303d3d98a91eb89db7963016 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjBFOjNBNDg3NTozMEFEOTM2OjQwRTFEMzI6NkIwMUU2Q0MiLCJ2aXNpdG9yX2lkIjoiNjIzNzY0Mzc2ODEzMzE4MzE4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 28336f624092d1930b7e2b59f74487cef0064c35858a5c6b8aeeee3faa79a06b |
| hovercard-subject-tag | pull_request:5242988241 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9790/files |
| twitter:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| og:image:alt | Follow-up to #9513 and #9563. Error messages and their order are unchanged (missing required argument → given by name and position → unexpected keyword). BindingMatch::walk looks a keyword up only... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width