Title: Stabilize subprocess pipe descriptor fixtures by youknowdot · Pull Request #9735 · RustPython/RustPython · GitHub
Open Graph Title: Stabilize subprocess pipe descriptor fixtures by youknowdot · Pull Request #9735 · RustPython/RustPython
X Title: Stabilize subprocess pipe descriptor fixtures by youknowdot · Pull Request #9735 · RustPython/RustPython
Description: This PR follows our AI policy. Summary Fix the pipe fixture introduced in #9677 and exposed by this macOS test failure on #9563. The same fixture is present on main. pipe() returns read/write endpoints, not a numerically sorted descriptor pair. Darwin allocates them separately, so concurrent descriptor reuse can put the writer below the reader. Closed standard streams can also let a pipe acquire descriptor 0–2. The CI assertion combined both assumptions and did not record which one failed. Use a test-only helper to duplicate the reader at FD >= 3 and the writer above the reader. All existing assertions, candidate descriptors, flag transitions, and I/O checks remain unchanged. Production code is unchanged. Validation All 102 rustpython-host_env unit tests passed with all features enabled. All four subprocess raw-FD tests passed in 100 repeated parallel runs. The same tests passed with a process-local Linux harness forcing descending pipe descriptor numbers, including reader=65 and writer=64. Strict all-target, all-feature rustpython-host_env Clippy and commit hooks passed. No local macOS run or full workspace/C-API rerun for this test-fixture-only change. Platform validation remains with CI. AI assistance: OpenAI Codex assisted with diagnosis, implementation, review, and validation. Summary by CodeRabbit Tests Improved subprocess test setup to ensure pipe descriptors are allocated above standard error, reducing reliance on platform-specific descriptor ordering.
Open Graph Description: This PR follows our AI policy. Summary Fix the pipe fixture introduced in #9677 and exposed by this macOS test failure on #9563. The same fixture is present on main. pipe() returns read/write endp...
X Description: This PR follows our AI policy. Summary Fix the pipe fixture introduced in #9677 and exposed by this macOS test failure on #9563. The same fixture is present on main. pipe() returns read/write endp...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9735
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9d6e472f-815e-e329-c40b-2599eb32b14e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E19A:1087D4:315D23D:41F7FD6:6B01F382 |
| html-safe-nonce | d9a781e0b171d12bcce1fe03c85716f2caf884bdceea478ebd1547540cc7e244 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTlBOjEwODdENDozMTVEMjNEOjQxRjdGRDY6NkIwMUYzODIiLCJ2aXNpdG9yX2lkIjoiODA0Nzc2MTk3ODQ2MDA3NDg4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9617afb782f76f3f304e2892c722a338e79ab2e26015fbfe6f000dc3a8018294 |
| hovercard-subject-tag | pull_request:5196015213 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9735/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | This PR follows our AI policy. Summary Fix the pipe fixture introduced in #9677 and exposed by this macOS test failure on #9563. The same fixture is present on main. pipe() returns read/write endp... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width