Title: Track PickleBuffer reference cycles by youknowdot · Pull Request #9733 · RustPython/RustPython · GitHub
Open Graph Title: Track PickleBuffer reference cycles by youknowdot · Pull Request #9733 · RustPython/RustPython
X Title: Track PickleBuffer reference cycles by youknowdot · Pull Request #9733 · RustPython/RustPython
Description: Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launching another heavy hosted run while the parent is pending. Adding the skip:ci label was denied by repository permissions, so that label is not applied. The commit directive suppresses the ordinary CI workflows; the lightweight Lib Dependencies check can still run. Hosted platform CI for this head is intentionally deferred, not claimed green. Rebase after #9732 lands and remove the skip directive when the stack is ready for its platform checks. Summary Enable the existing traversal for PyPickleBuffer so its owned exporter reference is visible to cyclic GC. Reuse PyBuffer and PyRwLock traversal without cloning references or running exporter callbacks. Preserve acquisition and release ordering. Remove the sole remaining expected-failure marker in test_picklebuffer.py using scripts/update_lib quick Lib/test/test_picklebuffer.py --no-build --no-commit. Relative to #9732, exactly two files change: one Rust attribute and one removed decorator. No assertions, test logic, skips, duplicate snippets, or workflows change. Validation Fresh release interpreter with an explicit worktree RUSTPYTHONPATH; imported canonical test location verified. Complete test_picklebuffer: 9 tests, 3 unchanged _testbuffer availability skips, zero expected failures. Complete test_memoryview, test_gc, and test_pickle suites passed, retaining their existing skips/expected failures. test_buffer.TestPythonBufferProtocol passed: 19 tests, 4 existing skips. Targeted GC inspection matches CPython 3.15: tracked buffer, one exporter edge, cycle collected; release removes the edge. Full workspace Rust tests passed, excluding the separately configured C-API, WASM, and Windows venv launcher crates. Separate C-API tests passed: 149 passed, 2 existing ignored tests. Workspace and separate C-API all-target Clippy passed with -D warnings. Independent traversal/refcount/lock/callback review and normal commit hooks passed. No native non-Linux or hosted validation is claimed. Open #8939 still lacks this traversal flag and does not duplicate the correction. AI assistance: OpenAI Codex performed inspection, implementation, independent review, and validation. The exact model version was not exposed. Summary by CodeRabbit No user-facing changes — This update does not change user-visible behavior.
Open Graph Description: Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launchin...
X Description: Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launchin...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9733
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:73a11346-e9c6-8ca8-a3ae-c481008798ae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 979E:DB09F:3615239:45103D4:6B01F37E |
| html-safe-nonce | 4a4e69a3bf3a553ed020cd48481caab8162e1d4e3ddbf7e6b85baeab6efb880a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzlFOkRCMDlGOjM2MTUyMzk6NDUxMDNENDo2QjAxRjM3RSIsInZpc2l0b3JfaWQiOiI1MzE1MzE2NDY3NzgzMjk5OTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b1ab281ef0ff34b020feebb8afbed0a22024fe2a28b3df84b84145787251a959 |
| hovercard-subject-tag | pull_request:5191329612 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9733/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launchin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width