René's URL Explorer Experiment


Title: Track PickleBuffer reference cycles by youknowdot · Pull Request #9733 · RustPython/RustPython · GitHub

Open Graph Title: Track PickleBuffer reference cycles by youknowdot · Pull Request #9733 · RustPython/RustPython

X Title: Track PickleBuffer reference cycles by youknowdot · Pull Request #9733 · RustPython/RustPython

Description: Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launching another heavy hosted run while the parent is pending. Adding the skip:ci label was denied by repository permissions, so that label is not applied. The commit directive suppresses the ordinary CI workflows; the lightweight Lib Dependencies check can still run. Hosted platform CI for this head is intentionally deferred, not claimed green. Rebase after #9732 lands and remove the skip directive when the stack is ready for its platform checks. Summary Enable the existing traversal for PyPickleBuffer so its owned exporter reference is visible to cyclic GC. Reuse PyBuffer and PyRwLock traversal without cloning references or running exporter callbacks. Preserve acquisition and release ordering. Remove the sole remaining expected-failure marker in test_picklebuffer.py using scripts/update_lib quick Lib/test/test_picklebuffer.py --no-build --no-commit. Relative to #9732, exactly two files change: one Rust attribute and one removed decorator. No assertions, test logic, skips, duplicate snippets, or workflows change. Validation Fresh release interpreter with an explicit worktree RUSTPYTHONPATH; imported canonical test location verified. Complete test_picklebuffer: 9 tests, 3 unchanged _testbuffer availability skips, zero expected failures. Complete test_memoryview, test_gc, and test_pickle suites passed, retaining their existing skips/expected failures. test_buffer.TestPythonBufferProtocol passed: 19 tests, 4 existing skips. Targeted GC inspection matches CPython 3.15: tracked buffer, one exporter edge, cycle collected; release removes the edge. Full workspace Rust tests passed, excluding the separately configured C-API, WASM, and Windows venv launcher crates. Separate C-API tests passed: 149 passed, 2 existing ignored tests. Workspace and separate C-API all-target Clippy passed with -D warnings. Independent traversal/refcount/lock/callback review and normal commit hooks passed. No native non-Linux or hosted validation is claimed. Open #8939 still lacks this traversal flag and does not duplicate the correction. AI assistance: OpenAI Codex performed inspection, implementation, independent review, and validation. The exact model version was not exposed. Summary by CodeRabbit No user-facing changes — This update does not change user-visible behavior.

Open Graph Description: Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launchin...

X Description: Stack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launchin...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9733

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73a11346-e9c6-8ca8-a3ae-c481008798ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id979E:DB09F:3615239:45103D4:6B01F37E
html-safe-nonce4a4e69a3bf3a553ed020cd48481caab8162e1d4e3ddbf7e6b85baeab6efb880a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzlFOkRCMDlGOjM2MTUyMzk6NDUxMDNENDo2QjAxRjM3RSIsInZpc2l0b3JfaWQiOiI1MzE1MzE2NDY3NzgzMjk5OTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb1ab281ef0ff34b020feebb8afbed0a22024fe2a28b3df84b84145787251a959
hovercard-subject-tagpull_request:5191329612
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9733/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altStack and CI Stacked on #9732 (f6d22b4e0a). The two PickleBuffer commits are the new batch; the preceding LZMA changes belong to that parent PR. The final commit carries [skip ci] to avoid launchin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9733/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9733%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9733%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9733/files
Reloadhttps://github.com/RustPython/RustPython/pull/9733/files
Reloadhttps://github.com/RustPython/RustPython/pull/9733/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/picklebuffer-cycle-batch-20261107https://github.com/youknowdot/RustPython/tree/fix/picklebuffer-cycle-batch-20261107
Conversation 4 https://github.com/RustPython/RustPython/pull/9733
Commits 2 https://github.com/RustPython/RustPython/pull/9733/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9733/checks
Files changed https://github.com/RustPython/RustPython/pull/9733/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9733/files
Track PickleBuffer reference cycles https://github.com/RustPython/RustPython/pull/9733/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9733/files
5d6fc12 Track PickleBuffer exporter references during cyclic GC codex Nov 6, 2026 https://github.com/RustPython/RustPython/pull/9733/commits/5d6fc12196fd5f4835880b75e1698d98f9b25fe9
48baa9d Retire the remaining PickleBuffer expected failure codex Nov 6, 2026 https://github.com/RustPython/RustPython/pull/9733/commits/48baa9d623fce8711a41a6ee1518f22d1e45b1f0
Clear filters https://github.com/RustPython/RustPython/pull/9733/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9733/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9733/files
test_picklebuffer.py https://github.com/RustPython/RustPython/pull/9733/files#diff-ac95ad0c0b430ea3909dee66926c6879cb58aa81056006cab6046bdd391d9a48
pickle.rs https://github.com/RustPython/RustPython/pull/9733/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
Lib/test/test_picklebuffer.pyhttps://github.com/RustPython/RustPython/pull/9733/files#diff-ac95ad0c0b430ea3909dee66926c6879cb58aa81056006cab6046bdd391d9a48
View file https://github.com/youknowdot/RustPython/blob/48baa9d623fce8711a41a6ee1518f22d1e45b1f0/Lib/test/test_picklebuffer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9733/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9733/files#diff-ac95ad0c0b430ea3909dee66926c6879cb58aa81056006cab6046bdd391d9a48
https://github.com/RustPython/RustPython/pull/9733/files#diff-ac95ad0c0b430ea3909dee66926c6879cb58aa81056006cab6046bdd391d9a48
crates/stdlib/src/pickle.rshttps://github.com/RustPython/RustPython/pull/9733/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
View file https://github.com/youknowdot/RustPython/blob/48baa9d623fce8711a41a6ee1518f22d1e45b1f0/crates/stdlib/src/pickle.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9733/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9733/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
https://github.com/RustPython/RustPython/pull/9733/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9733/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.