René's URL Explorer Experiment


Title: Handle fallible filesystem decoding in Windows console IO by youknowdot · Pull Request #9728 · RustPython/RustPython · GitHub

Open Graph Title: Handle fallible filesystem decoding in Windows console IO by youknowdot · Pull Request #9728 · RustPython/RustPython

X Title: Handle fallible filesystem decoding in Windows console IO by youknowdot · Pull Request #9728 · RustPython/RustPython

Description: I did not use AI to write the code of this patch. This PR follows our AI policy. Summary Fix the two Windows E0308 errors in main's Clippy job. Both bytes-path branches still treated the now-fallible vm.fsdecode result as a string. Return \0 if decoding fails during best-effort console detection, consistent with the adjacent path-conversion failure handling. Propagate decoding errors from _WindowsConsoleIO initialization with ?. Only these two call sites change. No lint suppression, workflow changes, or test changes. Validation cargo fmt --check, normal commit hooks, and git diff --check passed. Independent source review passed. Four isolated Rust control-flow tests and strict Clippy on that small reproducer passed. These do not execute RustPython or Windows APIs. Windows cross-Clippy was attempted but stopped before compilation because the offline cache lacks clipboard-win v5.4.1; the installed toolchain also lacks the Windows target. Native Windows compilation, the workspace suite, and C-API tests remain unrun. Hosted CI must validate the actual Windows build. Based on main 0dd06b08e13f79ad19d32c8f5820953a05a6be81. AI assistance: OpenAI Codex diagnosed the CI failure, implemented and reviewed the fix, and performed the listed local checks. Model version is not exposed.

Open Graph Description: I did not use AI to write the code of this patch. This PR follows our AI policy. Summary Fix the two Windows E0308 errors in main's Clippy job. Both bytes-path branches still treated the now-...

X Description: I did not use AI to write the code of this patch. This PR follows our AI policy. Summary Fix the two Windows E0308 errors in main's Clippy job. Both bytes-path branches still treated the ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9728

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a9141683-c41b-b153-0283-6951b9208769
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6A8:2E5652:34CFF8C:43500E9:6B01E3F9
html-safe-nonce66019c05c7007a5864fd083f2be63066c83051aae207fb7021ee2a59be1f8f17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkE4OjJFNTY1MjozNENGRjhDOjQzNTAwRTk6NkIwMUUzRjkiLCJ2aXNpdG9yX2lkIjoiMzcwMzkxMjczNjI0NjMyNjI2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf21a9ca0b6968ba46cf4963fd7a7e86bd3116dbad1d89b9d946371b2b2b9d7f1
hovercard-subject-tagpull_request:5182594442
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9728/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altI did not use AI to write the code of this patch. This PR follows our AI policy. Summary Fix the two Windows E0308 errors in main's Clippy job. Both bytes-path branches still treated the now-...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9728/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9728%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9728%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9728/files
Reloadhttps://github.com/RustPython/RustPython/pull/9728/files
Reloadhttps://github.com/RustPython/RustPython/pull/9728/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/windows-console-fsdecode-20261106https://github.com/youknowdot/RustPython/tree/fix/windows-console-fsdecode-20261106
Conversation 3 https://github.com/RustPython/RustPython/pull/9728
Commits 1 https://github.com/RustPython/RustPython/pull/9728/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9728/checks
Files changed https://github.com/RustPython/RustPython/pull/9728/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9728/files
Handle fallible filesystem decoding in Windows console IO https://github.com/RustPython/RustPython/pull/9728/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9728/files
1a9d65d Handle fallible filesystem decoding in Windows console IO youknowdot Nov 6, 2026 https://github.com/RustPython/RustPython/pull/9728/commits/1a9d65d57f4878404590539524eab1ded108da56
Clear filters https://github.com/RustPython/RustPython/pull/9728/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9728/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9728/files
crates/vm/src/stdlib/_io.rshttps://github.com/RustPython/RustPython/pull/9728/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
View file https://github.com/youknowdot/RustPython/blob/1a9d65d57f4878404590539524eab1ded108da56/crates/vm/src/stdlib/_io.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9728/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9728/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/9728/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/9728/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
https://github.com/RustPython/RustPython/pull/9728/files#diff-90825edc73ec293e0ed3b2dbed7f0a492b1f8e51c25747326089a912267bdd3e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9728/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.