Title: Align Union construction and callback controls by youknowdot · Pull Request #9714 · RustPython/RustPython · GitHub
Open Graph Title: Align Union construction and callback controls by youknowdot · Pull Request #9714 · RustPython/RustPython
X Title: Align Union construction and callback controls by youknowdot · Pull Request #9714 · RustPython/RustPython
Description: Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; substitution validates directly without invoking user __or__ or __ror__. Preserve creation-time hashable/unhashable partitions for equality and hashing. Freeze stored set entries without repeating hash or collision callbacks, and preserve identity shortcuts and containment comparison direction. Preserve callback errors and ownership: only the initial hash failure classifies an argument as unhashable; subsequent hash failures use the shared contextual formatter while comparison exceptions remain unchanged. Keep original inputs alive and release failed-builder lists in reverse order. Validation Independent source/ownership review and 19 pinned CPython 3.15 oracle groups passed, covering callback order, exception identity, temporary lifetimes, partition equality and checked-entry-point differences. Final threaded cargo check passed for host_env, VM and stdlib. Threaded all-targets Clippy passed with exactly the same 12 existing diagnostics as the baseline and no new warning. Rustfmt, git diff --check, and normal commit hooks passed. Native RustPython execution is not available under the required safety guard; no native runtime or full test-suite pass is claimed. The separate non-threaded/WASM graph was not built under the current disk limit. Integration notes The shared dictionary hash-error formatter extraction is intentionally identical to the helper in #9693 rather than another implementation. Its set operation changes still require reconciling add/add_known_hash: preserve #9693's hash-only contextualization, keep raw collision errors unchanged, and delegate to one raw insertion helper. The formatter also overlaps #9700's Unicode-preserving key_hash change: retain the extracted WTF-8 helper and #9700's other qualified-name improvements. Source composition was inspected; the combined branches have not been compiled. Union/GenericAlias representation formatting and unrelated set-operation behavior remain outside this change. Repository tests, standard-library files and workflows are unchanged. Summary by CodeRabbit Bug Fixes Union creation and | operations now consistently flatten nested unions, remove duplicate members, and handle unhashable members. Empty unions now raise an error, while a union containing only one unique member returns that member directly. Hashing errors for dictionary keys now include context about the key and container while preserving non-TypeError exceptions. Converting a set to a frozen set no longer rehashes or compares its stored keys.
Open Graph Description: Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; ...
X Description: Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9714
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0737b4df-290e-4949-8c3c-882ca718d636 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA8A:FC5BE:34EA227:464CB6D:6B01FE41 |
| html-safe-nonce | 69ec302a04bb6a528fe2eedbd932eeb98adfc6af15e3dd7cab554d161021e10e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQThBOkZDNUJFOjM0RUEyMjc6NDY0Q0I2RDo2QjAxRkU0MSIsInZpc2l0b3JfaWQiOiIyODc3MDc0OTExMjEyNDY5ODI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2e28fa2fb29811efa2e98b3af9762563914c1abfd111e8b07fea275d339495ad |
| hovercard-subject-tag | pull_request:5158614222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9714/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width