René's URL Explorer Experiment


Title: Align Union construction and callback controls by youknowdot · Pull Request #9714 · RustPython/RustPython · GitHub

Open Graph Title: Align Union construction and callback controls by youknowdot · Pull Request #9714 · RustPython/RustPython

X Title: Align Union construction and callback controls by youknowdot · Pull Request #9714 · RustPython/RustPython

Description: Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; substitution validates directly without invoking user __or__ or __ror__. Preserve creation-time hashable/unhashable partitions for equality and hashing. Freeze stored set entries without repeating hash or collision callbacks, and preserve identity shortcuts and containment comparison direction. Preserve callback errors and ownership: only the initial hash failure classifies an argument as unhashable; subsequent hash failures use the shared contextual formatter while comparison exceptions remain unchanged. Keep original inputs alive and release failed-builder lists in reverse order. Validation Independent source/ownership review and 19 pinned CPython 3.15 oracle groups passed, covering callback order, exception identity, temporary lifetimes, partition equality and checked-entry-point differences. Final threaded cargo check passed for host_env, VM and stdlib. Threaded all-targets Clippy passed with exactly the same 12 existing diagnostics as the baseline and no new warning. Rustfmt, git diff --check, and normal commit hooks passed. Native RustPython execution is not available under the required safety guard; no native runtime or full test-suite pass is claimed. The separate non-threaded/WASM graph was not built under the current disk limit. Integration notes The shared dictionary hash-error formatter extraction is intentionally identical to the helper in #9693 rather than another implementation. Its set operation changes still require reconciling add/add_known_hash: preserve #9693's hash-only contextualization, keep raw collision errors unchanged, and delegate to one raw insertion helper. The formatter also overlaps #9700's Unicode-preserving key_hash change: retain the extracted WTF-8 helper and #9700's other qualified-name improvements. Source composition was inspected; the combined branches have not been compiled. Union/GenericAlias representation formatting and unrelated set-operation behavior remain outside this change. Repository tests, standard-library files and workflows are unchanged. Summary by CodeRabbit Bug Fixes Union creation and | operations now consistently flatten nested unions, remove duplicate members, and handle unhashable members. Empty unions now raise an error, while a union containing only one unique member returns that member directly. Hashing errors for dictionary keys now include context about the key and container while preserving non-TypeError exceptions. Converting a set to a frozen set no longer rehashes or compares its stored keys.

Open Graph Description: Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; ...

X Description: Summary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9714

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0737b4df-290e-4949-8c3c-882ca718d636
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA8A:FC5BE:34EA227:464CB6D:6B01FE41
html-safe-nonce69ec302a04bb6a528fe2eedbd932eeb98adfc6af15e3dd7cab554d161021e10e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQThBOkZDNUJFOjM0RUEyMjc6NDY0Q0I2RDo2QjAxRkU0MSIsInZpc2l0b3JfaWQiOiIyODc3MDc0OTExMjEyNDY5ODI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2e28fa2fb29811efa2e98b3af9762563914c1abfd111e8b07fea275d339495ad
hovercard-subject-tagpull_request:5158614222
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9714/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Build Union arguments through one streaming builder, preserving checked typing construction separately from unchecked type/GenericAlias operators. Subscription uses exact-tuple unpacking; ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9714/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9714%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9714%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9714/files
Reloadhttps://github.com/RustPython/RustPython/pull/9714/files
Reloadhttps://github.com/RustPython/RustPython/pull/9714/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/union-controls-20261104https://github.com/youknowdot/RustPython/tree/fix/union-controls-20261104
Conversation 3 https://github.com/RustPython/RustPython/pull/9714
Commits 1 https://github.com/RustPython/RustPython/pull/9714/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9714/checks
Files changed https://github.com/RustPython/RustPython/pull/9714/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9714/files
Align Union construction and callback controls https://github.com/RustPython/RustPython/pull/9714/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9714/files
4ee5c4a Align Union construction and callback controls youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9714/commits/4ee5c4ae4e45084c89000f73ff19a1199dc1ae4a
Clear filters https://github.com/RustPython/RustPython/pull/9714/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9714/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9714/files
dict.rs https://github.com/RustPython/RustPython/pull/9714/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
set.rs https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
union.rs https://github.com/RustPython/RustPython/pull/9714/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
crates/vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/9714/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
View file https://github.com/youknowdot/RustPython/blob/4ee5c4ae4e45084c89000f73ff19a1199dc1ae4a/crates/vm/src/builtins/dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9714/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9714/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9714/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
crates/vm/src/builtins/set.rshttps://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
View file https://github.com/youknowdot/RustPython/blob/4ee5c4ae4e45084c89000f73ff19a1199dc1ae4a/crates/vm/src/builtins/set.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9714/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
https://github.com/RustPython/RustPython/pull/9714/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9714/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9714/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.