René's URL Explorer Experiment


Title: Share typing representation and GenericAlias controls by youknowdot · Pull Request #9711 · RustPython/RustPython · GitHub

Open Graph Title: Share typing representation and GenericAlias controls by youknowdot · Pull Request #9711 · RustPython/RustPython

X Title: Share typing representation and GenericAlias controls by youknowdot · Pull Request #9711 · RustPython/RustPython

Description: Summary Align GenericAlias controls and share the Python 3.15 type-representation writer across GenericAlias, Union and constant annotation evaluators. The combined change spans three Rust files (+163/-182). Release the iterator's mutex before constructing its starred alias or dropping the original owner, so subclass finalizers can reenter the exhausted iterator. Preserve raw tuple-subclass equality results and CPython's inequality handling. Reconstruct the actual GenericAlias subtype in reduce/copy/pickle paths. Replace three divergent type formatters with one WTF-8 writer. Preserve optional-attribute lookup errors and short-circuits, non-string names, surrogate characters, and temporary-owner cleanup. Attribute probes release their values before the next callback. Preserve the public writer's extra __str__ call on returned str subclasses, after name-attribute cleanup. This call can change output or raise and must not be replaced with raw string copying. Match annotation tuple formatting, including (int) for a singleton tuple, and preserve Unicode in ConstEvaluator's own repr and Union's subclassing diagnostic. Validation Pinned reference: CPython d220409a13b77de7a6c30abe16ea90db01528edc, including typevarobject.c, genericaliasobject.c and unicode_writer.c. Independent source/ownership review passed. The expanded independent oracle passed 36 groups, a separate focused oracle passed 18 groups, and the previous 10 GenericAlias groups still passed. These are external CPython reference checks, not native RustPython runtime results. Final threaded cargo check passed (1m07s) and all-targets Clippy passed (2m21s), with exactly the same 12 existing baseline diagnostics and no new warnings. Rustfmt, diff checks and normal commit hooks passed without bypass. Limits and integration Native RustPython execution remains unperformed because its required safety guard is not verified; hosted runtime CI remains necessary. The separate non-threaded/WASM graph and full workspace/C-API test suite were not run under the current disk constraint. No repository tests, markers, Lib files or workflows changed. #9714 separately fixes Union construction and comparison; #9687 fixes TypeAliasType constructor binding; #9700 changes qualified-name diagnostics. Exact-source composition with those changes was clean and reviewed, but the combined branches were not compiled. Broader payload ownership work in #8944/#8939 may require textual reconciliation and does not implement these controls.

Open Graph Description: Summary Align GenericAlias controls and share the Python 3.15 type-representation writer across GenericAlias, Union and constant annotation evaluators. The combined change spans three Rust files (+...

X Description: Summary Align GenericAlias controls and share the Python 3.15 type-representation writer across GenericAlias, Union and constant annotation evaluators. The combined change spans three Rust files (+...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9711

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:87714a10-ec4b-ef64-22f0-ed7a1da3c34a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE868:2E124E:35F873F:44F747B:6B01F398
html-safe-noncef20a84d98a3f23a8a415d7a41e866137094363b5bf6afa967d2ad7d8cfa46c4f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODY4OjJFMTI0RTozNUY4NzNGOjQ0Rjc0N0I6NkIwMUYzOTgiLCJ2aXNpdG9yX2lkIjoiMjg2Nzk5MTI0NDM1OTk4ODEyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3c9456dbf879818a1e025078fe89dddd1250ae733d332b90168c8e400f1a421c
hovercard-subject-tagpull_request:5157732718
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9711/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Align GenericAlias controls and share the Python 3.15 type-representation writer across GenericAlias, Union and constant annotation evaluators. The combined change spans three Rust files (+...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9711/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9711%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9711%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9711/files
Reloadhttps://github.com/RustPython/RustPython/pull/9711/files
Reloadhttps://github.com/RustPython/RustPython/pull/9711/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/genericalias-controls-20261104https://github.com/youknowdot/RustPython/tree/fix/genericalias-controls-20261104
Conversation 2 https://github.com/RustPython/RustPython/pull/9711
Commits 3 https://github.com/RustPython/RustPython/pull/9711/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9711/checks
Files changed https://github.com/RustPython/RustPython/pull/9711/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9711/files
Share typing representation and GenericAlias controls https://github.com/RustPython/RustPython/pull/9711/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9711/files
56a6855 Align GenericAlias controls and iterator ownership youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9711/commits/56a68554075c8e02ccb2d64b265df623f95a7f25
9b809cc Share typing representation and callback handling youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9711/commits/9b809ccee7f3c7ee438b2700e2979ab697a90f20
a13bf7b Retain Comparable for GenericAlias rich comparison youknowdot Nov 5, 2026 https://github.com/RustPython/RustPython/pull/9711/commits/a13bf7b1917f2753b08478b6ade85813938e801c
Clear filters https://github.com/RustPython/RustPython/pull/9711/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9711/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9711/files
genericalias.rs https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
union.rs https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
_typing.rs https://github.com/RustPython/RustPython/pull/9711/files#diff-a93fc0a83c07336a0ee35bf0dd0a022c3eb3b689663e589b8734bc1cc2b8b437
crates/vm/src/builtins/genericalias.rshttps://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
View file https://github.com/youknowdot/RustPython/blob/a13bf7b1917f2753b08478b6ade85813938e801c/crates/vm/src/builtins/genericalias.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9711/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
https://github.com/RustPython/RustPython/pull/9711/files#diff-50dce477e053e887853906418f087d26aa04a4310de81dc59413b8af3ad97ee7
crates/vm/src/builtins/union.rshttps://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
View file https://github.com/youknowdot/RustPython/blob/a13bf7b1917f2753b08478b6ade85813938e801c/crates/vm/src/builtins/union.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9711/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
https://github.com/RustPython/RustPython/pull/9711/files#diff-87e9c817a54b80d7dba9354e36710817ee399ea28b4941eb0e55155ce0e7b84a
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9711/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9711/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.