René's URL Explorer Experiment


Title: Align weak-reference comparison and ownership controls by youknowdot · Pull Request #9710 · RustPython/RustPython · GitHub

Open Graph Title: Align weak-reference comparison and ownership controls by youknowdot · Pull Request #9710 · RustPython/RustPython

X Title: Align weak-reference comparison and ownership controls by youknowdot · Pull Request #9710 · RustPython/RustPython

Description: Summary Align weak-reference and proxy controls with Python 3.15 in three Rust files (+101/-92). Return raw weak-reference comparison results, preserve exact equality/inequality dispatch, and accept both proxy payload types as CPython does. Unwrap both proxy operands through the existing binary helper. Release upgraded binary/ternary operands in argument order after callbacks, including errors, without forcing comparison results to bool. Let the outer weak-reference hash result replace a recursively populated cache, or clear that cache on failure, before releasing the referent. Give live and dead proxies their own repr without invoking referent repr; preserve lossless type-name formatting when composed with #9700. Preserve Cell's raw comparison results while releasing owned contents in left-to-right order through a borrowed comparison call. Validation Compared against pinned CPython d220409a13b77de7a6c30abe16ea90db01528edc weakrefobject.c, cellobject.c and weakrefobject.h. The external CPython oracle passes 149 assertions plus 20 additional exact-repr assertions covering raw results, exact operations, both proxy types, dead operands, repr callback bypass, reentrant hash cache outcomes, and callback/finalizer order. Independent source/lifetime review passed on the final patch. An independent external oracle passed another 172 assertions, including direct proxy-slot dispatch, nested hash error/cache outcomes and last-owner finalizer visibility. Final threaded cargo check passed (1m03s) and all-target Clippy passed (1m34s), with exactly the 12 unchanged baseline diagnostics. Normal commit hooks passed without bypass. No Python tests, repository test logic, markers, Lib files or workflows are changed. Limits and integration Native RustPython execution remains unperformed because the required safety guard is not verified. External reference assertions and source review do not establish a native runtime pass; hosted CI remains necessary. Cross-thread hash critical-section equivalence and concurrent stress behavior are not established by this single-threaded compatibility work. The pinned CPython runtime leaks earlier upgraded operands when a later proxy is dead, and can corrupt a pending hash exception during finalizer reentry. Those upstream anomalies are deliberately not reproduced: Rust retains safe cleanup and the original error. Traceback-owned operand lifetimes can separately delay finalizers. Standalone surrogate module/qualname fidelity remains limited by the current shared helper; full lossless names require #9700. Constructor parsing remains unchanged. The patch preserves #9699's reversed-method area and composes with #9700's qualified-name return type change using the existing WTF-8 helper rather than a second formatter. Payload validation/ownership infrastructure from #8963/#8944/#8939 is not duplicated. Summary by CodeRabbit Bug Fixes Comparisons involving weak references and proxies now handle equality, inequality, and other comparison operations more consistently, including when the referenced object is no longer available. Weak proxy representations now show the referenced object’s type and ID while it is alive, and clearly indicate when the reference is dead. Weak reference hashing now uses the referenced object’s computed hash and reports an error if the object is no longer available.

Open Graph Description: Summary Align weak-reference and proxy controls with Python 3.15 in three Rust files (+101/-92). Return raw weak-reference comparison results, preserve exact equality/inequality dispatch, and acce...

X Description: Summary Align weak-reference and proxy controls with Python 3.15 in three Rust files (+101/-92). Return raw weak-reference comparison results, preserve exact equality/inequality dispatch, and acce...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9710

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9ced5202-7f54-e8b1-b780-edcf698a7125
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA28:3D97C8:32FBB9B:43D6543:6B01F397
html-safe-nonce335cf610f26d6ba33fbb56c7f1e1b27970b4135a20efec39de32edbf964666e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTI4OjNEOTdDODozMkZCQjlCOjQzRDY1NDM6NkIwMUYzOTciLCJ2aXNpdG9yX2lkIjoiNTIwOTk2MzMxNjYwNDE3MTE1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceb137fc9fffaccee307325fbb92ebdfca0ac4cb28a9c2de77cec69dfb5d81ac2
hovercard-subject-tagpull_request:5157373537
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9710/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Align weak-reference and proxy controls with Python 3.15 in three Rust files (+101/-92). Return raw weak-reference comparison results, preserve exact equality/inequality dispatch, and acce...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9710/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9710%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9710%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9710/files
Reloadhttps://github.com/RustPython/RustPython/pull/9710/files
Reloadhttps://github.com/RustPython/RustPython/pull/9710/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/weakref-controls-20261104https://github.com/youknowdot/RustPython/tree/fix/weakref-controls-20261104
Conversation 6 https://github.com/RustPython/RustPython/pull/9710
Commits 2 https://github.com/RustPython/RustPython/pull/9710/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9710/checks
Files changed https://github.com/RustPython/RustPython/pull/9710/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9710/files
Align weak-reference comparison and ownership controls https://github.com/RustPython/RustPython/pull/9710/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9710/files
ac65df3 Align weak-reference comparison and ownership controls youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9710/commits/ac65df38627151d6d05bb4d2fa66f714bbd17266
a7a1456 Retain Comparable for weak references and proxies youknowdot Nov 5, 2026 https://github.com/RustPython/RustPython/pull/9710/commits/a7a1456281b78836060376d3a053d99c82bf3683
Clear filters https://github.com/RustPython/RustPython/pull/9710/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9710/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9710/files
function.rs https://github.com/RustPython/RustPython/pull/9710/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
weakproxy.rs https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
weakref.rs https://github.com/RustPython/RustPython/pull/9710/files#diff-020cc7f97369cc44897d6701bf55623beecc2cb6eb62578c59456f17e2e79046
crates/vm/src/builtins/function.rshttps://github.com/RustPython/RustPython/pull/9710/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
View file https://github.com/youknowdot/RustPython/blob/a7a1456281b78836060376d3a053d99c82bf3683/crates/vm/src/builtins/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9710/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9710/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
https://github.com/RustPython/RustPython/pull/9710/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
crates/vm/src/builtins/weakproxy.rshttps://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
View file https://github.com/youknowdot/RustPython/blob/a7a1456281b78836060376d3a053d99c82bf3683/crates/vm/src/builtins/weakproxy.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9710/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
https://github.com/RustPython/RustPython/pull/9710/files#diff-518160a6bf622184ad8479c3ae06ed1013978232d9059a602482e6a0fd03f17a
crates/vm/src/builtins/weakref.rshttps://github.com/RustPython/RustPython/pull/9710/files#diff-020cc7f97369cc44897d6701bf55623beecc2cb6eb62578c59456f17e2e79046
View file https://github.com/youknowdot/RustPython/blob/a7a1456281b78836060376d3a053d99c82bf3683/crates/vm/src/builtins/weakref.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9710/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9710/files#diff-020cc7f97369cc44897d6701bf55623beecc2cb6eb62578c59456f17e2e79046
https://github.com/RustPython/RustPython/pull/9710/files#diff-020cc7f97369cc44897d6701bf55623beecc2cb6eb62578c59456f17e2e79046
https://github.com/RustPython/RustPython/pull/9710/files#diff-020cc7f97369cc44897d6701bf55623beecc2cb6eb62578c59456f17e2e79046
coderabbitaihttps://github.com/apps/coderabbitai
Nov 5, 2026https://github.com/RustPython/RustPython/pull/9710/files#r4476421996
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9710/files
https://github.com/RustPython/RustPython/pull/9710/files#diff-020cc7f97369cc44897d6701bf55623beecc2cb6eb62578c59456f17e2e79046
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9710/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.