Title: Align bytearray mutation and export controls by youknowdot · Pull Request #9694 · RustPython/RustPython · GitHub
Open Graph Title: Align bytearray mutation and export controls by youknowdot · Pull Request #9694 · RustPython/RustPython
X Title: Align bytearray mutation and export controls by youknowdot · Pull Request #9694 · RustPython/RustPython
Description: Summary Align bytearray slice and mutation/export controls with CPython 3.15: Treat an empty extended-slice assignment as deletion, and check nonempty extended-size mismatches before exported-buffer resize errors. Permit empty linear deletions with exports while preserving CPython's extended-deletion checks. Reject numeric/string sources with the slice-assignment error, preserve distinct bytearray-subclass storage handling, and repeat slice conversion after materializing other sources or self-assignment. Share pop/scalar-deletion bounds checks, permit empty buffer extension and concatenation with exports, preserve buffer callback insertion timing and source-export lifetimes, and align concat error rewriting. Handle empty and nonpositive repetition without recursive payload locking, check common repeat overflow before export rejection, and reserve append/insert growth fallibly. Keep same-size exported storage in place and revalidate the current payload after acquiring its write guard. The shared slice helper reuses the existing resize guard, saturated indices, and deletion machinery. Related mutators reuse the same slice mutation, byte conversion, buffer and index helpers. This is 291 meaningful changed production lines, without test/Lib/marker/workflow changes. Validation Compared against CPython 3.15.0 bytearray slice implementation. Independent source review passed, covering export epochs, lock order, callback/finalizer lifetimes, repeated conversion, and allocation. Bounded CPython-only probes recorded 126 cases, nine asserted callback/alias cases, and five existing upstream test bodies. An independent CPython/source-model comparison covered 38,016 slice cases with zero discrepancies, plus two finalizer/release probes. The mutation extension added 154 bounded CPython observations, exported-only extreme-repeat probes without large allocation, and 12 unchanged upstream test bodies. These are reference/source-model checks, not RustPython execution. Focused host-env/VM/stdlib threading cargo check, normal all-targets Clippy, formatting, diff checks, and normal commit hooks passed. Clippy's four diagnostics exactly match unchanged main: one POSIX needless-collect and three ElementTree lints. Strict -D warnings is not clean because of that baseline; no warnings were suppressed. Native RustPython execution, full workspace and C-API runtime suites, and cross-platform tests were not run. Hosted CI is still required. Remaining limits Under exported-payload lock contention, remove keeps the preexisting immediate BufferError if its nonblocking read cannot establish that the byte is missing. It does not add a blocking recursive read. CPython reserves bytes-object header space below the maximum signed length. The existing VM repeat helper uses the signed-length bound, so extreme exported repetition near that limit can still report BufferError instead of MemoryError. No ABI-specific header constant or enormous-allocation test was added. Constructor streaming/partial mutation and release-callback behavior are outside this patch. AI-assisted implementation and independent review using OpenAI Codex; model version is not exposed. Summary by CodeRabbit Bug Fixes Bytearray resizing operations now consistently raise BufferError while the bytearray is exported, while same-size writes remain available where permitted. Slice assignment handles empty extended-slice deletions and mismatched slice lengths more reliably. Buffer-based assignment and extension now handle empty and non-contiguous inputs more consistently. Append, insert, pop, and remove operations now handle resizing and validation more reliably.
Open Graph Description: Summary Align bytearray slice and mutation/export controls with CPython 3.15: Treat an empty extended-slice assignment as deletion, and check nonempty extended-size mismatches before exported-buff...
X Description: Summary Align bytearray slice and mutation/export controls with CPython 3.15: Treat an empty extended-slice assignment as deletion, and check nonempty extended-size mismatches before exported-buff...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9694
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2946a7be-471f-3dd6-96c0-3c72dc5c5062 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A92A:17FB7:2FE2BE7:3CC843D:6B01FA5C |
| html-safe-nonce | f66851e93b84152274c330ee0cc6e81e4f7ab56ecd8373ef6e0b1c85069d259d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTJBOjE3RkI3OjJGRTJCRTc6M0NDODQzRDo2QjAxRkE1QyIsInZpc2l0b3JfaWQiOiIyODMzMDQwOTM0MDgxNjQ0NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7bd3b351d2d81af61f43dcaad7083759468c99cc72c4c19745932db0b476e30e |
| hovercard-subject-tag | pull_request:5151379285 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9694/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Align bytearray slice and mutation/export controls with CPython 3.15: Treat an empty extended-slice assignment as deletion, and check nonempty extended-size mismatches before exported-buff... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width