Title: Align set and dictionary view operation controls by youknowdot · Pull Request #9693 · RustPython/RustPython · GitHub
Open Graph Title: Align set and dictionary view operation controls by youknowdot · Pull Request #9693 · RustPython/RustPython
X Title: Align set and dictionary view operation controls by youknowdot · Pull Request #9693 · RustPython/RustPython
Description: Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until each operation consumes an operand. Preserve self-operation behavior, cached native hashes, operation-specific dict/frozendict hashing, equality exceptions, and mutable-set fallback errors. Match dictionary-view intersection dispatch and item-view symmetric difference using a private left copy, live right traversal, stored key hashes, and explicit cleanup order. Reuse native set construction for reflected view operations without invoking subclass iterators or re-comparing clean copied keys. Select dense/sparse dictionary copies through the shared copy helper, and check live dict-merge mutation after each item, including skipped keys. Keep temporary objects alive across callbacks, release them in the required order, and preserve safe deletion and length/hash snapshots. No per-function handwritten FuncArgs parsing. The related dictionary-view work is folded into this PR rather than creating an overlapping change. Total: 788 changed lines in three production Rust files. No Python/Lib/test logic, markers, or workflows changed. Existing native test callers remain intact. Validation Independent exact-source and composition review against CPython 3.15.0 set operations and dictionary views/copy/merge. Original set group: 116 implementation and 63 independent bounded CPython assertions. Dictionary-view group: 48 implementation and 42 independent assertions, including collisions, subclass overrides, live mutation, callback failures, and finalizer ordering. These are CPython/source checks, not RustPython execution. Final focused host-env/VM/stdlib threading cargo check, normal all-targets Clippy, formatting, diff checks, and ordinary commit hooks passed. Four Clippy diagnostics exactly match unchanged main: one POSIX needless-collect and three ElementTree lints. Strict -D warnings remains blocked by that baseline; no suppression or unrelated baseline edits. Native RustPython execution, full workspace/C-API runtime suites, and cross-platform tests were not run. Hosted CI is still required. Hash-table layout and same-size mutation traversal remain implementation-dependent; no identical-layout claim is made. AI-assisted implementation and independent review using OpenAI Codex; model version is not exposed. Shared type-name compatibility The extracted dict/set hash-error helper uses the existing WTF-8 concatenation mechanism, preserving both type names and exception text when composed with #9700. Other set/dictionary-view behavior is byte-identical to the previously reviewed head. Independent in-memory composition review verified the exact previous head plus this narrow formatting change. Final focused host-env/VM/stdlib threading check, normal all-targets Clippy and ordinary hooks passed; the same four unchanged baseline diagnostics remain. No new runtime execution or test changes are claimed. Intersection failure cleanup The shared fallback now retains the current item through both membership testing and consuming set insertion. On failure it explicitly releases the iterator, partial result, and current item in that order. Accepted and rejected candidates are released before requesting the next item. Existing exact-set delegation, view-size swapping, and symmetric-difference paths are unchanged. Independent frozen-source ownership review found no blocker. The additional pinned CPython reference checks passed 60 assertions across 16 groups plus 20 independent assertions, covering direct/reflected keys/items operations, membership and insertion failures, iterator failures, normal exhaustion, and candidate cleanup before the next request. These establish reference behavior and source review, not RustPython runtime execution. Cached item-tuple identity/reuse remains outside this change because it requires a separately reviewed tuple ownership/GC design. Final threaded host-env/VM/stdlib check passed in 1m09s and all-targets Clippy in 2m24s, with exactly the same four baseline diagnostics (one POSIX and three ElementTree). Ordinary commit hooks passed. No native RustPython or full-suite execution is claimed. Summary by CodeRabbit Bug Fixes Dictionary updates now detect when the source dictionary changes during the operation and raise a runtime error. Set and frozenset operations better handle dictionary views, set subclasses, and iterator errors. Set predicates now consistently validate arguments and handle cases where iteration is disabled. Performance Some dictionary and set operations use more direct paths, which may reduce unnecessary copying and lookups.
Open Graph Description: Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until ea...
X Description: Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until ea...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9693
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a38bbd97-368d-efa9-54d2-156fe8e9ce88 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8794:97D39:CB784B:10CC5EB:6B01FA59 |
| html-safe-nonce | b35b09835746490472cf0d1ca382658bc0ddefc8f9a884cd9595600f08b921aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzk0Ojk3RDM5OkNCNzg0QjoxMENDNUVCOjZCMDFGQTU5IiwidmlzaXRvcl9pZCI6IjIzMjg3NTM0NDg4OTc2MDgyODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 25dd6fdaac7527563921c4ddb1ca4ae0628c44dc852817947bc8651195f6fce1 |
| hovercard-subject-tag | pull_request:5151108238 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9693/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until ea... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width