René's URL Explorer Experiment


Title: Align set and dictionary view operation controls by youknowdot · Pull Request #9693 · RustPython/RustPython · GitHub

Open Graph Title: Align set and dictionary view operation controls by youknowdot · Pull Request #9693 · RustPython/RustPython

X Title: Align set and dictionary view operation controls by youknowdot · Pull Request #9693 · RustPython/RustPython

Description: Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until each operation consumes an operand. Preserve self-operation behavior, cached native hashes, operation-specific dict/frozendict hashing, equality exceptions, and mutable-set fallback errors. Match dictionary-view intersection dispatch and item-view symmetric difference using a private left copy, live right traversal, stored key hashes, and explicit cleanup order. Reuse native set construction for reflected view operations without invoking subclass iterators or re-comparing clean copied keys. Select dense/sparse dictionary copies through the shared copy helper, and check live dict-merge mutation after each item, including skipped keys. Keep temporary objects alive across callbacks, release them in the required order, and preserve safe deletion and length/hash snapshots. No per-function handwritten FuncArgs parsing. The related dictionary-view work is folded into this PR rather than creating an overlapping change. Total: 788 changed lines in three production Rust files. No Python/Lib/test logic, markers, or workflows changed. Existing native test callers remain intact. Validation Independent exact-source and composition review against CPython 3.15.0 set operations and dictionary views/copy/merge. Original set group: 116 implementation and 63 independent bounded CPython assertions. Dictionary-view group: 48 implementation and 42 independent assertions, including collisions, subclass overrides, live mutation, callback failures, and finalizer ordering. These are CPython/source checks, not RustPython execution. Final focused host-env/VM/stdlib threading cargo check, normal all-targets Clippy, formatting, diff checks, and ordinary commit hooks passed. Four Clippy diagnostics exactly match unchanged main: one POSIX needless-collect and three ElementTree lints. Strict -D warnings remains blocked by that baseline; no suppression or unrelated baseline edits. Native RustPython execution, full workspace/C-API runtime suites, and cross-platform tests were not run. Hosted CI is still required. Hash-table layout and same-size mutation traversal remain implementation-dependent; no identical-layout claim is made. AI-assisted implementation and independent review using OpenAI Codex; model version is not exposed. Shared type-name compatibility The extracted dict/set hash-error helper uses the existing WTF-8 concatenation mechanism, preserving both type names and exception text when composed with #9700. Other set/dictionary-view behavior is byte-identical to the previously reviewed head. Independent in-memory composition review verified the exact previous head plus this narrow formatting change. Final focused host-env/VM/stdlib threading check, normal all-targets Clippy and ordinary hooks passed; the same four unchanged baseline diagnostics remain. No new runtime execution or test changes are claimed. Intersection failure cleanup The shared fallback now retains the current item through both membership testing and consuming set insertion. On failure it explicitly releases the iterator, partial result, and current item in that order. Accepted and rejected candidates are released before requesting the next item. Existing exact-set delegation, view-size swapping, and symmetric-difference paths are unchanged. Independent frozen-source ownership review found no blocker. The additional pinned CPython reference checks passed 60 assertions across 16 groups plus 20 independent assertions, covering direct/reflected keys/items operations, membership and insertion failures, iterator failures, normal exhaustion, and candidate cleanup before the next request. These establish reference behavior and source review, not RustPython runtime execution. Cached item-tuple identity/reuse remains outside this change because it requires a separately reviewed tuple ownership/GC design. Final threaded host-env/VM/stdlib check passed in 1m09s and all-targets Clippy in 2m24s, with exactly the same four baseline diagnostics (one POSIX and three ElementTree). Ordinary commit hooks passed. No native RustPython or full-suite execution is claimed. Summary by CodeRabbit Bug Fixes Dictionary updates now detect when the source dictionary changes during the operation and raise a runtime error. Set and frozenset operations better handle dictionary views, set subclasses, and iterator errors. Set predicates now consistently validate arguments and handle cases where iteration is disabled. Performance Some dictionary and set operations use more direct paths, which may reduce unnecessary copying and lookups.

Open Graph Description: Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until ea...

X Description: Summary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until ea...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9693

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a38bbd97-368d-efa9-54d2-156fe8e9ce88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8794:97D39:CB784B:10CC5EB:6B01FA59
html-safe-nonceb35b09835746490472cf0d1ca382658bc0ddefc8f9a884cd9595600f08b921aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzk0Ojk3RDM5OkNCNzg0QjoxMENDNUVCOjZCMDFGQTU5IiwidmlzaXRvcl9pZCI6IjIzMjg3NTM0NDg4OTc2MDgyODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac25dd6fdaac7527563921c4ddb1ca4ae0628c44dc852817947bc8651195f6fce1
hovercard-subject-tagpull_request:5151108238
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9693/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Align native set operands, hashing, and related dictionary-view operations with CPython 3.15, using existing shared conversion and dictionary primitives. Delay iterable conversion until ea...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9693/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9693%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9693%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9693/files
Reloadhttps://github.com/RustPython/RustPython/pull/9693/files
Reloadhttps://github.com/RustPython/RustPython/pull/9693/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:set-controls-parity-20261104https://github.com/youknowdot/RustPython/tree/set-controls-parity-20261104
Conversation 6 https://github.com/RustPython/RustPython/pull/9693
Commits 6 https://github.com/RustPython/RustPython/pull/9693/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9693/checks
Files changed https://github.com/RustPython/RustPython/pull/9693/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9693/files
Align set and dictionary view operation controls https://github.com/RustPython/RustPython/pull/9693/files#top
Show all changes 6 commits https://github.com/RustPython/RustPython/pull/9693/files
4d40ae7 Align set operand and hashing controls with CPython youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9693/commits/4d40ae7424aa793b68923baf796b172e071f6ebc
cb29554 Keep legacy dictionary deletion wrapper test-only youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9693/commits/cb2955430f326f4e44f3fcf0bc336231a78ce1d2
52066f0 Align dictionary view and native copy controls youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9693/commits/52066f05d26ff76ff43d25dda9376ad753148473
3ad0432 Reuse set construction for dictionary view operands youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9693/commits/3ad04323411774db92d3ed67ec9b49b7b801bcae
bb6a02e Preserve intersection failure cleanup order youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9693/commits/bb6a02e00563414ed85237caaa83d63a2a589bed
d5b0314 Restore typed set predicate arguments codex Nov 6, 2026 https://github.com/RustPython/RustPython/pull/9693/commits/d5b0314e64a121c9d921f4595151931556ca4648
Clear filters https://github.com/RustPython/RustPython/pull/9693/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9693/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9693/files
dict.rs https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
set.rs https://github.com/RustPython/RustPython/pull/9693/files#diff-ca3250b43726cb4327f8b4f6d413151036abc2f00f7c3197f55432013ca2c07f
dict_inner.rs https://github.com/RustPython/RustPython/pull/9693/files#diff-aa3e0344e8fe84f229558c441057af178d20ee5bb19fda4bc01485a9a62bf99e
builtin_set.py https://github.com/RustPython/RustPython/pull/9693/files#diff-49fd7f7d95c68ebdcf476b292e14e8698f1b0bf06c065fee93f13440128597b3
crates/vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
View file https://github.com/youknowdot/RustPython/blob/d5b0314e64a121c9d921f4595151931556ca4648/crates/vm/src/builtins/dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9693/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
coderabbitaihttps://github.com/apps/coderabbitai
Nov 6, 2026https://github.com/RustPython/RustPython/pull/9693/files#r4488866931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9693/files
https://github.com/RustPython/RustPython/pull/9693/files#diff-da22219fe05502509c75f7b1ba56079fecf076601f219531bef523705764e68b
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9693/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9693/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.