René's URL Explorer Experiment


Title: Align socket receive and control argument binding by youknowdot · Pull Request #9668 · RustPython/RustPython · GitHub

Open Graph Title: Align socket receive and control argument binding by youknowdot · Pull Request #9668 · RustPython/RustPython

X Title: Align socket receive and control argument binding by youknowdot · Pull Request #9668 · RustPython/RustPython

Description: Summary Share recv_into/recvfrom_into keyword binding through the VM's existing ArgSpec helper, preserving buffer export and numeric conversion order. Return immediately from zero-length recv and recv_into, including on closed sockets, as CPython does. Bind sendto and setsockopt arguments before conversion, retain original arguments through I/O, and acquire sendto's buffer export before converting flags without holding its data lock across callbacks. Only production Rust files change. Existing special no-keyword and sendto overload diagnostics remain. Evidence and validation Checked CPython 3.15 source (Modules/socketmodule.c: sock_recv_guts, sock_recv_into, sock_recvfrom_into, sock_sendto, and sock_setsockopt). Bounded CPython 3.15.0 probes using only an owned socketpair confirmed: Both into-methods accept buffer, nbytes, and flags keywords. Buffer rejection precedes numeric callbacks; valid numeric callbacks precede duplicate/unknown keyword errors. Numeric callbacks can mutate exported buffer contents. Zero-byte recv and recv_into return immediately, including after closing the socket. sendto rejects an invalid buffer before invoking a flags callback. Invalid setsockopt arity does not invoke numeric callbacks. rustfmt and git diff --check passed. Exact-head cached patches for #9638, #9640, and #9642 each apply cleanly over this change. Passed on Linux against main 0b081b0283987c7b2d79327dd481f403d515580b: cargo check -p rustpython-vm -p rustpython-host_env -p rustpython-stdlib --features rustpython-stdlib/threading --locked --offline -j1 cargo clippy -p rustpython-vm -p rustpython-host_env -p rustpython-stdlib --features rustpython-stdlib/threading --locked --offline -j1 -- -D warnings RustPython runtime tests, the full Rust suites, Python suites, and other-platform testing were not run. CPython probes establish reference behavior, not execution of the patched RustPython interpreter. Known limits The receive methods already had a text-signature mismatch with CPython's keyword support. Their representation now becomes generic (*args, **kwargs); this patch does not repair introspection metadata. Writable-buffer error wording remains that of the shared buffer helper rather than claiming exact CPython wording. The zero-byte results above were observed on Linux. On non-poll platforms CPython checks high-descriptor selectability before returning zero, so these observations do not establish blanket cross-platform equivalence. Independent source review passed with no blocker. Integration note #9651 changes ArgSpec::parse_with from Fn to FnMut. This change exposes that existing helper and deliberately does not duplicate #9651's callback change. There is one adjacent-line textual conflict: preserve pub fn parse_with from this change and mut check: impl FnMut from #9651. The receive parser remains compatible with either callback signature. AI assistance The source investigation, patch, reference probes, and this draft were prepared with OpenAI Codex assistance under the maintainer's direction. Human review is requested before merge. Summary by CodeRabbit Bug Fixes Socket receive operations now return immediately with an empty result when given a zero-length buffer. Receive operations validate requested byte counts, including negative and oversized values, with appropriate errors. Socket send methods now enforce their supported argument counts and reject keyword arguments where unsupported.

Open Graph Description: Summary Share recv_into/recvfrom_into keyword binding through the VM's existing ArgSpec helper, preserving buffer export and numeric conversion order. Return immediately from zero-length recv ...

X Description: Summary Share recv_into/recvfrom_into keyword binding through the VM's existing ArgSpec helper, preserving buffer export and numeric conversion order. Return immediately from zero-length r...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9668

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1b275e97-f937-8ecd-0054-28092815ffe4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8724:EA09B:337C58B:4444F3D:6B01F3B1
html-safe-nonced97207bcc50f2e3b8784b390e428422ec1ef7294c7a889cebb644bbc2ef5ca7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzI0OkVBMDlCOjMzN0M1OEI6NDQ0NEYzRDo2QjAxRjNCMSIsInZpc2l0b3JfaWQiOiIyNzQyMzI1NTEyNDgzNjAzNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2087a59fed00d2ca101502da9cafdeb32f4ccd2bb7077c168a9fe0829ba60bca
hovercard-subject-tagpull_request:5145830072
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9668/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Share recv_into/recvfrom_into keyword binding through the VM's existing ArgSpec helper, preserving buffer export and numeric conversion order. Return immediately from zero-length recv ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9668/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9668%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9668%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9668/files
Reloadhttps://github.com/RustPython/RustPython/pull/9668/files
Reloadhttps://github.com/RustPython/RustPython/pull/9668/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:socket-control-binding-group-20261103https://github.com/youknowdot/RustPython/tree/socket-control-binding-group-20261103
Conversation 7 https://github.com/RustPython/RustPython/pull/9668
Commits 3 https://github.com/RustPython/RustPython/pull/9668/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9668/checks
Files changed https://github.com/RustPython/RustPython/pull/9668/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9668/files
Align socket receive and control argument binding https://github.com/RustPython/RustPython/pull/9668/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9668/files
b807b94 Align socket receive and control argument binding youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9668/commits/b807b94581bc1f8023861b4df67f5173c5d51ded
194c8ed Preserve setsockopt arity error messages youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9668/commits/194c8ed395bdcebe47f9f8b774124d1c2fbd20d4
358945c Restore typed socket arguments with legacy conversion ordering codex Nov 7, 2026 https://github.com/RustPython/RustPython/pull/9668/commits/358945c014767a7ca186f34b0c41fe96c129d1c3
Clear filters https://github.com/RustPython/RustPython/pull/9668/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9668/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9668/files
crates/stdlib/src/socket.rshttps://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
View file https://github.com/youknowdot/RustPython/blob/358945c014767a7ca186f34b0c41fe96c129d1c3/crates/stdlib/src/socket.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9668/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
youknowonehttps://github.com/youknowone
Nov 6, 2026https://github.com/RustPython/RustPython/pull/9668/files#r4492319166
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#9563https://github.com/RustPython/RustPython/pull/9563
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9668/files
youknowonehttps://github.com/youknowone
Nov 7, 2026https://github.com/RustPython/RustPython/pull/9668/files#r4500504661
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#9563https://github.com/RustPython/RustPython/pull/9563
recv_intohttps://github.com/python/cpython/blob/d220409a13b77de7a6c30abe16ea90db01528edc/Modules/socketmodule.c#L4037
conversion loop precedes leftover duplicate/unknown-keyword checkshttps://github.com/python/cpython/blob/d220409a13b77de7a6c30abe16ea90db01528edc/Python/getargs.c#L1673
#9563https://github.com/RustPython/RustPython/pull/9563
358945chttps://github.com/RustPython/RustPython/commit/358945c014767a7ca186f34b0c41fe96c129d1c3
ReceiveIntoArgs::parsehttps://github.com/RustPython/RustPython/blob/358945c014767a7ca186f34b0c41fe96c129d1c3/crates/stdlib/src/socket.rs#L1897-L1945
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9668/files
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
https://github.com/RustPython/RustPython/pull/9668/files#diff-184374c26b267e900965c88a05d2c963f9c2fcdc8419201b0fa39b9ed462b5c7
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9668/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.