Title: Fix math reduction conversion and numeric protocol handling by youknowdot · Pull Request #9666 · RustPython/RustPython · GitHub
Open Graph Title: Fix math reduction conversion and numeric protocol handling by youknowdot · Pull Request #9666 · RustPython/RustPython
X Title: Fix math reduction conversion and numeric protocol handling by youknowdot · Pull Request #9666 · RustPython/RustPython
Description: Summary Align math reduction protocol handling with CPython 3.15: Materialize both dist points and check dimensions before converting coordinates; convert matching coordinates in p/q order and read tuple subclasses directly. Restrict prod fast paths to exact builtin types, preserving float subclass multiplication and empty-product results. Simplify the staged accumulator and enable its integer path for explicit integer starts. Preserve sumprod iterator construction and exception order, including errors paired with exhaustion. Include bool weights in compensated float accumulation. Uses existing typed argument binding, sequence conversion, arithmetic, and pymath norm/compensation machinery. No tests, Python files, or workflows changed. Source comparison Compared against CPython revision d220409a13b77de7a6c30abe16ea90db01528edc: math_dist_impl math_sumprod_impl math_prod_impl Validation Passed rustfmt and git diff --check. Passed 12 bounded CPython 3.15.0 reference probes covering dist conversion and dimension-check order, tuple subclasses, prod subclass dispatch and empty results, sumprod iterator errors/construction order, and compensated cancellation with bool weights in both orientations. Passed cargo check and strict Clippy (-D warnings) for rustpython-vm, rustpython-host_env, and rustpython-stdlib with rustpython-stdlib/threading, locked/offline and one build job, against base 0b081b0. Workspace/C-API tests and RustPython test_math execution were not run. Reference probes establish expected CPython behavior, not RustPython runtime correctness. Native RustPython execution is held pending the required safety guard. This does not claim full math parity. In particular, sumprod retains its existing O(n) buffered float-pair storage rather than implementing CPython’s streaming accumulator. AI-assisted implementation and source comparison using OpenAI Codex (model version not exposed), directed by the maintainer.
Open Graph Description: Summary Align math reduction protocol handling with CPython 3.15: Materialize both dist points and check dimensions before converting coordinates; convert matching coordinates in p/q order and rea...
X Description: Summary Align math reduction protocol handling with CPython 3.15: Materialize both dist points and check dimensions before converting coordinates; convert matching coordinates in p/q order and rea...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9666
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:35c40d76-fc58-214c-6b2a-9bfdcdd72e48 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A90C:D4E59:50D800:6617DC:6B01FA5A |
| html-safe-nonce | 9242f171130f436b7bec039bcd12958bd57e0a2c2e633df87f4c1637b1c2dbbc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTBDOkQ0RTU5OjUwRDgwMDo2NjE3REM6NkIwMUZBNUEiLCJ2aXNpdG9yX2lkIjoiMzY1NTQ0ODIyMjE5OTA1Mjg5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3cac02214b1188415141f56402da32455ec42c32f6a28310c1c612758aec6733 |
| hovercard-subject-tag | pull_request:5145787513 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9666/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Align math reduction protocol handling with CPython 3.15: Materialize both dist points and check dimensions before converting coordinates; convert matching coordinates in p/q order and rea... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width