Title: Release struct packing buffers around conversions by youknowdot · Pull Request #9658 · RustPython/RustPython · GitHub
Open Graph Title: Release struct packing buffers around conversions by youknowdot · Pull Request #9658 · RustPython/RustPython
X Title: Release struct packing buffers around conversions by youknowdot · Pull Request #9658 · RustPython/RustPython
Description: Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining arguments and the exported destination. Clear the target region once before packing and preserve sequential/partial writes, callback changes to padding and unwritten tails, and successful complex components before a later conversion failure. Validate string fields as bytes/bytearray, including zero-width fields. Snapshot only the bounded mutable source payload for external destinations, avoiding both same-buffer and cross-buffer lock deadlocks. Avoid signed-negation and addition overflow when checking buffer offsets, and report the actual required argument count. The existing public raw-slice FormatSpec::pack_into helper remains available. No tests, snippets, or workflows are changed. Validation VM/stdlib library cargo check and strict threading Clippy passed on the reviewed source. The same source was then rebased over the Windows-only #9574 change; its hashes are unchanged. Isolated CPython 3.15.0 reference probes cover initial zeroing, callback mutation and partial failure, string/Pascal validation and tails, long Pascal payloads, complex-component failure, self/nested-memoryview aliasing, argument-count failures, and extreme offsets. Independent source review, rustfmt, diff checks, and normal commit hooks passed. RustPython runtime tests, full workspace tests, C-API tests, and non-Linux execution were not run locally because the native execution guard is unavailable. Hosted CI is still required. Existing bounds-versus-argument-count validation precedence remains outside this patch. Zero-width Pascal handling deliberately avoids CPython's unsafe out-of-region length-byte write. Reference: CPython 3.15 struct packing. AI assistance OpenAI Codex assisted with source analysis, implementation, reference-case preparation, review, and this description. Model version was not exposed by this runtime. Summary by CodeRabbit Bug Fixes Improved bounds checking when packing data into a buffer, including for negative offsets. Buffer packing now handles overlapping byte-array input safely. Behavior Changes String and Pascal-string fields now accept bytes and bytearray values. Other input types are rejected, and accepted values are truncated to fit the field’s capacity.
Open Graph Description: Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining ...
X Description: Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9658
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b7e72321-2068-9099-998d-2cbcc165967c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 987A:1050BD:1747472:1EC687D:6B0209B9 |
| html-safe-nonce | 8bd58a613c482639844a75ab7b6501a4b6e49f5c01cd4b6f1db0c5e7978c4847 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODdBOjEwNTBCRDoxNzQ3NDcyOjFFQzY4N0Q6NkIwMjA5QjkiLCJ2aXNpdG9yX2lkIjoiNjk5NTM5NDY5OTE1ODc1MTY3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 205e32a9155e860eb3281d8fb405b7e886eaa8780e012646572254b959d96cda |
| hovercard-subject-tag | pull_request:5144922912 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9658/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width