René's URL Explorer Experiment


Title: Release struct packing buffers around conversions by youknowdot · Pull Request #9658 · RustPython/RustPython · GitHub

Open Graph Title: Release struct packing buffers around conversions by youknowdot · Pull Request #9658 · RustPython/RustPython

X Title: Release struct packing buffers around conversions by youknowdot · Pull Request #9658 · RustPython/RustPython

Description: Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining arguments and the exported destination. Clear the target region once before packing and preserve sequential/partial writes, callback changes to padding and unwritten tails, and successful complex components before a later conversion failure. Validate string fields as bytes/bytearray, including zero-width fields. Snapshot only the bounded mutable source payload for external destinations, avoiding both same-buffer and cross-buffer lock deadlocks. Avoid signed-negation and addition overflow when checking buffer offsets, and report the actual required argument count. The existing public raw-slice FormatSpec::pack_into helper remains available. No tests, snippets, or workflows are changed. Validation VM/stdlib library cargo check and strict threading Clippy passed on the reviewed source. The same source was then rebased over the Windows-only #9574 change; its hashes are unchanged. Isolated CPython 3.15.0 reference probes cover initial zeroing, callback mutation and partial failure, string/Pascal validation and tails, long Pascal payloads, complex-component failure, self/nested-memoryview aliasing, argument-count failures, and extreme offsets. Independent source review, rustfmt, diff checks, and normal commit hooks passed. RustPython runtime tests, full workspace tests, C-API tests, and non-Linux execution were not run locally because the native execution guard is unavailable. Hosted CI is still required. Existing bounds-versus-argument-count validation precedence remains outside this patch. Zero-width Pascal handling deliberately avoids CPython's unsafe out-of-region length-byte write. Reference: CPython 3.15 struct packing. AI assistance OpenAI Codex assisted with source analysis, implementation, reference-case preparation, review, and this description. Model version was not exposed by this runtime. Summary by CodeRabbit Bug Fixes Improved bounds checking when packing data into a buffer, including for negative offsets. Buffer packing now handles overlapping byte-array input safely. Behavior Changes String and Pascal-string fields now accept bytes and bytearray values. Other input types are rejected, and accepted values are truncated to fit the field’s capacity.

Open Graph Description: Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining ...

X Description: Summary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9658

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7e72321-2068-9099-998d-2cbcc165967c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id987A:1050BD:1747472:1EC687D:6B0209B9
html-safe-nonce8bd58a613c482639844a75ab7b6501a4b6e49f5c01cd4b6f1db0c5e7978c4847
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODdBOjEwNTBCRDoxNzQ3NDcyOjFFQzY4N0Q6NkIwMjA5QjkiLCJ2aXNpdG9yX2lkIjoiNjk5NTM5NDY5OTE1ODc1MTY3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac205e32a9155e860eb3281d8fb405b7e886eaa8780e012646572254b959d96cda
hovercard-subject-tagpull_request:5144922912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9658/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Use one packing walker with short, callback-free destination writes. Both Python pack_into paths release destination borrows before value conversion or source acquisition, while retaining ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9658/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9658%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9658%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9658/files
Reloadhttps://github.com/RustPython/RustPython/pull/9658/files
Reloadhttps://github.com/RustPython/RustPython/pull/9658/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/struct-pack-buffer-callbacks-20261103https://github.com/youknowdot/RustPython/tree/fix/struct-pack-buffer-callbacks-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9658
Commits 1 https://github.com/RustPython/RustPython/pull/9658/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9658/checks
Files changed https://github.com/RustPython/RustPython/pull/9658/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9658/files
Release struct packing buffers around conversions https://github.com/RustPython/RustPython/pull/9658/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9658/files
068190f Release struct packing buffers around conversions youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9658/commits/068190fe79a5c2fcc1030b30cd347f151e16c379
Clear filters https://github.com/RustPython/RustPython/pull/9658/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9658/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9658/files
pystruct.rs https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
buffer.rs https://github.com/RustPython/RustPython/pull/9658/files#diff-d18d959cce63c4cd0df32cadf2e5fbf956ee1a94f2dc6cd36b53f3a5696a1592
crates/stdlib/src/pystruct.rshttps://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
View file https://github.com/youknowdot/RustPython/blob/068190fe79a5c2fcc1030b30cd347f151e16c379/crates/stdlib/src/pystruct.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9658/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9658/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9658/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9658/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.