René's URL Explorer Experiment


Title: Preserve channel argument conversion order by youknowdot · Pull Request #9651 · RustPython/RustPython · GitHub

Open Graph Title: Preserve channel argument conversion order by youknowdot · Pull Request #9651 · RustPython/RustPython

X Title: Preserve channel argument conversion order by youknowdot · Pull Request #9651 · RustPython/RustPython

Description: Summary Let the existing ArgSpec::parse_with callback retain converted values through FnMut. It remains monomorphized; no new parser or boxed callback is introduced. Reuse channel ID, integer, and truth-conversion results instead of invoking user-defined conversion methods a second time. This covers channel ID construction, close/release, list_interpreters, send, and send_buffer. Preserve CPython's legacy PyArg_ParseTupleAndKeywords conversion order, including conversion before later missing/duplicate/unknown-keyword errors. Move create/recv conversions into that same shared parser and convert release's force argument even though its value is ignored. Add five generic parser unit tests for mutable result retention, callback order, error precedence, and failure short-circuiting. No snippet tests were added. The source reference is CPython v3.15.0 _interpchannelsmodule.c. Unlike _interpqueues, these functions still use the legacy parser, so replacing it with ordinary FromArgs or moving every conversion after validation would change observable behavior. Original FuncArgs owners remain alive across conversions, and channel locks are taken only afterward. Validation cargo check -p rustpython-vm --lib --offline: passed. cargo check -p rustpython-vm --tests --features threading --offline: passed. cargo clippy -p rustpython-vm --lib --features threading --offline -- -D warnings: passed. cargo clippy -p rustpython-vm --tests --features threading --offline -- -D warnings: passed after fixing two iterator-style warnings in the new tests. Normal pre-commit hooks, standalone rustfmt checks, and git diff --check: passed. Independent source review checked the format strings, defaults, conversion and error ordering, retained object ownership, and lack of new boxing/allocation overhead. 21 CPython 3.15.0 reference cases confirmed single conversion, force conversion, parameter order, and legacy error precedence. These verify the reference behavior, not execution of the RustPython implementation. The new Rust tests were compiled but not executed locally. Full workspace/C API tests and RustPython test_interpreters.test_channels execution remain for hosted CI because the coordinated native-execution guard is unavailable. Existing timeout numeric-policy issues are outside this focused change; it does not claim complete channel conversion parity. AI assistance Implementation and validation were assisted by OpenAI Codex. Its exact model version is not exposed in this runtime. Summary by CodeRabbit Refactor Interpreter channel arguments are now validated and converted as they are processed. Existing defaults and downstream behavior are preserved. Argument checks run in parameter order and stop after a check fails. Missing-argument and extra-keyword errors are reported after checks for supplied values.

Open Graph Description: Summary Let the existing ArgSpec::parse_with callback retain converted values through FnMut. It remains monomorphized; no new parser or boxed callback is introduced. Reuse channel ID, integer, and...

X Description: Summary Let the existing ArgSpec::parse_with callback retain converted values through FnMut. It remains monomorphized; no new parser or boxed callback is introduced. Reuse channel ID, integer, and...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9651

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7b9ca97e-5259-a8a2-e5dd-03ec834d4e78
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDD6:928E2:333833B:444C5E9:6B01F931
html-safe-noncea30b309bf6dd7127bdc913fb7e4b6bde303ef627ac8656dcd883bf4c0370df4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREQ2OjkyOEUyOjMzMzgzM0I6NDQ0QzVFOTo2QjAxRjkzMSIsInZpc2l0b3JfaWQiOiIxNTE5NDA4MzA0MTA1ODQ3MDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacab5b25c482e1279d289b20ce8ad9664b9eceb2b0e56df8d54d0d8957cb3c75a3
hovercard-subject-tagpull_request:5143285141
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9651/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Let the existing ArgSpec::parse_with callback retain converted values through FnMut. It remains monomorphized; no new parser or boxed callback is introduced. Reuse channel ID, integer, and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9651/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9651%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9651%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9651/files
Reloadhttps://github.com/RustPython/RustPython/pull/9651/files
Reloadhttps://github.com/RustPython/RustPython/pull/9651/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/channel-argument-conversions-20261103https://github.com/youknowdot/RustPython/tree/fix/channel-argument-conversions-20261103
Conversation 2 https://github.com/RustPython/RustPython/pull/9651
Commits 2 https://github.com/RustPython/RustPython/pull/9651/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9651/checks
Files changed https://github.com/RustPython/RustPython/pull/9651/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9651/files
Preserve channel argument conversion order https://github.com/RustPython/RustPython/pull/9651/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9651/files
24c1a5c Convert channel arguments once in parser order youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9651/commits/24c1a5cbd4a2a2c6830271144219c74001eb76e4
7c0743d Use single-item iterators in parser tests youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9651/commits/7c0743dd9d4b6aefd233ff566b5ef9c3dac28897
Clear filters https://github.com/RustPython/RustPython/pull/9651/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9651/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9651/files
getargs.rs https://github.com/RustPython/RustPython/pull/9651/files#diff-b8936bed211f8893170e24800c67018525c3640e981542c860f9b304e4671a20
_interpchannels.rs https://github.com/RustPython/RustPython/pull/9651/files#diff-fa1c7ca12e67b26d7a0213373d22c85c6aac36a55553bf218393f82ec08f5726
crates/vm/src/function/getargs.rshttps://github.com/RustPython/RustPython/pull/9651/files#diff-b8936bed211f8893170e24800c67018525c3640e981542c860f9b304e4671a20
View file https://github.com/youknowdot/RustPython/blob/7c0743dd9d4b6aefd233ff566b5ef9c3dac28897/crates/vm/src/function/getargs.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9651/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9651/files#diff-b8936bed211f8893170e24800c67018525c3640e981542c860f9b304e4671a20
https://github.com/RustPython/RustPython/pull/9651/files#diff-b8936bed211f8893170e24800c67018525c3640e981542c860f9b304e4671a20
https://github.com/RustPython/RustPython/pull/9651/files#diff-b8936bed211f8893170e24800c67018525c3640e981542c860f9b304e4671a20
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9651/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9651/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.