Title: Safeguard AF_ALG control and send buffers by youknowdot · Pull Request #9638 · RustPython/RustPython · GitHub
Open Graph Title: Safeguard AF_ALG control and send buffers by youknowdot · Pull Request #9638 · RustPython/RustPython
X Title: Safeguard AF_ALG control and send buffers by youknowdot · Pull Request #9638 · RustPython/RustPython
Description: Summary Build AF_ALG sendmsg control messages in storage aligned for cmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with checked arithmetic before writing, so oversized IVs cannot be truncated to a smaller CMSG length followed by a copy using the original size. Allocate the control buffer once and report allocation/size errors rather than relying on unchecked growth. Validate the IV descriptor length before copying, and use the existing unlocked snapshot strategy for payloads across blocking sends. This change is scoped to the AF_ALG host helper. Generic ancillary packing/parsing, argument conversion, iovec behavior and the existing difference from CPython's padded IV cmsg_len remain unchanged. Size/allocation errors are I/O errors here, not a claim of exact CPython exception parity. The wrapper validates the IV length before its existing copy; valid but very large IVs can still require a large allocation. Mutable and non-bytes payloads are copied once, which changes concurrent mutation visibility and adds allocation/MemoryError cost; immutable bytes keep the existing borrowed fast path. Existing argument validation, IV handling, binder behavior, and the shared snapshot helper's error path are not claimed fully CPython-compatible. Validation Independently source-reviewed Linux CMSG layout, alignment, initialization, checked size arithmetic including 32-bit rounded allocation, ownership and lifetime through the syscall. rustfmt, git diff --check and normal repository hooks passed. No local RustPython build, runtime test, benchmark, or dedicated oversized-IV test was run. Hosted CI is required. Existing test_socket.LinuxKernelCryptoAPI AES tests exercise this path only when AF_ALG accept and the relevant kernel algorithms work; their existing expected-failure markers are unchanged. The separate accept change is #9637, and neither PR requires a stacked base.
Open Graph Description: Summary Build AF_ALG sendmsg control messages in storage aligned for cmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with check...
X Description: Summary Build AF_ALG sendmsg control messages in storage aligned for cmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with check...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9638
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f2cac3ec-967e-a2de-a35d-6f4a96d515a8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C8DA:5D487:14FE60B:1BD4BCC:6B01FE66 |
| html-safe-nonce | 21d2364929b57b11fd33e34a7c913189750515f5f5ab7bb8902a1208da10645c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOERBOjVENDg3OjE0RkU2MEI6MUJENEJDQzo2QjAxRkU2NiIsInZpc2l0b3JfaWQiOiI1MDI0MDY4NjE5NDA4MTEzMjU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1a217f39dbfb7a0b54202e2ed6647c8186c71c0d99e412f7613f26ef0bb2b6fd |
| hovercard-subject-tag | pull_request:5140038107 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9638/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Build AF_ALG sendmsg control messages in storage aligned for cmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with check... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width