René's URL Explorer Experiment


Title: Return None from bisect insort by youknowdot · Pull Request #9630 · RustPython/RustPython · GitHub

Open Graph Title: Return None from bisect insort by youknowdot · Pull Request #9630 · RustPython/RustPython

X Title: Return None from bisect insort by youknowdot · Pull Request #9630 · RustPython/RustPython

Description: Consolidated into #9629 Closed after verifying #9629 at 1eae2eb5b1534c20bfd79f9befc0075661096136 includes this branch's latest head 28395170fc393de1ecb337ffe3abf23d4cf4c9df as an ancestor. Both insort result-disposal and argument-lifetime behavior are preserved. The final redundant-clone lint expectations are superseded by borrowed arguments. The combined change passed native bisect tests, CPython 3.15 differential probes, full workspace and separate C-API Rust tests, and both strict Clippy runs. Summary Discard the result of a custom sequence's insert() in both _bisect.insort directions and return None, as CPython does. Keep the input and key objects alive through destruction of that result, so its finalizer cannot observe them being released prematurely. Search and insertion exceptions still propagate. Scope and integration Existing differences in lo/hi argument lifetime and callback order, as well as the lack of an exact-list native insertion fast path, remain separate. The bounds-order follow-on on #9629 now conflicts textually with this branch's insort hunks. A manually composed version retaining this PR's result-discard and ownership behavior has been independently source-reviewed; no merge has been performed. Validation Compared with CPython 3.15.0 _bisectmodule.c. CPython 3.15 reproductions confirmed both directions return None for an insert() returning a sentinel and release an ephemeral insertion result before the input and key objects. Independent source review of this change and of the manual #9629 composition, plus normal commit hooks (including rustfmt), passed. RustPython was not built or executed locally. No tests were added or changed; hosted CI is expected to run existing bisect tests.

Open Graph Description: Consolidated into #9629 Closed after verifying #9629 at 1eae2eb5b1534c20bfd79f9befc0075661096136 includes this branch's latest head 28395170fc393de1ecb337ffe3abf23d4cf4c9df as an ancestor. Both...

X Description: Consolidated into #9629 Closed after verifying #9629 at 1eae2eb5b1534c20bfd79f9befc0075661096136 includes this branch's latest head 28395170fc393de1ecb337ffe3abf23d4cf4c9df as an ancestor. ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9630

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73120f3a-089b-b351-e1f1-b838b95e9329
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBF8:2270F4:3622055:47C8843:6B02028C
html-safe-noncecfd626cd107266ebe680e2cd7aca345b952460604cf8281e2aa60a678daec637
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkY4OjIyNzBGNDozNjIyMDU1OjQ3Qzg4NDM6NkIwMjAyOEMiLCJ2aXNpdG9yX2lkIjoiNjAyNjM1MjgxNzY0NjczMTkxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1ac0ac1c2f339184c93f3062c5c8de79fda69b52c67aabb6e77f03059b0ac647
hovercard-subject-tagpull_request:5138891563
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9630/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altConsolidated into #9629 Closed after verifying #9629 at 1eae2eb5b1534c20bfd79f9befc0075661096136 includes this branch's latest head 28395170fc393de1ecb337ffe3abf23d4cf4c9df as an ancestor. Both...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9630/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9630%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9630%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9630/files
Reloadhttps://github.com/RustPython/RustPython/pull/9630/files
Reloadhttps://github.com/RustPython/RustPython/pull/9630/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowdothttps://github.com/youknowdot
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/bisect-insort-return-none-20261103https://github.com/youknowdot/RustPython/tree/fix/bisect-insort-return-none-20261103
Conversation 1 https://github.com/RustPython/RustPython/pull/9630
Commits 2 https://github.com/RustPython/RustPython/pull/9630/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9630/checks
Files changed https://github.com/RustPython/RustPython/pull/9630/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9630/files
Return None from bisect insort https://github.com/RustPython/RustPython/pull/9630/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9630/files
611849f Return None from bisect insort youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9630/commits/611849f857c93ec3dd755168ff1a444c02cd9d53
2839517 Preserve insort argument lifetime under Clippy youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9630/commits/28395170fc393de1ecb337ffe3abf23d4cf4c9df
Clear filters https://github.com/RustPython/RustPython/pull/9630/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9630/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9630/files
crates/stdlib/src/bisect.rshttps://github.com/RustPython/RustPython/pull/9630/files#diff-a315142cbd74ce29a74ac04b25cea56eac16541854672cbbcf2eebb1758b3649
View file https://github.com/youknowdot/RustPython/blob/28395170fc393de1ecb337ffe3abf23d4cf4c9df/crates/stdlib/src/bisect.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9630/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9630/files#diff-a315142cbd74ce29a74ac04b25cea56eac16541854672cbbcf2eebb1758b3649
https://github.com/RustPython/RustPython/pull/9630/files#diff-a315142cbd74ce29a74ac04b25cea56eac16541854672cbbcf2eebb1758b3649
https://github.com/RustPython/RustPython/pull/9630/files#diff-a315142cbd74ce29a74ac04b25cea56eac16541854672cbbcf2eebb1758b3649
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9630/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.