René's URL Explorer Experiment


Title: Clear Element children when replacing extra state by youknowdot · Pull Request #9624 · RustPython/RustPython · GitHub

Open Graph Title: Clear Element children when replacing extra state by youknowdot · Pull Request #9624 · RustPython/RustPython

X Title: Clear Element children when replacing extra state by youknowdot · Pull Request #9624 · RustPython/RustPython

Description: Summary When an Element is reinitialized with a nonempty attribute mapping, replace its extra state and clear existing children. As in CPython, reinitialization with no attributes or an empty mapping preserves the existing attributes and children. Displaced RustPython references are released after the element lock is dropped. Lifetime distinction CPython 3.15.0's element_init calls create_extra, which overwrites the old extra pointer on this unusual reinitialization path without freeing it. A CPython weak-reference check confirms the detached child remains alive. This change intentionally releases the displaced state instead of reproducing that leak, so finalizer timing and reentrant side effects can differ from CPython. Validation CPython 3.15.0 reproductions checked absent, empty and nonempty attribute mappings, child counts, attribute identity, text/tail reset and detached-child lifetime. Independent source review and normal commit hooks (including rustfmt) passed. Sequential local three-way file merges with #9591, #9594 and #9598 were clean. RustPython was not built or executed locally. No tests were added or changed; hosted CI is expected to run existing ElementTree tests. Summary by CodeRabbit Bug Fixes Element initialization now preserves existing attributes when no nonempty attributes are provided. When nonempty attributes are provided, initialization now clears existing children along with replacing attributes.

Open Graph Description: Summary When an Element is reinitialized with a nonempty attribute mapping, replace its extra state and clear existing children. As in CPython, reinitialization with no attributes or an empty mappi...

X Description: Summary When an Element is reinitialized with a nonempty attribute mapping, replace its extra state and clear existing children. As in CPython, reinitialization with no attributes or an empty mappi...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9624

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d48dcbd2-7af8-7f63-e062-78a69accfa88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA04:31E99C:35EE89C:47E62CB:6B020873
html-safe-nonce831006a2a5cea750b8ade70ef31bd904f32be3648492b050b4c6fb2c07a4f958
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTA0OjMxRTk5QzozNUVFODlDOjQ3RTYyQ0I6NkIwMjA4NzMiLCJ2aXNpdG9yX2lkIjoiMjg2OTAzNDEzMTEzODkzODk5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd36acf64acbe1b6f680b0d18fe50690c6b7e1f2417205949824b90c86ed02ab4
hovercard-subject-tagpull_request:5138174518
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9624/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary When an Element is reinitialized with a nonempty attribute mapping, replace its extra state and clear existing children. As in CPython, reinitialization with no attributes or an empty mappi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9624/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9624%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9624%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9624/files
Reloadhttps://github.com/RustPython/RustPython/pull/9624/files
Reloadhttps://github.com/RustPython/RustPython/pull/9624/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/element-reinit-children-20261103https://github.com/youknowdot/RustPython/tree/fix/element-reinit-children-20261103
Conversation 2 https://github.com/RustPython/RustPython/pull/9624
Commits 1 https://github.com/RustPython/RustPython/pull/9624/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9624/checks
Files changed https://github.com/RustPython/RustPython/pull/9624/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9624/files
Clear Element children when replacing extra state https://github.com/RustPython/RustPython/pull/9624/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9624/files
b8e0c80 Clear Element children when replacing extra state youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9624/commits/b8e0c805cc77accc1a082bce44298ee74e265ca1
Clear filters https://github.com/RustPython/RustPython/pull/9624/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9624/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9624/files
crates/stdlib/src/elementtree.rshttps://github.com/RustPython/RustPython/pull/9624/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
View file https://github.com/youknowdot/RustPython/blob/b8e0c805cc77accc1a082bce44298ee74e265ca1/crates/stdlib/src/elementtree.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9624/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9624/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9624/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9624/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.