René's URL Explorer Experiment


Title: Fix ctypes restype assignment by youknowdot · Pull Request #9615 · RustPython/RustPython · GitHub

Open Graph Title: Fix ctypes restype assignment by youknowdot · Pull Request #9615 · RustPython/RustPython

X Title: Fix ctypes restype assignment by youknowdot · Pull Request #9615 · RustPython/RustPython

Description: Summary Release the ctypes function's restype write lock before dropping the replaced value. A callable's finalizer may reassign the property, so dropping it under the lock can deadlock. The replacement is published before the old reference is released. Preserve an explicitly assigned None separately from an unset instance value. This selects a void return instead of falling back to the class default. When no instance override exists, return the class default in the getter, consistent with the existing call path. Scope CPython caches the original class restype, whereas the existing RustPython call path and this getter read the live class attribute. Class mutation after type creation can therefore still differ. Deletion/reset support and general _check_retval_ dispatch remain separate; internal helper and COM paths are not comprehensively aligned. Validation CPython 3.15.0 confirmed a replaced restype callable's finalizer can reassign restype, explicit None returns None until a concrete restype is restored, and the getter exposes a declared class default. Independent source review for each commit and normal commit hooks (including rustfmt) passed. RustPython was not built or executed locally. No tests were added or changed; hosted CI is expected to run the existing ctypes tests. The getter receiver was corrected to &Self after Windows CI exposed the nested Py type error in #9615; the same issue was fixed proactively in #9613. The corrected heads require hosted CI recompilation. Summary by CodeRabbit Bug Fixes Corrected how restype is resolved for ctypes function pointers: when no instance-level value is set, it now uses the function-pointer class’s declared default. Explicitly setting restype to None now remains an instance-level override rather than being treated as unset.

Open Graph Description: Summary Release the ctypes function's restype write lock before dropping the replaced value. A callable's finalizer may reassign the property, so dropping it under the lock can deadlock. T...

X Description: Summary Release the ctypes function's restype write lock before dropping the replaced value. A callable's finalizer may reassign the property, so dropping it under the lock can dea...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9615

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a4d21486-1d5c-5255-b44c-d3f047f3cea7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1B0:4BB79:333DC97:41840FB:6B01E414
html-safe-noncef0976dc4a458bac213a3c87d1cb497ad89847060622331fc445cc9bb691ae6c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIwOjRCQjc5OjMzM0RDOTc6NDE4NDBGQjo2QjAxRTQxNCIsInZpc2l0b3JfaWQiOiIyMjE3OTY0MjIyMDM2NDM1OTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4505620bafbf5f0518f9115d03dee67947990eafdc7516c1219947e2d3526c96
hovercard-subject-tagpull_request:5137464853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9615/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Release the ctypes function's restype write lock before dropping the replaced value. A callable's finalizer may reassign the property, so dropping it under the lock can deadlock. T...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9615/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9615%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9615%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9615/files
Reloadhttps://github.com/RustPython/RustPython/pull/9615/files
Reloadhttps://github.com/RustPython/RustPython/pull/9615/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/ctypes-restype-reentry-20261103https://github.com/youknowdot/RustPython/tree/fix/ctypes-restype-reentry-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9615
Commits 5 https://github.com/RustPython/RustPython/pull/9615/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9615/checks
Files changed https://github.com/RustPython/RustPython/pull/9615/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9615/files
Fix ctypes restype assignment https://github.com/RustPython/RustPython/pull/9615/files#top
Show all changes 5 commits https://github.com/RustPython/RustPython/pull/9615/files
9d18226 Allow reentrant ctypes restype finalizers youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9615/commits/9d182263ae3e18ca46eaf4f233e813ea924a491e
e04b531 Preserve explicit ctypes restype None youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9615/commits/e04b5319d5435bb2eb807b08215ac486528f3ed9
636dcb5 Expose ctypes class restype default youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9615/commits/636dcb5218299363684514c598547cb31aadb27d
a5e3bad Fix ctypes getter receiver type youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9615/commits/a5e3badf1821501f31bf25f33cabc9c8761832bc
3d60e79 Release restype getter guard before class fallback youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9615/commits/3d60e791225d6fddf1a1ddf96368d004b9c6fbba
Clear filters https://github.com/RustPython/RustPython/pull/9615/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9615/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9615/files
crates/vm/src/stdlib/_ctypes/function.rshttps://github.com/RustPython/RustPython/pull/9615/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
View file https://github.com/youknowdot/RustPython/blob/3d60e791225d6fddf1a1ddf96368d004b9c6fbba/crates/vm/src/stdlib/_ctypes/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9615/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9615/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
https://github.com/RustPython/RustPython/pull/9615/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9615/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.