René's URL Explorer Experiment


Title: Fix itertools iterator state and lifetime by youknowdot · Pull Request #9614 · RustPython/RustPython · GitHub

Open Graph Title: Fix itertools iterator state and lifetime by youknowdot · Pull Request #9614 · RustPython/RustPython

X Title: Fix itertools iterator state and lifetime by youknowdot · Pull Request #9614 · RustPython/RustPython

Description: Summary Publish chain, accumulate and pairwise state under their locks, then release displaced Python objects after unlocking so finalizers can reenter without deadlocking. Transfer accumulate's initial value into the total once, so it is no longer retained after the total changes. Omitted/None initial avoids the new one-time locks. Stop pairwise from repolling after source termination and preserve a chain's source when an active inner iterator raises a non-Stop exception. Validation Independent source reviews against CPython 3.15.0, including recursive iteration, finalizer reentry, reference lifetimes and lock ordering. prek run --files crates/vm/src/stdlib/itertools.rs and normal commit hooks passed. Existing test_itertools includes pairwise iterator-reentry tests, ordinary accumulate initial-value cases and chain error propagation. Direct finalizer reentry, pairwise repolling and chain resumption after error were not found in those tests. No tests were edited and RustPython was not run locally; hosted CI is needed for build/runtime evidence. This is scoped iterator-state work, not complete parity: pairwise retains source/old references after termination, and pre-existing chain source/error and broader concurrent-iteration differences remain. The accumulate initial transfer adds object storage, a branch and a GC read guard; no benchmark was run. Summary by CodeRabbit Bug Fixes Iterator chaining now moves past exhausted iterators and reports iteration errors directly. Accumulation now yields a supplied starting value once before processing items. Pairwise iteration now stops after the source ends or encounters an error, preventing later calls from resuming it.

Open Graph Description: Summary Publish chain, accumulate and pairwise state under their locks, then release displaced Python objects after unlocking so finalizers can reenter without deadlocking. Transfer accumulate'...

X Description: Summary Publish chain, accumulate and pairwise state under their locks, then release displaced Python objects after unlocking so finalizers can reenter without deadlocking. Transfer accumulate&...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9614

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:18459c75-a35a-6dbd-a0bd-4ebe9697b6ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8ED0:14700E:366A9D0:451DB9A:6B01E6B9
html-safe-nonce846ff20c6cd4b4024dee213880ea2cafac9a9312d6a78295c9a461fb50807cb4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUQwOjE0NzAwRTozNjZBOUQwOjQ1MURCOUE6NkIwMUU2QjkiLCJ2aXNpdG9yX2lkIjoiMTM1MTA2OTU3MzQ5NDk5MDUyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac29e3f5e56cb69099064258b5970d9049af21a9ea20e1b8360c5a8208771c2c62
hovercard-subject-tagpull_request:5137456957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9614/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Publish chain, accumulate and pairwise state under their locks, then release displaced Python objects after unlocking so finalizers can reenter without deadlocking. Transfer accumulate'...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9614/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9614%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9614%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9614/files
Reloadhttps://github.com/RustPython/RustPython/pull/9614/files
Reloadhttps://github.com/RustPython/RustPython/pull/9614/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/itertools-state-release-lock-20261103https://github.com/youknowdot/RustPython/tree/fix/itertools-state-release-lock-20261103
Conversation 2 https://github.com/RustPython/RustPython/pull/9614
Commits 5 https://github.com/RustPython/RustPython/pull/9614/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9614/checks
Files changed https://github.com/RustPython/RustPython/pull/9614/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9614/files
Fix itertools iterator state and lifetime https://github.com/RustPython/RustPython/pull/9614/files#top
Show all changes 5 commits https://github.com/RustPython/RustPython/pull/9614/files
5cc735a Avoid finalizing itertools state under locks youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9614/commits/5cc735a40ab5a7a695572ad2074620b9ba14a0e7
6a560e3 Release chain iterator state outside its lock youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9614/commits/6a560e3880c3edd0aea5df0ace7828bc4b78ca71
3e073dd Transfer accumulate initial value into total youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9614/commits/3e073dd1f2f4bfe49e9caafd4ba25b2e19d8f70c
d9e4bce Stop pairwise after source termination youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9614/commits/d9e4bcedd717c80cdb77c5d05ba62bae4b8a6850
3b40a5b Keep chain source after an active iterator error youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9614/commits/3b40a5ba578956c7689c862acb5deb82b86697cb
Clear filters https://github.com/RustPython/RustPython/pull/9614/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9614/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9614/files
crates/vm/src/stdlib/itertools.rshttps://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
View file https://github.com/youknowdot/RustPython/blob/3b40a5ba578956c7689c862acb5deb82b86697cb/crates/vm/src/stdlib/itertools.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9614/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9614/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9614/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.