René's URL Explorer Experiment


Title: Fix ctypes argtypes handling by youknowdot · Pull Request #9613 · RustPython/RustPython · GitHub

Open Graph Title: Fix ctypes argtypes handling by youknowdot · Pull Request #9613 · RustPython/RustPython

X Title: Fix ctypes argtypes handling by youknowdot · Pull Request #9613 · RustPython/RustPython

Description: Summary Snapshot a ctypes function's argtypes before invoking its sequence methods, allowing those methods to reassign function.argtypes without trying to acquire the same lock recursively. Release the setter's write lock before dropping the replaced object, so its finalizer can also re-enter the setter. When no instance override exists, report the class argument types used by the call path, or None if there is no class default. An explicitly assigned empty tuple remains distinct. Scope This fixes lock reentrancy and the ordinary unset getter, not full argument-converter parity. CPython validates/converts argtypes at assignment, while RustPython currently resolves the stored sequence during a call. CPython also caches the original class argument types, whereas this getter and the current RustPython call path read the live class attribute. Class mutation after type creation can therefore still differ. Deletion/reset and raw-sequence lifetime also remain separate. Validation CPython 3.15.0 confirmed reassignment from an argtypes sequence method and the old sequence's finalizer, and the getter's behavior for CDLL functions, prototypes, explicit empty tuples and assignment of None. Independent source review for each commit and normal commit hooks (including rustfmt) passed. RustPython was not built or executed locally. No tests were added or changed; hosted CI is expected to run the existing ctypes tests. The getter receiver was corrected to &Self after Windows CI exposed the nested Py type error in #9615; the same issue was fixed proactively in #9613. The corrected heads require hosted CI recompilation. Summary by CodeRabbit Bug Fixes Function argument-type settings now consistently reflect instance overrides or class-level defaults. Reading argument-type settings returns the configured class default when no instance override is set, rather than an empty result. Function calls use a stable snapshot of instance argument-type settings, improving consistency if those settings change during a call. Updating argument-type settings is more reliable when cleanup callbacks run during the update.

Open Graph Description: Summary Snapshot a ctypes function's argtypes before invoking its sequence methods, allowing those methods to reassign function.argtypes without trying to acquire the same lock recursively. Re...

X Description: Summary Snapshot a ctypes function's argtypes before invoking its sequence methods, allowing those methods to reassign function.argtypes without trying to acquire the same lock recursively...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9613

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:931608fb-004f-31e5-569a-de97db3d1acc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ACE:76F02:3497A94:4345AFE:6B01DE82
html-safe-nonce3ee1233836e713f46848ab61100a208214a1ea469270f3dce8feb31fffef9ddc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUNFOjc2RjAyOjM0OTdBOTQ6NDM0NUFGRTo2QjAxREU4MiIsInZpc2l0b3JfaWQiOiI3MDM2NTIxODk3MjM1OTYzNTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace05cee1520b799a785b4510b6519ba5d4f105937782eec2815c7fab89c93a0c4
hovercard-subject-tagpull_request:5137435677
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9613/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Snapshot a ctypes function's argtypes before invoking its sequence methods, allowing those methods to reassign function.argtypes without trying to acquire the same lock recursively. Re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9613/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9613%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9613%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9613/files
Reloadhttps://github.com/RustPython/RustPython/pull/9613/files
Reloadhttps://github.com/RustPython/RustPython/pull/9613/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/ctypes-argtypes-reentry-20261103https://github.com/youknowdot/RustPython/tree/fix/ctypes-argtypes-reentry-20261103
Conversation 4 https://github.com/RustPython/RustPython/pull/9613
Commits 5 https://github.com/RustPython/RustPython/pull/9613/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9613/checks
Files changed https://github.com/RustPython/RustPython/pull/9613/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9613/files
Fix ctypes argtypes handling https://github.com/RustPython/RustPython/pull/9613/files#top
Show all changes 5 commits https://github.com/RustPython/RustPython/pull/9613/files
fba93d0 Avoid locking across ctypes argtypes callbacks youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9613/commits/fba93d0fa39c22cba0ae5c08c363080f1ed37dac
0dc9234 Expose ctypes class argtypes default youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9613/commits/0dc92341fb73945ec90399a187d0797b91dc3d61
810ff33 Fix ctypes getter receiver type youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9613/commits/810ff33150505fc387a175ff923dc8e9619f53f6
f63c905 Release ctypes argtypes read guard before class lookup youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9613/commits/f63c905b583221c649b09d303f5490d63a23c513
a43ce9a Use core for argtypes value replacement youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9613/commits/a43ce9a3be4bf6f748045a4339a9c8036a463152
Clear filters https://github.com/RustPython/RustPython/pull/9613/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9613/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9613/files
crates/vm/src/stdlib/_ctypes/function.rshttps://github.com/RustPython/RustPython/pull/9613/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
View file https://github.com/youknowdot/RustPython/blob/a43ce9a3be4bf6f748045a4339a9c8036a463152/crates/vm/src/stdlib/_ctypes/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9613/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9613/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
https://github.com/RustPython/RustPython/pull/9613/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
https://github.com/RustPython/RustPython/pull/9613/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
https://github.com/RustPython/RustPython/pull/9613/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9613/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.