René's URL Explorer Experiment


Title: Drop replaced tracing callbacks outside locks by youknowdot · Pull Request #9612 · RustPython/RustPython · GitHub

Open Graph Title: Drop replaced tracing callbacks outside locks by youknowdot · Pull Request #9612 · RustPython/RustPython

X Title: Drop replaced tracing callbacks outside locks by youknowdot · Pull Request #9612 · RustPython/RustPython

Description: Summary Retain replaced trace and profile callbacks until the current-thread or all-thread updates are complete and the associated locks and VM borrows are released. A callback's finalizer can reenter these APIs; dropping a last reference while holding a callback or thread-registry mutex can otherwise deadlock. For all-thread setters, reserve storage for the old slot callbacks before changing global or slot state. On allocation failure, release the registry lock before constructing MemoryError and leave tracing state unchanged. The lock order follows the existing thread-slot initialization path. Validation Independently source-reviewed for current/all-thread state ordering, callback ownership, reentrancy, unwind and allocation-failure handling, lock order, threading/nonthreading configurations, and CPython 3.15's deferred old-callback decrefs. prek run --files crates/vm/src/stdlib/sys.rs, normal commit hooks, and git diff --check passed. Native RustPython compilation and execution were not run locally; hosted CI is required. Existing test_threading cases cover normal all-thread trace/profile updates, but no existing test identified directly covers finalizer reentry. Scope This is a narrow callback-lifetime fix. Existing all-thread dispatch and stop-the-world differences from CPython remain outside this change. No Lib or test files were modified.

Open Graph Description: Summary Retain replaced trace and profile callbacks until the current-thread or all-thread updates are complete and the associated locks and VM borrows are released. A callback's finalizer can ...

X Description: Summary Retain replaced trace and profile callbacks until the current-thread or all-thread updates are complete and the associated locks and VM borrows are released. A callback's finalizer ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9612

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61173f8e-feb7-bfb5-6129-3438a5000320
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC110:97D39:D72309:11C122B:6B01FE7E
html-safe-nonce96eba8f880f277bfadfbb396f952ebd47c87123a65d57cf44c4bfce4b891b8c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTEwOjk3RDM5OkQ3MjMwOToxMUMxMjJCOjZCMDFGRTdFIiwidmlzaXRvcl9pZCI6IjM2MjUyNjI1NTYzODc2MDYxNDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac18cb2ad154e6057760fe3ddc22e89f7797888f19db0c622c4e9e09d8c2d07f0b
hovercard-subject-tagpull_request:5137390504
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9612/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Retain replaced trace and profile callbacks until the current-thread or all-thread updates are complete and the associated locks and VM borrows are released. A callback's finalizer can ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9612/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9612%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9612%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9612/files
Reloadhttps://github.com/RustPython/RustPython/pull/9612/files
Reloadhttps://github.com/RustPython/RustPython/pull/9612/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/tracing-callback-release-lock-20261103https://github.com/youknowdot/RustPython/tree/fix/tracing-callback-release-lock-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9612
Commits 2 https://github.com/RustPython/RustPython/pull/9612/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9612/checks
Files changed https://github.com/RustPython/RustPython/pull/9612/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9612/files
Drop replaced tracing callbacks outside locks https://github.com/RustPython/RustPython/pull/9612/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9612/files
eeef862 Drop replaced tracing callbacks outside locks youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9612/commits/eeef862b3fb3a07eb093428fa4d12dc3f9650604
53da77d Document fallible tracing signatures on non-threaded targets youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9612/commits/53da77da6702586b3f8bed7ce26e382530c3bcdc
Clear filters https://github.com/RustPython/RustPython/pull/9612/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9612/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9612/files
crates/vm/src/stdlib/sys.rshttps://github.com/RustPython/RustPython/pull/9612/files#diff-e7f7c10b81f88d7af77af76257284e18e72ed9da63ff63675a9e9cb31c8d262d
View file https://github.com/youknowdot/RustPython/blob/53da77da6702586b3f8bed7ce26e382530c3bcdc/crates/vm/src/stdlib/sys.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9612/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9612/files#diff-e7f7c10b81f88d7af77af76257284e18e72ed9da63ff63675a9e9cb31c8d262d
https://github.com/RustPython/RustPython/pull/9612/files#diff-e7f7c10b81f88d7af77af76257284e18e72ed9da63ff63675a9e9cb31c8d262d
https://github.com/RustPython/RustPython/pull/9612/files#diff-e7f7c10b81f88d7af77af76257284e18e72ed9da63ff63675a9e9cb31c8d262d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9612/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.