René's URL Explorer Experiment


Title: Avoid locking across ctypes errcheck callbacks by youknowdot · Pull Request #9611 · RustPython/RustPython · GitHub

Open Graph Title: Avoid locking across ctypes errcheck callbacks by youknowdot · Pull Request #9611 · RustPython/RustPython

X Title: Avoid locking across ctypes errcheck callbacks by youknowdot · Pull Request #9611 · RustPython/RustPython

Description: Summary Clone the ctypes function's errcheck reference under its read lock and release the lock before invoking the callback. A callback can then replace function.errcheck without waiting on its own read lock. Release the write lock before dropping a replaced callback, so its finalizer can also re-enter the setter. Retain the callback snapshot through result and OUT-parameter processing. Scope This change does not address existing differences in when the snapshot is taken relative to the foreign call, assignment of None, or OUT-parameter handling after an errcheck override. Validation Confirmed the callback-replacement and finalizer-replacement behavior with CPython 3.15.0. Independent source review and normal commit hooks (including rustfmt) passed. RustPython was not built or executed locally. No tests were added or changed; hosted CI is expected to run the existing ctypes tests. Summary by CodeRabbit Bug Fixes Improved handling of custom error-check callbacks when processing results and changing the callback. Callback execution and replacement are less likely to interfere with one another, while invalid callback values continue to raise a type error. This makes custom error checking more reliable without changing the expected behavior for invalid values.

Open Graph Description: Summary Clone the ctypes function's errcheck reference under its read lock and release the lock before invoking the callback. A callback can then replace function.errcheck without waiting on i...

X Description: Summary Clone the ctypes function's errcheck reference under its read lock and release the lock before invoking the callback. A callback can then replace function.errcheck without waiting ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9611

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:21c84c4b-0789-2763-2863-79c25be88b74
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9B0:240CD1:350693E:4370574:6B01E40D
html-safe-nonce1e617e6fc57e1b9a4b1d12f2d0d92b94001a13bb8192b1d033689c592c900158
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUIwOjI0MENEMTozNTA2OTNFOjQzNzA1NzQ6NkIwMUU0MEQiLCJ2aXNpdG9yX2lkIjoiNTIxODkwNDY3Mjk4Nzk2NTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac493085740dbb0a8de86ab40d36430be99a34724d092bf3afcb18ea09f7f6d840
hovercard-subject-tagpull_request:5137384197
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9611/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Clone the ctypes function's errcheck reference under its read lock and release the lock before invoking the callback. A callback can then replace function.errcheck without waiting on i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9611/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9611%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9611%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9611/files
Reloadhttps://github.com/RustPython/RustPython/pull/9611/files
Reloadhttps://github.com/RustPython/RustPython/pull/9611/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/ctypes-errcheck-reentry-20261103https://github.com/youknowdot/RustPython/tree/fix/ctypes-errcheck-reentry-20261103
Conversation 4 https://github.com/RustPython/RustPython/pull/9611
Commits 3 https://github.com/RustPython/RustPython/pull/9611/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9611/checks
Files changed https://github.com/RustPython/RustPython/pull/9611/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9611/files
Avoid locking across ctypes errcheck callbacks https://github.com/RustPython/RustPython/pull/9611/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9611/files
d92f8c7 Avoid locking across ctypes errcheck callbacks youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9611/commits/d92f8c7434c57276efd7001bacb7b9cc45e18a09
bb82649 Preserve existing source comment after lock refactor youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9611/commits/bb82649bf0271ef1abcad93325abb9ef21d67501
49eda20 Use core for errcheck value replacement youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9611/commits/49eda20d6e8e5ebfddd17a6df19d4bffbfb43e1c
Clear filters https://github.com/RustPython/RustPython/pull/9611/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9611/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9611/files
crates/vm/src/stdlib/_ctypes/function.rshttps://github.com/RustPython/RustPython/pull/9611/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
View file https://github.com/youknowdot/RustPython/blob/49eda20d6e8e5ebfddd17a6df19d4bffbfb43e1c/crates/vm/src/stdlib/_ctypes/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9611/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9611/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 3, 2026https://github.com/RustPython/RustPython/pull/9611/files#r4459324912
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L165-L165https://github.com/RustPython/RustPython/blob/d92f8c7434c57276efd7001bacb7b9cc45e18a09/AGENTS.md#L165-L165
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9611/files
https://github.com/RustPython/RustPython/pull/9611/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
https://github.com/RustPython/RustPython/pull/9611/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
https://github.com/RustPython/RustPython/pull/9611/files#diff-d4cf72f95963a6d3e08f9e7e53594d6b5e2cc7711afbc0b490894d97dc8d8648
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9611/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.