René's URL Explorer Experiment


Title: Create base Elements from accelerator helpers by youknowdot · Pull Request #9598 · RustPython/RustPython · GitHub

Open Graph Title: Create base Elements from accelerator helpers by youknowdot · Pull Request #9598 · RustPython/RustPython

X Title: Create base Elements from accelerator helpers by youknowdot · Pull Request #9598 · RustPython/RustPython

Description: Summary Make the accelerator's inherited Element.makeelement, __copy__, __deepcopy__, and SubElement construct a base Element, including when called on or with an Element subclass. Keep normal Python dispatch for explicitly overridden methods and the existing attribute, child and memo handling. Verification and scope Compared all four paths with CPython 3.15.0 Modules/_elementtree.c, where create_new_element allocates the base Element type. Reproduced the result types for all four operations on a subclass using the verified CPython 3.15.0 runtime. Independent source review covered module type selection, subclass overrides, copy/deepcopy dispatch, children and memo handling. Normal commit hooks, rustfmt and git diff --check passed. File-level three-way merges with #9591 and #9594 were clean. No local RustPython build, runtime tests, workspace/C-API tests or clippy ran because the required coordinated native execution guard was unavailable. Hosted CI must validate the exact commit, including test_xml_etree; no tests were edited. This concerns the C-style _elementtree accelerator, not the pure-Python fallback, and does not claim complete Element subclass parity. AI assistance: OpenAI Codex assisted with implementation and source review. Summary by CodeRabbit Behavior Changes Elements created through makeelement, copying, deep copying, and SubElement now use the standard Element type. These operations no longer preserve a custom subclass from the original element or parent.

Open Graph Description: Summary Make the accelerator's inherited Element.makeelement, __copy__, __deepcopy__, and SubElement construct a base Element, including when called on or with an Element subclass. Keep normal...

X Description: Summary Make the accelerator's inherited Element.makeelement, __copy__, __deepcopy__, and SubElement construct a base Element, including when called on or with an Element subclass. Keep no...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9598

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:21630ea0-2b26-b7da-da63-dff120f02cc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id963A:317608:3DE95CB:4E5B11E:6B020874
html-safe-nonce7997300b5b427922f4915e8c0ca69924165f77b1f33b8bbcee4a557b6541f7f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjNBOjMxNzYwODozREU5NUNCOjRFNUIxMUU6NkIwMjA4NzQiLCJ2aXNpdG9yX2lkIjoiNTM5MzE0OTU5NDUzODQ3NzY4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac721bb23fbb1c2625f0aebf377db9c64253ccfad585e6fe20e15e645b93ae0b9b
hovercard-subject-tagpull_request:5137044926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9598/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Make the accelerator's inherited Element.makeelement, __copy__, __deepcopy__, and SubElement construct a base Element, including when called on or with an Element subclass. Keep normal...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9598/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9598%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9598%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9598/files
Reloadhttps://github.com/RustPython/RustPython/pull/9598/files
Reloadhttps://github.com/RustPython/RustPython/pull/9598/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/elementtree-created-element-type-20261103https://github.com/youknowdot/RustPython/tree/fix/elementtree-created-element-type-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9598
Commits 2 https://github.com/RustPython/RustPython/pull/9598/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9598/checks
Files changed https://github.com/RustPython/RustPython/pull/9598/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9598/files
Create base Elements from accelerator helpers https://github.com/RustPython/RustPython/pull/9598/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9598/files
5d88e1e Create base Elements from accelerator helpers youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9598/commits/5d88e1ee311e4795fe7c5b9fecf1e5355a85b4d0
168c49e Remove infallible Element creation result wrapper youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9598/commits/168c49efe6e65b81cb363adea75fef142a65ee30
Clear filters https://github.com/RustPython/RustPython/pull/9598/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9598/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9598/files
crates/stdlib/src/elementtree.rshttps://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
View file https://github.com/youknowdot/RustPython/blob/168c49efe6e65b81cb363adea75fef142a65ee30/crates/stdlib/src/elementtree.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9598/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9598/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9598/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.