René's URL Explorer Experiment


Title: Drop replaced frame traces outside locks by youknowdot · Pull Request #9596 · RustPython/RustPython · GitHub

Open Graph Title: Drop replaced frame traces outside locks by youknowdot · Pull Request #9596 · RustPython/RustPython

X Title: Drop replaced frame traces outside locks by youknowdot · Pull Request #9596 · RustPython/RustPython

Description: Summary Keep the old f_trace references alive until the materialized frame and any live source iframe have both been updated, line state has been synchronized, and both trace locks are released. A replaced trace object's finalizer can access frame.f_trace; dropping it while holding that mutex can otherwise deadlock. Validation Independently source-reviewed for aliased versus separate frame storage, the live iframe pointer lifetime, reentrant finalizer mutations, and CPython 3.15's publish-before-decref behavior. prek run --files crates/vm/src/builtins/frame.rs, normal commit hooks, and git diff --check passed. Native RustPython compilation and execution were not run locally; hosted CI is needed. Existing frame and tracing suites cover normal f_trace use, but no existing test identified directly exercises a replaced trace finalizer reentering the setter/getter. Scope This is a narrow lifetime and deadlock fix. It does not claim general cross-thread frame synchronization or atomicity across the two trace-storage updates. No Lib or test files were modified. Summary by CodeRabbit Bug Fixes Improved trace updates when replacing frame trace objects, helping keep materialized and live frames consistent.

Open Graph Description: Summary Keep the old f_trace references alive until the materialized frame and any live source iframe have both been updated, line state has been synchronized, and both trace locks are released. A ...

X Description: Summary Keep the old f_trace references alive until the materialized frame and any live source iframe have both been updated, line state has been synchronized, and both trace locks are released. A ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9596

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fd9092af-9d65-434f-8ff8-812fd3b0db33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F92:2AF0D8:444DDF:552A7C:6B01FDFE
html-safe-nonce1065f5b0a7089c5ea80d1340122601c6204138487bd111b9a6690b7708bbff68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjkyOjJBRjBEODo0NDREREY6NTUyQTdDOjZCMDFGREZFIiwidmlzaXRvcl9pZCI6IjYwODExMTA2NDg0ODg1OTA4NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca26c335d19538a34c07317f7be2c73d5fb65f82996bcfc62daef2e6fe7520094
hovercard-subject-tagpull_request:5137028393
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9596/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Keep the old f_trace references alive until the materialized frame and any live source iframe have both been updated, line state has been synchronized, and both trace locks are released. A ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9596/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9596%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9596%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9596/files
Reloadhttps://github.com/RustPython/RustPython/pull/9596/files
Reloadhttps://github.com/RustPython/RustPython/pull/9596/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/frame-trace-release-lock-20261103https://github.com/youknowdot/RustPython/tree/fix/frame-trace-release-lock-20261103
Conversation 4 https://github.com/RustPython/RustPython/pull/9596
Commits 2 https://github.com/RustPython/RustPython/pull/9596/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9596/checks
Files changed https://github.com/RustPython/RustPython/pull/9596/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9596/files
Drop replaced frame traces outside locks https://github.com/RustPython/RustPython/pull/9596/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9596/files
5b9e572 Drop replaced frame traces outside locks youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9596/commits/5b9e5727a8cb9378c577ae5c6616847a6127bd5e
5fdcb67 Preserve existing source comment after lock refactor youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9596/commits/5fdcb6770159ba937f5b7d767b1b6b258de91a02
Clear filters https://github.com/RustPython/RustPython/pull/9596/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9596/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9596/files
crates/vm/src/builtins/frame.rshttps://github.com/RustPython/RustPython/pull/9596/files#diff-09150c655df9106b20586b7dfade4f95653d7511e9685ae55442be6c76219d13
View file https://github.com/youknowdot/RustPython/blob/5fdcb6770159ba937f5b7d767b1b6b258de91a02/crates/vm/src/builtins/frame.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9596/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9596/files#diff-09150c655df9106b20586b7dfade4f95653d7511e9685ae55442be6c76219d13
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 3, 2026https://github.com/RustPython/RustPython/pull/9596/files#r4459198269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L165-L165https://github.com/RustPython/RustPython/blob/5b9e5727a8cb9378c577ae5c6616847a6127bd5e/AGENTS.md#L165-L165
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9596/files
https://github.com/RustPython/RustPython/pull/9596/files#diff-09150c655df9106b20586b7dfade4f95653d7511e9685ae55442be6c76219d13
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9596/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.