René's URL Explorer Experiment


Title: Preserve valid prefix when extending Element by youknowdot · Pull Request #9594 · RustPython/RustPython · GitHub

Open Graph Title: Preserve valid prefix when extending Element by youknowdot · Pull Request #9594 · RustPython/RustPython

X Title: Preserve valid prefix when extending Element by youknowdot · Pull Request #9594 · RustPython/RustPython

Description: Summary Preserve earlier valid children when Element.extend encounters an invalid later item, as CPython does. Materialize the input before mutating the element, preserving existing behavior for self-extension and iterators that raise. Keep the one-lock bulk path for valid inputs. Verification and scope Compared with CPython 3.15.0 Modules/_elementtree.c. Reproduced the retained valid prefix and TypeError on the verified CPython 3.15.0 runtime with both list and iterator inputs. Independent source review covered materialization, valid-prefix ordering, lock and object lifetimes, concurrent type changes, and the successful-input fast path. Normal commit hooks, rustfmt and git diff --check passed. A file-level three-way merge with #9591 was clean. No local RustPython build, interpreter tests, workspace/C-API tests or clippy ran because the required coordinated native execution guard was unavailable. Hosted CI must validate the exact commit, including test_xml_etree; no tests were edited. Existing differences between iterable conversion and CPython's PySequence_Fast, including some error wording and length-hint behavior, remain outside this change. AI assistance: OpenAI Codex assisted with implementation and source review. Summary by CodeRabbit Bug Fixes Extending an element now appends valid items encountered before the first invalid item. The operation still raises a TypeError for that invalid item, but earlier valid additions are no longer discarded.

Open Graph Description: Summary Preserve earlier valid children when Element.extend encounters an invalid later item, as CPython does. Materialize the input before mutating the element, preserving existing behavior for s...

X Description: Summary Preserve earlier valid children when Element.extend encounters an invalid later item, as CPython does. Materialize the input before mutating the element, preserving existing behavior for s...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9594

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0541bd69-b067-60e5-ed29-ed4434cab3e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE5C:ADA9D:3DD8B0B:4F42DA4:6B02087F
html-safe-nonce66297cccf6293942bce5853129f73ddd7c85d30accbc9eda53749231b76a7012
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTVDOkFEQTlEOjNERDhCMEI6NEY0MkRBNDo2QjAyMDg3RiIsInZpc2l0b3JfaWQiOiIyOTI3NTc5MDc5NDU4ODE4MTc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac20714d95e4e7ee38ce0c67dbb4305afb5b0b156b3f0e6f47250145167c6bfe7d
hovercard-subject-tagpull_request:5136980654
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9594/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Preserve earlier valid children when Element.extend encounters an invalid later item, as CPython does. Materialize the input before mutating the element, preserving existing behavior for s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9594/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9594%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9594%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9594/files
Reloadhttps://github.com/RustPython/RustPython/pull/9594/files
Reloadhttps://github.com/RustPython/RustPython/pull/9594/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/elementtree-extend-partial-20261103https://github.com/youknowdot/RustPython/tree/fix/elementtree-extend-partial-20261103
Conversation 2 https://github.com/RustPython/RustPython/pull/9594
Commits 2 https://github.com/RustPython/RustPython/pull/9594/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9594/checks
Files changed https://github.com/RustPython/RustPython/pull/9594/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9594/files
Preserve valid prefix when extending Element https://github.com/RustPython/RustPython/pull/9594/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9594/files
45cbd7d Preserve valid prefix when extending Element youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9594/commits/45cbd7dd758a3c47318177063d3aa02a14084aa7
e461c82 Use Self in Element extend validation youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9594/commits/e461c82e7e12102bdfc592b17fc09c3cb170b1a7
Clear filters https://github.com/RustPython/RustPython/pull/9594/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9594/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9594/files
crates/stdlib/src/elementtree.rshttps://github.com/RustPython/RustPython/pull/9594/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
View file https://github.com/youknowdot/RustPython/blob/e461c82e7e12102bdfc592b17fc09c3cb170b1a7/crates/stdlib/src/elementtree.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9594/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9594/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9594/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9594/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.