René's URL Explorer Experiment


Title: Audit winreg key queries before OS calls by youknowdot · Pull Request #9593 · RustPython/RustPython · GitHub

Open Graph Title: Audit winreg key queries before OS calls by youknowdot · Pull Request #9593 · RustPython/RustPython

X Title: Audit winreg key queries before OS calls by youknowdot · Pull Request #9593 · RustPython/RustPython

Description: Summary Emit CPython's winreg.QueryInfoKey and winreg.QueryValue audit events after argument conversion and before registry operations. For QueryValue, convert the required str | None subkey through UTF-16 before auditing and before the performance-data check, preserving lone surrogates and rejecting trailing or embedded NULs. Reconstruct the audit payload from UTF-16 as CPython does. Audit tuple/name objects are created only if audit hooks are active. This does not address all winreg audit events or claim complete parity. Generic invalid-subkey type-error wording remains outside this change. The current-main reconciliation preserves the newer surrogate-safe PyStr return alongside the reviewed Wtf8Buf input and audit order. #9586 separately fixes the HKEY converter; #9589 addresses QueryValueEx. Validation Independently source-reviewed against CPython v3.15.0 PC/winreg.c and its generated Clinic code, including event arguments and conversion order. prek hooks and git diff --check passed. The current-main conflict resolution passed independent source review, focused host-env/VM/stdlib Linux threading cargo check, normal all-targets Clippy, and ordinary hooks. Clippy diagnostics match four unchanged-main warnings; none were suppressed. These Linux checks do not type-check or execute the Windows-only registry code. Native RustPython execution and full workspace/C-API runtime suites were not run; hosted Windows CI remains required.

Open Graph Description: Summary Emit CPython's winreg.QueryInfoKey and winreg.QueryValue audit events after argument conversion and before registry operations. For QueryValue, convert the required str | None subkey t...

X Description: Summary Emit CPython's winreg.QueryInfoKey and winreg.QueryValue audit events after argument conversion and before registry operations. For QueryValue, convert the required str | None subk...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9593

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b4046ab2-42c2-df6a-bfe4-09af529372df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9AA:4D9F2:1542669:1C3E43A:6B01FE19
html-safe-noncef7ba3912d6827cc1dc112e8a8fdd0145638402b4bed5d3e7d947410d4d0ee2ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUFBOjREOUYyOjE1NDI2Njk6MUMzRTQzQTo2QjAxRkUxOSIsInZpc2l0b3JfaWQiOiI3OTI1MDg2ODA3NTY0MzUzMDQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac23f4a6e136810334d46b9896224f068cf403e512a1d410473dddfecbe6721b78
hovercard-subject-tagpull_request:5136962993
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9593/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Emit CPython's winreg.QueryInfoKey and winreg.QueryValue audit events after argument conversion and before registry operations. For QueryValue, convert the required str | None subkey t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9593/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9593%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9593%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9593/files
Reloadhttps://github.com/RustPython/RustPython/pull/9593/files
Reloadhttps://github.com/RustPython/RustPython/pull/9593/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/winreg-query-audits-20261103https://github.com/youknowdot/RustPython/tree/fix/winreg-query-audits-20261103
Conversation 5 https://github.com/RustPython/RustPython/pull/9593
Commits 3 https://github.com/RustPython/RustPython/pull/9593/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9593/checks
Files changed https://github.com/RustPython/RustPython/pull/9593/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9593/files
Audit winreg key queries before OS calls https://github.com/RustPython/RustPython/pull/9593/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9593/files
5ca85e4 Audit winreg key queries before OS calls youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9593/commits/5ca85e40cb1cbaf14511789b152fbf6489ec7678
a169772 Accept owned WTF-8 strings in winreg QueryValue youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9593/commits/a169772904980b80d33da78ccc77e3ae43e9265b
bc92a27 Merge current main into registry audit fix youknowdot Nov 4, 2026 https://github.com/RustPython/RustPython/pull/9593/commits/bc92a273dea8af641f692a0bedcdfbc784f177c0
Clear filters https://github.com/RustPython/RustPython/pull/9593/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9593/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9593/files
str.rs https://github.com/RustPython/RustPython/pull/9593/files#diff-a04ea1f7734fe40189e756196e034e6dedfcd5c82f2925e58cfd51ba7432073a
winreg.rs https://github.com/RustPython/RustPython/pull/9593/files#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a
crates/vm/src/builtins/str.rshttps://github.com/RustPython/RustPython/pull/9593/files#diff-a04ea1f7734fe40189e756196e034e6dedfcd5c82f2925e58cfd51ba7432073a
View file https://github.com/youknowdot/RustPython/blob/bc92a273dea8af641f692a0bedcdfbc784f177c0/crates/vm/src/builtins/str.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9593/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9593/files#diff-a04ea1f7734fe40189e756196e034e6dedfcd5c82f2925e58cfd51ba7432073a
https://github.com/RustPython/RustPython/pull/9593/files#diff-a04ea1f7734fe40189e756196e034e6dedfcd5c82f2925e58cfd51ba7432073a
crates/vm/src/stdlib/winreg.rshttps://github.com/RustPython/RustPython/pull/9593/files#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a
View file https://github.com/youknowdot/RustPython/blob/bc92a273dea8af641f692a0bedcdfbc784f177c0/crates/vm/src/stdlib/winreg.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9593/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9593/files#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a
https://github.com/RustPython/RustPython/pull/9593/files#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a
https://github.com/RustPython/RustPython/pull/9593/files#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9593/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.