| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:12b58f31-3d65-ee51-904f-dd53dd3b18bc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E758:26ECEB:3C5AADF:4CB77F9:6B01F3FA |
| html-safe-nonce | cb318943ee15cf57777337b8a61b28f751a5bf09432c5d129f7aef6139390006 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzU4OjI2RUNFQjozQzVBQURGOjRDQjc3Rjk6NkIwMUYzRkEiLCJ2aXNpdG9yX2lkIjoiNDQ2Nzg3MTQxOTcyNzk5OTk5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 095e316aed967cafd550cd452eb69fbfd94d4791246072217c0b480c6aa83964 |
| hovercard-subject-tag | pull_request:5136962993 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/9593/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/af0b0d4e6e1f0936ed6776d1d09aad2fe97083504932f8ff6c27478ff3acba73/RustPython/RustPython/pull/9593 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/af0b0d4e6e1f0936ed6776d1d09aad2fe97083504932f8ff6c27478ff3acba73/RustPython/RustPython/pull/9593 |
| og:image:alt | Summary
Emit CPython's winreg.QueryInfoKey and winreg.QueryValue audit events after argument conversion and before registry operations.
For QueryValue, convert the required str | None subkey t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowdot |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/9593#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9593 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9593 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/9593 |
| Reload | https://github.com/RustPython/RustPython/pull/9593 |
| Reload | https://github.com/RustPython/RustPython/pull/9593 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests133 (133) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowdot:fix/winreg-query-audits-20261103 | https://github.com/youknowdot/RustPython/tree/fix/winreg-query-audits-20261103 |
| Conversation | https://github.com/RustPython/RustPython/pull/9593 |
| Commits3 (3) | https://github.com/RustPython/RustPython/pull/9593/commits |
| Checks | https://github.com/RustPython/RustPython/pull/9593/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/9593/files |
| Audit winreg key queries before OS calls | https://github.com/RustPython/RustPython/pull/9593#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowdot:fix/winreg-query-audits-20261103 | https://github.com/youknowdot/RustPython/tree/fix/winreg-query-audits-20261103 |
|
| https://github.com/youknowdot |
| youknowdot | https://github.com/youknowdot |
| Nov 3, 2026 | https://github.com/RustPython/RustPython/pull/9593#issue-6182269049 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| #9586 | https://github.com/RustPython/RustPython/pull/9586 |
| #9589 | https://github.com/RustPython/RustPython/pull/9589 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
|
| https://github.com/youknowdot |
| Audit winreg key queries before OS calls | https://github.com/RustPython/RustPython/pull/9593/commits/5ca85e40cb1cbaf14511789b152fbf6489ec7678 |
| 5ca85e4 | https://github.com/RustPython/RustPython/pull/9593/commits/5ca85e40cb1cbaf14511789b152fbf6489ec7678 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Nov 3, 2026 | https://github.com/RustPython/RustPython/pull/9593#issuecomment-6603401089 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| https://app.coderabbit.ai/change-stack/RustPython/RustPython/pull/9593?scope=ghh_OusAJGA4HG8ljoOV0wJvVx8NmnZIjc2DdjmxOu0xZWA&cs_source=review_comment |
| CodeRabbit | https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=RustPython/RustPython&utm_content=9593 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| https://github.com/youknowdot |
| youknowdot | https://github.com/youknowdot |
|
Nov 3, 2026
| https://github.com/RustPython/RustPython/pull/9593#ref-pullrequest-6182457814 |
|
Preserve surrogates in winreg QueryValue results
#9602
| https://github.com/RustPython/RustPython/pull/9602 |
| https://github.com/apps/codspeed |
| codspeed | https://github.com/apps/codspeed |
| Nov 3, 2026 | https://github.com/RustPython/RustPython/pull/9593#issuecomment-6608190247 |
| 1 | https://github.com/RustPython/RustPython/pull/9593#user-content-fn-skipped-1f6a724279d2baea979aaa6dea67d470 |
| 5ca85e4 | https://github.com/RustPython/RustPython/commit/5ca85e40cb1cbaf14511789b152fbf6489ec7678 |
| 18fc82b | https://github.com/RustPython/RustPython/commit/18fc82bc6327e9a4f5e5bbdcbecb5c65c29ce95f |
|
| https://app.codspeed.io/RustPython/RustPython/branches/youknowdot%3Afix%2Fwinreg-query-audits-20261103?utm_source=github&utm_medium=comment-v2&utm_content=button |
| click here and archive them to remove them from the performance reports | https://app.codspeed.io/RustPython/RustPython/branches/youknowdot%3Afix%2Fwinreg-query-audits-20261103?q=is%3Askipped&utm_source=github&utm_medium=comment-v2&utm_content=archive |
| ↩ | https://github.com/RustPython/RustPython/pull/9593#user-content-fnref-skipped-1f6a724279d2baea979aaa6dea67d470 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Nov 3, 2026
| https://github.com/RustPython/RustPython/pull/9593#pullrequestreview-5757872798 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/9593/files/5ca85e40cb1cbaf14511789b152fbf6489ec7678 |
| crates/vm/src/stdlib/winreg.rs | https://github.com/RustPython/RustPython/pull/9593/files/5ca85e40cb1cbaf14511789b152fbf6489ec7678#diff-fbbcd38a6f03e74ddc021462a194790feb35e14066e7f17daa92069683a4848a |
| youknowone | https://github.com/youknowone |
| Nov 3, 2026 | https://github.com/RustPython/RustPython/pull/9593#discussion_r4459141259 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| youknowdot | https://github.com/youknowdot |
| November 4, 2026 05:04 | https://github.com/RustPython/RustPython/pull/9593#commits-pushed-a169772 |
|
| https://github.com/youknowdot |
| Accept owned WTF-8 strings in winreg QueryValue | https://github.com/RustPython/RustPython/pull/9593/commits/a169772904980b80d33da78ccc77e3ae43e9265b |
| a169772 | https://github.com/RustPython/RustPython/pull/9593/commits/a169772904980b80d33da78ccc77e3ae43e9265b |
|
| https://github.com/youknowdot |
| Merge current main into registry audit fix | https://github.com/RustPython/RustPython/pull/9593/commits/bc92a273dea8af641f692a0bedcdfbc784f177c0 |
| bc92a27 | https://github.com/RustPython/RustPython/pull/9593/commits/bc92a273dea8af641f692a0bedcdfbc784f177c0 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Nov 5, 2026
| https://github.com/RustPython/RustPython/pull/9593#pullrequestreview-5786419847 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/9593/files/bc92a273dea8af641f692a0bedcdfbc784f177c0 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| November 5, 2026 14:22 | https://github.com/RustPython/RustPython/pull/9593#event-35250374001 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 2319229 | https://github.com/RustPython/RustPython/commit/231922928c4cb4cae0ba33229f05b07b9ba4d90a |
| Nov 5, 2026 | https://github.com/RustPython/RustPython/pull/9593#event-35250385410 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Nov 5, 2026 | https://github.com/RustPython/RustPython/pull/9593#issuecomment-6660389180 |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Nov 5, 2026 | https://github.com/RustPython/RustPython/pull/9593#issuecomment-6660390345 |
| Codex usage dashboard | https://chatgpt.com/codex/cloud/settings/usage |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9593 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/9593/files/bc92a273dea8af641f692a0bedcdfbc784f177c0 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/9593 |
|
| https://github.com/youknowdot |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |