Title: Validate Element setstate input type by youknowdot · Pull Request #9591 · RustPython/RustPython · GitHub
Open Graph Title: Validate Element setstate input type by youknowdot · Pull Request #9591 · RustPython/RustPython
X Title: Validate Element setstate input type by youknowdot · Pull Request #9591 · RustPython/RustPython
Description: Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an invalid state's __repr__ and limit the diagnostic to the first 200 Unicode code points, preserving surrogate code points without building a full character index. Verification and scope Compared against CPython 3.15.0 Modules/_elementtree.c. Reproduced dict-subclass rejection, propagation of a raising __repr__, unchanged element state, and truncation including a lone surrogate on the verified CPython 3.15.0 runtime. Independent source review covered exact type checking, error propagation, WTF-8 boundaries and state mutation. Normal commit hooks, rustfmt and git diff --check passed. No local RustPython build, interpreter tests, workspace/C-API tests or clippy ran because the required coordinated native execution guard was unavailable. Hosted CI must validate this exact commit; no test files were edited. This only changes input type and diagnostic handling. Existing differences in validation and application of exact-dict contents, including unexpected keys, remain out of scope. AI assistance: OpenAI Codex assisted with implementation and source review. Summary by CodeRabbit Bug Fixes XML parser state restoration now accepts only an exact dictionary; other values, including dictionary subclasses, raise a TypeError. Error messages for invalid state include a representation limited to 200 Unicode code points, keeping them concise even when the supplied value has a lengthy representation.
Open Graph Description: Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an invalid ...
X Description: Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an inva...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9591
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:daf67767-748c-e5cc-53a2-674c256190c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C69C:187C1E:17AF3CE:1F3DC47:6B02086E |
| html-safe-nonce | 26afd64958d2388ec1c1a4f691263b33b3259b6581e9c088a8617bfb8aa77abb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjlDOjE4N0MxRToxN0FGM0NFOjFGM0RDNDc6NkIwMjA4NkUiLCJ2aXNpdG9yX2lkIjoiNjk3NTc0Mjg0NDM2NzY2OTM1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b96402060b8d02baed20a8ca2745705a2f57f0d2302774eeb59e8e3f33af0d9c |
| hovercard-subject-tag | pull_request:5136915714 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9591/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an invalid ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width