René's URL Explorer Experiment


Title: Validate Element setstate input type by youknowdot · Pull Request #9591 · RustPython/RustPython · GitHub

Open Graph Title: Validate Element setstate input type by youknowdot · Pull Request #9591 · RustPython/RustPython

X Title: Validate Element setstate input type by youknowdot · Pull Request #9591 · RustPython/RustPython

Description: Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an invalid state's __repr__ and limit the diagnostic to the first 200 Unicode code points, preserving surrogate code points without building a full character index. Verification and scope Compared against CPython 3.15.0 Modules/_elementtree.c. Reproduced dict-subclass rejection, propagation of a raising __repr__, unchanged element state, and truncation including a lone surrogate on the verified CPython 3.15.0 runtime. Independent source review covered exact type checking, error propagation, WTF-8 boundaries and state mutation. Normal commit hooks, rustfmt and git diff --check passed. No local RustPython build, interpreter tests, workspace/C-API tests or clippy ran because the required coordinated native execution guard was unavailable. Hosted CI must validate this exact commit; no test files were edited. This only changes input type and diagnostic handling. Existing differences in validation and application of exact-dict contents, including unexpected keys, remain out of scope. AI assistance: OpenAI Codex assisted with implementation and source review. Summary by CodeRabbit Bug Fixes XML parser state restoration now accepts only an exact dictionary; other values, including dictionary subclasses, raise a TypeError. Error messages for invalid state include a representation limited to 200 Unicode code points, keeping them concise even when the supplied value has a lengthy representation.

Open Graph Description: Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an invalid ...

X Description: Summary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an inva...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9591

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:daf67767-748c-e5cc-53a2-674c256190c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC69C:187C1E:17AF3CE:1F3DC47:6B02086E
html-safe-nonce26afd64958d2388ec1c1a4f691263b33b3259b6581e9c088a8617bfb8aa77abb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjlDOjE4N0MxRToxN0FGM0NFOjFGM0RDNDc6NkIwMjA4NkUiLCJ2aXNpdG9yX2lkIjoiNjk3NTc0Mjg0NDM2NzY2OTM1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb96402060b8d02baed20a8ca2745705a2f57f0d2302774eeb59e8e3f33af0d9c
hovercard-subject-tagpull_request:5136915714
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9591/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Require an exact dict for _elementtree.Element.__setstate__, matching CPython's accelerator; reject dict subclasses before modifying the element. Propagate errors raised by an invalid ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9591/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9591%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9591%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9591/files
Reloadhttps://github.com/RustPython/RustPython/pull/9591/files
Reloadhttps://github.com/RustPython/RustPython/pull/9591/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/elementtree-setstate-type-20261103https://github.com/youknowdot/RustPython/tree/fix/elementtree-setstate-type-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9591
Commits 2 https://github.com/RustPython/RustPython/pull/9591/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9591/checks
Files changed https://github.com/RustPython/RustPython/pull/9591/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9591/files
Validate Element setstate input type https://github.com/RustPython/RustPython/pull/9591/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9591/files
9374322 Validate Element setstate input type youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9591/commits/9374322e793df733de5776c9754fe30074621b5d
5b4f84c Compute Element state diagnostic bound lazily youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9591/commits/5b4f84c300f58b334cf13b669e49a8cbb1c5d7f6
Clear filters https://github.com/RustPython/RustPython/pull/9591/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9591/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9591/files
crates/stdlib/src/elementtree.rshttps://github.com/RustPython/RustPython/pull/9591/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
View file https://github.com/youknowdot/RustPython/blob/5b4f84c300f58b334cf13b669e49a8cbb1c5d7f6/crates/stdlib/src/elementtree.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9591/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9591/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9591/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9591/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
https://github.com/RustPython/RustPython/pull/9591/files#diff-12e3ee061fcf107011823a4f5e3d07ed2c3b4328009cf508345e347624e826b6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9591/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.