René's URL Explorer Experiment


Title: Release PickleBuffer outside its lock by youknowdot · Pull Request #9587 · RustPython/RustPython · GitHub

Open Graph Title: Release PickleBuffer outside its lock by youknowdot · Pull Request #9587 · RustPython/RustPython

X Title: Release PickleBuffer outside its lock by youknowdot · Pull Request #9587 · RustPython/RustPython

Description: Summary Detach the owned PyBuffer while holding the PickleBuffer write lock, then drop it after releasing the lock. Dropping its final share can invoke a Python __release_buffer__ hook; a hook that reenters the same PickleBuffer would otherwise try to acquire the held lock and deadlock. Existing shares cloned before release remain alive, and a concurrent access after the take observes the released state. The change does not address the separate PickleBuffer GC-traversal expected failure. Behavior difference This is a narrow deadlock fix, not exact CPython callback-state parity. CPython 3.15's PyBuffer_Release invokes the exporter hook before clearing view.obj. This change publishes the released state first, so a reentrant raw() or buffer acquisition observes a released PickleBuffer and another release() is inert. Reconstructing a usable acquisition during the callback is not known to be safe with RustPython's final-share release latch and would need separate ownership work. Validation Independently source-reviewed for last-share release, reentrancy, and concurrent get/release ordering. prek run --files crates/stdlib/src/pickle.rs, normal commit hooks and git diff --check passed. Native RustPython compilation and execution were not run locally; hosted CI is required. Existing test_picklebuffer.test_release covers basic release and idempotency, but no existing test identified directly exercises release-hook reentrancy. That behavior remains an execution-coverage gap. Summary by CodeRabbit Bug Fixes Buffer release now completes its state update before cleanup callbacks run, helping avoid interference between buffer cleanup and other operations. The buffer is marked as released before its final cleanup, so subsequent operations can observe the updated state even while cleanup is in progress.

Open Graph Description: Summary Detach the owned PyBuffer while holding the PickleBuffer write lock, then drop it after releasing the lock. Dropping its final share can invoke a Python __release_buffer__ hook; a hook that...

X Description: Summary Detach the owned PyBuffer while holding the PickleBuffer write lock, then drop it after releasing the lock. Dropping its final share can invoke a Python __release_buffer__ hook; a hook that...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9587

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cd4e8eff-fb6d-2068-b6dc-0b5e2b599594
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA26:3CBB3E:2C8D84D:38E69B7:6B01F9A3
html-safe-noncedb308297e1bc3d13508e78f68e42c8dc8feb931771add32f840b204d9875c3c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTI2OjNDQkIzRToyQzhEODREOjM4RTY5Qjc6NkIwMUY5QTMiLCJ2aXNpdG9yX2lkIjoiNzM2MTAxMzE0MDM3NDU1MDk0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca0d331fe2af2c466d3d39237cabbfd92234483783e14c30f7372bb9cb2e56baf
hovercard-subject-tagpull_request:5136781450
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9587/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Detach the owned PyBuffer while holding the PickleBuffer write lock, then drop it after releasing the lock. Dropping its final share can invoke a Python __release_buffer__ hook; a hook that...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9587/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9587%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9587%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9587/files
Reloadhttps://github.com/RustPython/RustPython/pull/9587/files
Reloadhttps://github.com/RustPython/RustPython/pull/9587/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/picklebuffer-release-reentry-20261103https://github.com/youknowdot/RustPython/tree/fix/picklebuffer-release-reentry-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9587
Commits 1 https://github.com/RustPython/RustPython/pull/9587/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9587/checks
Files changed https://github.com/RustPython/RustPython/pull/9587/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9587/files
Release PickleBuffer outside its lock https://github.com/RustPython/RustPython/pull/9587/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9587/files
ea3c48b Release PickleBuffer outside its lock youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9587/commits/ea3c48b104e3cd66dad8dc0eff6c984b9edf452d
Clear filters https://github.com/RustPython/RustPython/pull/9587/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9587/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9587/files
crates/stdlib/src/pickle.rshttps://github.com/RustPython/RustPython/pull/9587/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
View file https://github.com/youknowdot/RustPython/blob/ea3c48b104e3cd66dad8dc0eff6c984b9edf452d/crates/stdlib/src/pickle.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9587/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9587/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
https://github.com/RustPython/RustPython/pull/9587/files#diff-3029d63dd60cbab4abbf02b7ddea49000477dfb2399b94ec7d5c021428fbe641
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9587/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.