René's URL Explorer Experiment


Title: Fix integer-to-float overflow rounding boundary by youknowdot · Pull Request #9584 · RustPython/RustPython · GitHub

Open Graph Title: Fix integer-to-float overflow rounding boundary by youknowdot · Pull Request #9584 · RustPython/RustPython

X Title: Fix integer-to-float overflow rounding boundary by youknowdot · Pull Request #9584 · RustPython/RustPython

Description: Summary Keep the result of nearest rational-to-float rounding instead of converting every inexact maximum-finite result into infinity. A quotient just beyond the largest finite float should still round to it until the halfway overflow threshold. Apply the same boundary behavior to float(int): retain the existing fast conversion and retry only when malachite-bigint reports the inexact finite-extreme case as None. Both signs and the midpoint-to-infinity case follow the pinned malachite implementation's ties-to-even rounding. The VM's existing infinity-to-OverflowError conversion remains in place. Validation Independently source-reviewed against CPython 3.15 long_true_divide, integer-to-double conversion, and the pinned malachite 0.14.0 implementations. In particular, the dependency implementation was checked rather than relying on its description of overflow. Normal commit hooks, prek run --files crates/common/src/int.rs, and git diff --check passed. Native RustPython compilation and tests were not run locally. On the prior exact head, hosted Linux, macOS and Windows each reported LongTest.test_float_conversion as an unexpected success in both the initial run and rerun. The update_lib auto-mark function removed only that expected-failure decorator; the IEEE guard and assertions are unchanged. New-head CI remains pending. Other expected-failure markers are unchanged. Scope #8624 independently handles the negative-zero result for zero divided by a negative integer in the same function. Both fixes need to be preserved and tested when the branches are combined. The only Lib change is the verified expected-failure marker removal described above. Summary by CodeRabbit Bug Fixes Improved rounding for rational results and conversion of large integers to finite floating-point values.

Open Graph Description: Summary Keep the result of nearest rational-to-float rounding instead of converting every inexact maximum-finite result into infinity. A quotient just beyond the largest finite float should still ...

X Description: Summary Keep the result of nearest rational-to-float rounding instead of converting every inexact maximum-finite result into infinity. A quotient just beyond the largest finite float should still ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9584

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b507d924-b058-3fc2-8af3-e8bc64b4d40d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9286:299992:155DD56:1C3A50F:6B01F9D4
html-safe-noncef5bb8987939e079b457d9e4fc43b49e61291ac18526dfa2e5844149e434482a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mjg2OjI5OTk5MjoxNTVERDU2OjFDM0E1MEY6NkIwMUY5RDQiLCJ2aXNpdG9yX2lkIjoiMzgxMDEzMjIzODE2MzYzODc0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb71b4e0e112e5c58044fb89646d731a1cf9d7639df525dc7d99d8831d53a20ef
hovercard-subject-tagpull_request:5136716577
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9584/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Keep the result of nearest rational-to-float rounding instead of converting every inexact maximum-finite result into infinity. A quotient just beyond the largest finite float should still ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9584/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9584%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9584%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9584/files
Reloadhttps://github.com/RustPython/RustPython/pull/9584/files
Reloadhttps://github.com/RustPython/RustPython/pull/9584/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/int-float-rounding-20261103https://github.com/youknowdot/RustPython/tree/fix/int-float-rounding-20261103
Conversation 3 https://github.com/RustPython/RustPython/pull/9584
Commits 2 https://github.com/RustPython/RustPython/pull/9584/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9584/checks
Files changed https://github.com/RustPython/RustPython/pull/9584/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9584/files
Fix integer-to-float overflow rounding boundary https://github.com/RustPython/RustPython/pull/9584/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9584/files
dea6c93 Fix integer-to-float overflow rounding boundary youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9584/commits/dea6c93a0b64be8bd423ff5b4e567d6910835503
4fd589a Retire passing float conversion expected failure youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9584/commits/4fd589aa40b5e3160284e3a9902d9a5f97418809
Clear filters https://github.com/RustPython/RustPython/pull/9584/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9584/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9584/files
test_long.py https://github.com/RustPython/RustPython/pull/9584/files#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
int.rs https://github.com/RustPython/RustPython/pull/9584/files#diff-9c2c3b9ee2961279f43d15412c69ccdd28d05d8e64db8f6e6d71a0a2b51959fb
Lib/test/test_long.pyhttps://github.com/RustPython/RustPython/pull/9584/files#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
View file https://github.com/youknowdot/RustPython/blob/4fd589aa40b5e3160284e3a9902d9a5f97418809/Lib/test/test_long.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9584/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9584/files#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
https://github.com/RustPython/RustPython/pull/9584/files#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
crates/common/src/int.rshttps://github.com/RustPython/RustPython/pull/9584/files#diff-9c2c3b9ee2961279f43d15412c69ccdd28d05d8e64db8f6e6d71a0a2b51959fb
View file https://github.com/youknowdot/RustPython/blob/4fd589aa40b5e3160284e3a9902d9a5f97418809/crates/common/src/int.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9584/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9584/files#diff-9c2c3b9ee2961279f43d15412c69ccdd28d05d8e64db8f6e6d71a0a2b51959fb
https://github.com/RustPython/RustPython/pull/9584/files#diff-9c2c3b9ee2961279f43d15412c69ccdd28d05d8e64db8f6e6d71a0a2b51959fb
https://github.com/RustPython/RustPython/pull/9584/files#diff-9c2c3b9ee2961279f43d15412c69ccdd28d05d8e64db8f6e6d71a0a2b51959fb
https://github.com/RustPython/RustPython/pull/9584/files#diff-9c2c3b9ee2961279f43d15412c69ccdd28d05d8e64db8f6e6d71a0a2b51959fb
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9584/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.