Title: Accept fd as a keyword in epoll.unregister by youknowdot · Pull Request #9553 · RustPython/RustPython · GitHub
Open Graph Title: Accept fd as a keyword in epoll.unregister by youknowdot · Pull Request #9553 · RustPython/RustPython
X Title: Accept fd as a keyword in epoll.unregister by youknowdot · Pull Request #9553 · RustPython/RustPython
Description: Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind the raw argument before converting it with the existing Fildes converter. Invalid argument shapes therefore cannot invoke fileno(). Descriptor conversion, the epoll-open check, and the existing host delete operation retain their order; no descriptor ownership changes are introduced. The PR-added metadata test was removed as requested in review; signature coverage will be handled by the text_signature tests. No Lib tests, workflow, or other epoll methods are changed. Reference CPython 3.15.0 Modules/clinic/selectmodule.c.h lines 911–960 accepts keywords and unpacks arguments before converting the file descriptor. Validation Independent source review, normal commit hooks, and git diff --check passed. On revision 9d1eddc367bb, workspace and C-API tests/clippy plus test_epoll were attempted offline; all stopped before compilation because the configured parking_lot_core revision is unavailable locally. Normal commit hooks and independent review passed for the metadata-test removal. Existing canonical test_epoll coverage uses positional unregister calls; it does not establish the new fd= behavior or invalid-shape callback behavior by execution. Existing CI and its --signature report should confirm this one item on the new head. The historical 127-item baseline is not an integrated-main baseline for this PR. This does not fix epoll.modify, the separately invalid CPython comparison for epoll.register, or all binder diagnostic wording. Draft pending CI validation. Summary by CodeRabbit Bug Fixes Unregister requests now validate the argument’s shape before converting it to a file descriptor. Invalid argument shapes are therefore handled before the event polling instance is accessed or a registration is removed, providing more consistent error handling for malformed requests.
Open Graph Description: Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind th...
X Description: Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind th...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9553
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:89a6189b-c769-fdf0-c3bc-2ea90d4daf22 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA6A:1EFF:99FFAE:CCFE10:6B01FF63 |
| html-safe-nonce | 5ec482322deae6ba44a772b95c39eab88e2c9269ff27b95e0fbd8e4b964f110e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTZBOjFFRkY6OTlGRkFFOkNDRkUxMDo2QjAxRkY2MyIsInZpc2l0b3JfaWQiOiIyOTg1Nzg1OTMyMjQ4MTIxMTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7d037ee0da3b8a334a0f714e0aec1a345bfc2652b3658b701994ae4da4542089 |
| hovercard-subject-tag | pull_request:5124663689 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9553/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width