René's URL Explorer Experiment


Title: Accept fd as a keyword in epoll.unregister by youknowdot · Pull Request #9553 · RustPython/RustPython · GitHub

Open Graph Title: Accept fd as a keyword in epoll.unregister by youknowdot · Pull Request #9553 · RustPython/RustPython

X Title: Accept fd as a keyword in epoll.unregister by youknowdot · Pull Request #9553 · RustPython/RustPython

Description: Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind the raw argument before converting it with the existing Fildes converter. Invalid argument shapes therefore cannot invoke fileno(). Descriptor conversion, the epoll-open check, and the existing host delete operation retain their order; no descriptor ownership changes are introduced. The PR-added metadata test was removed as requested in review; signature coverage will be handled by the text_signature tests. No Lib tests, workflow, or other epoll methods are changed. Reference CPython 3.15.0 Modules/clinic/selectmodule.c.h lines 911–960 accepts keywords and unpacks arguments before converting the file descriptor. Validation Independent source review, normal commit hooks, and git diff --check passed. On revision 9d1eddc367bb, workspace and C-API tests/clippy plus test_epoll were attempted offline; all stopped before compilation because the configured parking_lot_core revision is unavailable locally. Normal commit hooks and independent review passed for the metadata-test removal. Existing canonical test_epoll coverage uses positional unregister calls; it does not establish the new fd= behavior or invalid-shape callback behavior by execution. Existing CI and its --signature report should confirm this one item on the new head. The historical 127-item baseline is not an integrated-main baseline for this PR. This does not fix epoll.modify, the separately invalid CPython comparison for epoll.register, or all binder diagnostic wording. Draft pending CI validation. Summary by CodeRabbit Bug Fixes Unregister requests now validate the argument’s shape before converting it to a file descriptor. Invalid argument shapes are therefore handled before the event polling instance is accessed or a registration is removed, providing more consistent error handling for malformed requests.

Open Graph Description: Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind th...

X Description: Summary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind th...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9553

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:89a6189b-c769-fdf0-c3bc-2ea90d4daf22
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA6A:1EFF:99FFAE:CCFE10:6B01FF63
html-safe-nonce5ec482322deae6ba44a772b95c39eab88e2c9269ff27b95e0fbd8e4b964f110e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTZBOjFFRkY6OTlGRkFFOkNDRkUxMDo2QjAxRkY2MyIsInZpc2l0b3JfaWQiOiIyOTg1Nzg1OTMyMjQ4MTIxMTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7d037ee0da3b8a334a0f714e0aec1a345bfc2652b3658b701994ae4da4542089
hovercard-subject-tagpull_request:5124663689
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9553/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Accept fd as a positional or keyword argument to select.epoll.unregister, matching CPython 3.15.0. This addresses the observed (self, fd, /) versus (self, /, fd) signature mismatch. Bind th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9553/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9553%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9553%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9553/files
Reloadhttps://github.com/RustPython/RustPython/pull/9553/files
Reloadhttps://github.com/RustPython/RustPython/pull/9553/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/epoll-unregister-keyword-20261102https://github.com/youknowdot/RustPython/tree/fix/epoll-unregister-keyword-20261102
Conversation 7 https://github.com/RustPython/RustPython/pull/9553
Commits 3 https://github.com/RustPython/RustPython/pull/9553/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9553/checks
Files changed https://github.com/RustPython/RustPython/pull/9553/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9553/files
Accept fd as a keyword in epoll.unregister https://github.com/RustPython/RustPython/pull/9553/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9553/files
9bdc028 Accept fd as a keyword in epoll.unregister youknowdot Nov 2, 2026 https://github.com/RustPython/RustPython/pull/9553/commits/9bdc0283b7fc6ab25c098864f023ff12366b9e6e
51651bb Remove epoll unregister metadata test per review youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9553/commits/51651bb3594d9a9c641b1d64c0fa57f32a970c1f
1d3e01d Merge main into epoll unregister keyword fix youknowdot Nov 3, 2026 https://github.com/RustPython/RustPython/pull/9553/commits/1d3e01d6b11cb5d399e303ded749ccf6a9de8f96
Clear filters https://github.com/RustPython/RustPython/pull/9553/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9553/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9553/files
crates/stdlib/src/select.rshttps://github.com/RustPython/RustPython/pull/9553/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
View file https://github.com/youknowdot/RustPython/blob/1d3e01d6b11cb5d399e303ded749ccf6a9de8f96/crates/stdlib/src/select.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9553/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9553/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 3, 2026https://github.com/RustPython/RustPython/pull/9553/files#r4451827149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L20-L23https://github.com/RustPython/RustPython/blob/51651bb3594d9a9c641b1d64c0fa57f32a970c1f/AGENTS.md#L20-L23
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9553/files
https://github.com/RustPython/RustPython/pull/9553/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
https://github.com/RustPython/RustPython/pull/9553/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
https://github.com/RustPython/RustPython/pull/9553/files#diff-9e541446cb5321da18fb2db4eb334f6d7ec9f0cbdc04b74f120752d19efbb549
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9553/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.