René's URL Explorer Experiment


Title: Rollback sqlite transactions when context-manager commit fails by youknowdot · Pull Request #9535 · RustPython/RustPython · GitHub

Open Graph Title: Rollback sqlite transactions when context-manager commit fails by youknowdot · Pull Request #9535 · RustPython/RustPython

X Title: Rollback sqlite transactions when context-manager commit fails by youknowdot · Pull Request #9535 · RustPython/RustPython

Description: Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain its SQLite locks. If rollback succeeds, re-raise the commit exception. If rollback also fails, raise the rollback exception with the commit exception as __context__. Preserve the original body-exception path and use the existing commit/rollback cleanup wrappers. No native/autocommit guard spans the two calls. Source: CPython 3.15.0 d220409a13b77de7a6c30abe16ea90db01528edc, Modules/_sqlite/connection.c and _PyErr_ChainExceptions1 in Python/errors.c. This is an independent main-based fix: only the existing method body/return type changes. It does not include #9533's signature changes or reporting workflow change. No Lib/assertion/snippet edits. Validation and limits Passed: normal configured pre-commit hooks (merge-conflict check, rustfmt, cspell), git diff --check, and independent source review. Not run locally: compilation, native runtime tests, Rust/C-API tests, or clippy. The local dependency closure/cache is unavailable; actual CI is pending, so this remains Draft. Existing canonical coverage: test_sqlite3.test_dbapi.MultiprocessTests.test_ctx_mgr_rollback_if_commit_failed (subprocess/locking recovery) and test_sqlite3.test_transactions.AutocommitAttribute's three context-manager cases. The module target is cargo run --release --features sqlite -- -m test test_sqlite3 -v, in addition to required workspace/C-API/clippy validation. No existing canonical exact-False or double-failure-chain test was located. Those paths remain runtime-unverified. A closed connection's direct __exit__(None, None, None) provides a bounded future diagnostic for both operations failing, without callback injection. Separate existing VM limitation: when this new native error propagates inside an outer except, VM contextualization can replace the explicit commit-error context with the handled outer exception. This patch fixes the local SQLite behavior but does not claim end-to-end chaining parity for that case. No fake traceback or global VM workaround is included; outside/inside-except integration needs separate verification after the VM issue is addressed. AI assistance Implementation, CPython source comparison, and independent source review were assisted by OpenAI Codex (model version not exposed). No hook bypass; local runtime limitations are disclosed above. Summary by CodeRabbit Bug Fixes SQLite connection context managers now commit when a block exits successfully and roll back when it exits with an exception. If committing fails, the connection attempts to roll back. The reported error reflects a rollback failure when one occurs, while retaining the commit failure as context.

Open Graph Description: Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain...

X Description: Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9535

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0b10bf10-ea54-ba85-2f5c-f17d4b4349fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D06:9E08E:4315CB:5492B0:6B01FE15
html-safe-nonce2751fe0ea3e438df1bf944ee5561f742ece21fe5aa67069a75533ebd2e41eae3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDA2OjlFMDhFOjQzMTVDQjo1NDkyQjA6NkIwMUZFMTUiLCJ2aXNpdG9yX2lkIjoiNDEwODAyMzMxNDMxOTAxNTQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccae1ed7919cd750aa310d817646d9e55e7d98134f0498527b1026ca15da8e686
hovercard-subject-tagpull_request:5120526074
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9535/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9535/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9535%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9535%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9535/files
Reloadhttps://github.com/RustPython/RustPython/pull/9535/files
Reloadhttps://github.com/RustPython/RustPython/pull/9535/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/sqlite-exit-rollback-20261102https://github.com/youknowdot/RustPython/tree/fix/sqlite-exit-rollback-20261102
Conversation 4 https://github.com/RustPython/RustPython/pull/9535
Commits 1 https://github.com/RustPython/RustPython/pull/9535/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9535/checks
Files changed https://github.com/RustPython/RustPython/pull/9535/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9535/files
Rollback sqlite transactions when context-manager commit fails https://github.com/RustPython/RustPython/pull/9535/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9535/files
bacdd10 Rollback sqlite transactions when context-manager commit fails codex Nov 2, 2026 https://github.com/RustPython/RustPython/pull/9535/commits/bacdd10c6d73a9b1ed21c15828cb3a6b830082d2
Clear filters https://github.com/RustPython/RustPython/pull/9535/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9535/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9535/files
crates/stdlib/src/_sqlite3.rshttps://github.com/RustPython/RustPython/pull/9535/files#diff-5a5ea8fc8d5bfc6b5da126f9574990e39802662762f23a2a6a9143beca021e15
View file https://github.com/youknowdot/RustPython/blob/bacdd10c6d73a9b1ed21c15828cb3a6b830082d2/crates/stdlib/src/_sqlite3.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9535/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9535/files#diff-5a5ea8fc8d5bfc6b5da126f9574990e39802662762f23a2a6a9143beca021e15
coderabbitaihttps://github.com/apps/coderabbitai
Nov 2, 2026https://github.com/RustPython/RustPython/pull/9535/files#r4444269706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9535/files
https://github.com/RustPython/RustPython/pull/9535/files#diff-5a5ea8fc8d5bfc6b5da126f9574990e39802662762f23a2a6a9143beca021e15
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9535/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.