Title: Rollback sqlite transactions when context-manager commit fails by youknowdot · Pull Request #9535 · RustPython/RustPython · GitHub
Open Graph Title: Rollback sqlite transactions when context-manager commit fails by youknowdot · Pull Request #9535 · RustPython/RustPython
X Title: Rollback sqlite transactions when context-manager commit fails by youknowdot · Pull Request #9535 · RustPython/RustPython
Description: Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain its SQLite locks. If rollback succeeds, re-raise the commit exception. If rollback also fails, raise the rollback exception with the commit exception as __context__. Preserve the original body-exception path and use the existing commit/rollback cleanup wrappers. No native/autocommit guard spans the two calls. Source: CPython 3.15.0 d220409a13b77de7a6c30abe16ea90db01528edc, Modules/_sqlite/connection.c and _PyErr_ChainExceptions1 in Python/errors.c. This is an independent main-based fix: only the existing method body/return type changes. It does not include #9533's signature changes or reporting workflow change. No Lib/assertion/snippet edits. Validation and limits Passed: normal configured pre-commit hooks (merge-conflict check, rustfmt, cspell), git diff --check, and independent source review. Not run locally: compilation, native runtime tests, Rust/C-API tests, or clippy. The local dependency closure/cache is unavailable; actual CI is pending, so this remains Draft. Existing canonical coverage: test_sqlite3.test_dbapi.MultiprocessTests.test_ctx_mgr_rollback_if_commit_failed (subprocess/locking recovery) and test_sqlite3.test_transactions.AutocommitAttribute's three context-manager cases. The module target is cargo run --release --features sqlite -- -m test test_sqlite3 -v, in addition to required workspace/C-API/clippy validation. No existing canonical exact-False or double-failure-chain test was located. Those paths remain runtime-unverified. A closed connection's direct __exit__(None, None, None) provides a bounded future diagnostic for both operations failing, without callback injection. Separate existing VM limitation: when this new native error propagates inside an outer except, VM contextualization can replace the explicit commit-error context with the handled outer exception. This patch fixes the local SQLite behavior but does not claim end-to-end chaining parity for that case. No fake traceback or global VM workaround is included; outside/inside-except integration needs separate verification after the VM issue is addressed. AI assistance Implementation, CPython source comparison, and independent source review were assisted by OpenAI Codex (model version not exposed). No hook bypass; local runtime limitations are disclosed above. Summary by CodeRabbit Bug Fixes SQLite connection context managers now commit when a block exits successfully and roll back when it exits with an exception. If committing fails, the connection attempts to roll back. The reported error reflects a rollback failure when one occurs, while retaining the commit failure as context.
Open Graph Description: Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain...
X Description: Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9535
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0b10bf10-ea54-ba85-2f5c-f17d4b4349fb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D06:9E08E:4315CB:5492B0:6B01FE15 |
| html-safe-nonce | 2751fe0ea3e438df1bf944ee5561f742ece21fe5aa67069a75533ebd2e41eae3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDA2OjlFMDhFOjQzMTVDQjo1NDkyQjA6NkIwMUZFMTUiLCJ2aXNpdG9yX2lkIjoiNDEwODAyMzMxNDMxOTAxNTQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cae1ed7919cd750aa310d817646d9e55e7d98134f0498527b1026ca15da8e686 |
| hovercard-subject-tag | pull_request:5120526074 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9535/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Match the local CPython 3.15 Connection.__exit__ control flow: Return False after successful commit or rollback. If commit fails, attempt rollback so the failed transaction does not retain... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width