Title: Align sqlite3 argument declarations with Python 3.15 by youknowdot · Pull Request #9533 · RustPython/RustPython · GitHub
Open Graph Title: Align sqlite3 argument declarations with Python 3.15 by youknowdot · Pull Request #9533 · RustPython/RustPython
X Title: Align sqlite3 argument declarations with Python 3.15 by youknowdot · Pull Request #9533 · RustPython/RustPython
Description: Summary Address the 24 SQLite entries (3 _sqlite3, 21 sqlite3) in the actual Ubuntu whats_left --signature output from #9530, head 68646843423633e60bd54c6d4150db953b303804. That report compares normalized inspect.signature, not raw __text_signature__. This changes only _sqlite3.rs, using typed declarations rather than overriding displayed signatures: Match Python 3.15's positional/keyword rules for complete_statement, create_function, create_aggregate, and set_progress_handler. Require string backup(name='main'), reject explicit fetchmany(None) while keeping the current arraysize default, and preserve execute's missing-parameters semantics while exposing parameters=(). Declare concrete defaults for blob read/seek, setconfig, and setoutputsize; match Clinic's integer/truth conversion for callback tracing, deterministic functions, and connection configuration. Require exactly three positional arguments for Blob.__exit__ and return False. Match the remaining parameter names for Connection/Cursor methods and adapter registration. Source comparison uses CPython 3.15.0, commit d220409a13b77de7a6c30abe16ea90db01528edc, Modules/_sqlite/{module,connection,cursor,blob}.c and their generated Clinic headers. No Lib, snippet, assertion, shared binder, or workflow changes. Validation Passed: git diff --check, rustfmt, normal configured pre-commit hooks (merge-conflict check, rustfmt, cspell). Independent source review completed; this is not runtime proof. Not run locally: native compilation, Rust/C-API tests, clippy, test_sqlite3, or RustPython/CPython runtime signature comparison. The local dependency cache/closure is unavailable; this remains Draft pending actual CI. Canonical validation target: cargo run --release --features sqlite -- -m test test_sqlite3 -v, plus required workspace/C-API tests and clippy. The existing keyword tests and expectedFailure markers are unchanged; no pass is claimed from their source alone. Item-level post-fix comparison still needs scripts/whats_left.py --signature on the verified build; main's existing CI invocation currently reports only module counts. No claimed reduction is inferred from those counts. Existing gaps not claimed fixed Connection.__exit__ still returns None and lacks CPython's rollback/chaining after a failed commit; this patch only renames its parameters. fetchmany/arraysize still use signed c_int rather than CPython's full uint32 range. Renaming adapter-registration arguments does not establish complete converter parity. AI assistance Implementation, source comparison, and independent source review were assisted by OpenAI Codex (model version not exposed). Normal hooks ran without bypass. Native runtime verification is outstanding as described above. Summary by CodeRabbit Bug Fixes SQLite methods now apply consistent argument handling, including support for documented positional and named arguments. Added defaults for the backup database name, blob read length, and blob seek origin. Behavior Changes Cursor array sizes are now non-negative; negative values are rejected. Connection and blob context-manager exit methods accept exception details and return a boolean.
Open Graph Description: Summary Address the 24 SQLite entries (3 _sqlite3, 21 sqlite3) in the actual Ubuntu whats_left --signature output from #9530, head 68646843423633e60bd54c6d4150db953b303804. That report compares nor...
X Description: Summary Address the 24 SQLite entries (3 _sqlite3, 21 sqlite3) in the actual Ubuntu whats_left --signature output from #9530, head 68646843423633e60bd54c6d4150db953b303804. That report compares nor...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9533
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:34a0659d-0160-871a-04a7-6b3af3c2dba4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDCC:2AF0D8:3723DD:44BED1:6B01F9F3 |
| html-safe-nonce | 45b48270316e51fc0154cffda8b09d20ed583b07595da9b32300b6bab0b55b25 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRENDOjJBRjBEODozNzIzREQ6NDRCRUQxOjZCMDFGOUYzIiwidmlzaXRvcl9pZCI6IjEyMjQ0NTMxOTAyODQ2MDU5MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5f6732838665b45fd91f6b782f8078e973c7c2aeba61778c92016a6813a95201 |
| hovercard-subject-tag | pull_request:5120412781 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9533/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Address the 24 SQLite entries (3 _sqlite3, 21 sqlite3) in the actual Ubuntu whats_left --signature output from #9530, head 68646843423633e60bd54c6d4150db953b303804. That report compares nor... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width