René's URL Explorer Experiment


Title: Convert `math.ldexp()`'s `x` like any float argument and read float subclasses directly by jseop-lim · Pull Request #9520 · RustPython/RustPython · GitHub

Open Graph Title: Convert `math.ldexp()`'s `x` like any float argument and read float subclasses directly by jseop-lim · Pull Request #9520 · RustPython/RustPython

X Title: Convert `math.ldexp()`'s `x` like any float argument and read float subclasses directly by jseop-lim · Pull Request #9520 · RustPython/RustPython

Description: Closes #9508 This PR follows our AI policy Summary LdexpArgs binds x as Either, PyIntRef>, so anything other than a float or an int raises TypeError: unexpected type, including objects with __float__ or __index__, and an exception raised by __float__ is replaced. CPython's math_ldexp converts x with PyFloat_AsDouble, as the other math functions do, and RustPython's equivalent is ArgIntoFloat. Binding x as ArgIntoFloat exposes a defect ArgIntoFloat already has: try_from_object reads an exact float directly but calls __float__ on a float subclass, while PyFloat_AsDouble reads the stored value of any float instance. So a subclass that overrides __float__ already changes the result of math.sqrt(), math.frexp(), %-formatting, struct.pack() and every other ArgIntoFloat argument, and ldexp() would join them. This PR fixes that too. AS-IS >>> import math >>> math.ldexp(F(), 1) # __float__ returns 1.5 TypeError: unexpected type F >>> math.ldexp(RaisingFloat(), 1) # __float__ raises RuntimeError TypeError: unexpected type RaisingFloat >>> class FloatSubclass(float): ... def __float__(self): return 9.0 ... >>> math.sqrt(FloatSubclass(4.0)) 3.0 >>> '%.1f' % FloatSubclass(1.0) '9.0' TO-BE >>> math.ldexp(F(), 1) 3.0 >>> math.ldexp(RaisingFloat(), 1) RuntimeError >>> math.sqrt(FloatSubclass(4.0)) 2.0 >>> '%.1f' % FloatSubclass(1.0) '1.0' (matching CPython) Changes Bind ldexp()'s x as ArgIntoFloat in crates/stdlib/src/math.rs, as frexp() does. Its OverflowError for an int too large for a float replaces the try_bigint_to_f64 branch. In crates/vm/src/function/number.rs, ArgIntoFloat::try_from_object reads any float instance, subclasses included, before falling back to try_float. Extend extra_tests/snippets/stdlib_math.py with __float__ and __index__ mantissas for ldexp(), a raising __float__, an int too large for a float, and a float subclass overriding __float__ passed to sqrt() and ldexp(). Test plan Built and run on macOS aarch64 against upstream/main 713e14c, using the CI feature set --no-default-features --features stdlib,importlib,stdio,encodings,sqlite,ssl-rustls-aws-lc,host_env,doc,ucd_3_2_0, plus threading, compared with CPython 3.15.2. The extended extra_tests/snippets/stdlib_math.py fails on an unpatched build of that commit (at the __float__ mantissa) and passes with the patch and under CPython 3.15.2. The full rustpython -m test suite gives the same result with and without the patch, apart from one test_sqlite3 failure that did not reproduce when the module was run again on its own: 47,019 tests run, and test_cmd_line fails identically on the unpatched build. rustpython -m test test_math test_float test_cmath test_struct test_array test_format test_statistics test_str: 1,878 run, 86 skipped, all pass. pytest -k rustpython in extra_tests: 248 pass. cargo fmt --check clean, cargo clippy -p rustpython-vm -- -Dwarnings and cargo clippy -p rustpython-stdlib -- -Dwarnings report nothing, and the pre-commit hooks pass on the three changed files. I used Claude Code (claude-opus-5-5) to draft the analysis, the patch and this description; I reviewed the change and ran every command above myself. Summary by CodeRabbit New Features math.ldexp now accepts values convertible to floats, including objects that provide __float__ or __index__. Bug Fixes math.ldexp and math.sqrt use the stored value of float subclasses, even when they override __float__. Exceptions raised during float conversion are preserved, and oversized integer inputs to math.ldexp raise OverflowError.

Open Graph Description: Closes #9508 This PR follows our AI policy Summary LdexpArgs binds x as Either<PyRef<PyFloat>, PyIntRef>, so anything other than a float or an int raises TypeError: unexpected type, i...

X Description: Closes #9508 This PR follows our AI policy Summary LdexpArgs binds x as Either&lt;PyRef&lt;PyFloat&gt;, PyIntRef&gt;, so anything other than a float or an int raises TypeError: un...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9520

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af3cee38-4708-2fc8-89cc-02e04624bccb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC60:2D40DE:2ED7DAC:3BAA1BE:6B01FE62
html-safe-nonceed524ac3e2ee0fa11b96767087b4ba4872c7eca11fa1408a87924a6d7dec5022
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzYwOjJENDBERToyRUQ3REFDOjNCQUExQkU6NkIwMUZFNjIiLCJ2aXNpdG9yX2lkIjoiNDM1OTI3MDQ5MDU2NjgxNTcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac803b6a2e49870a1b0e1d0e46af365363b00ac1c057e20f1b8a6a64918b5d0de3
hovercard-subject-tagpull_request:5104715360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9520/files
twitter:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
og:image:altCloses #9508 This PR follows our AI policy Summary LdexpArgs binds x as Either<PyRef<PyFloat>, PyIntRef>, so anything other than a float or an int raises TypeError: unexpected type, i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9520/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9520%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9520%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9520/files
Reloadhttps://github.com/RustPython/RustPython/pull/9520/files
Reloadhttps://github.com/RustPython/RustPython/pull/9520/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/math-ldexp-float-protocolhttps://github.com/jseop-lim/RustPython/tree/fix/math-ldexp-float-protocol
Conversation 6 https://github.com/RustPython/RustPython/pull/9520
Commits 2 https://github.com/RustPython/RustPython/pull/9520/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9520/checks
Files changed https://github.com/RustPython/RustPython/pull/9520/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9520/files
Convert math.ldexp()'s x like any float argument and read float subclasses directly https://github.com/RustPython/RustPython/pull/9520/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9520/files
315dbb7 Convert the math.ldexp() mantissa like any float argument jseop-lim Nov 1, 2026 https://github.com/RustPython/RustPython/pull/9520/commits/315dbb7647d6e43be194ac5fcca8c0cb12ff4ba0
83c315e Read a float subclass directly in ArgIntoFloat jseop-lim Nov 1, 2026 https://github.com/RustPython/RustPython/pull/9520/commits/83c315ed2f06f3659579a2e061b72fd7a17e10fc
Clear filters https://github.com/RustPython/RustPython/pull/9520/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9520/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9520/files
math.rs https://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
number.rs https://github.com/RustPython/RustPython/pull/9520/files#diff-4b6c8f777cc85a356e8cfd03078d3119eeecaa76f326aac365e67c91c724a8ae
stdlib_math.py https://github.com/RustPython/RustPython/pull/9520/files#diff-84b443313ccbd86f8736dd3bfe22a8c6c8495932473dc366a7ee96aab2c51aef
crates/stdlib/src/math.rshttps://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
View file https://github.com/jseop-lim/RustPython/blob/83c315ed2f06f3659579a2e061b72fd7a17e10fc/crates/stdlib/src/math.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9520/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
https://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
https://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
https://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
https://github.com/RustPython/RustPython/pull/9520/files#diff-89a82797903807f93fd800a07d85c4fc0040354febe4b3544e5f9ed8e9fec640
crates/vm/src/function/number.rshttps://github.com/RustPython/RustPython/pull/9520/files#diff-4b6c8f777cc85a356e8cfd03078d3119eeecaa76f326aac365e67c91c724a8ae
View file https://github.com/jseop-lim/RustPython/blob/83c315ed2f06f3659579a2e061b72fd7a17e10fc/crates/vm/src/function/number.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9520/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9520/files#diff-4b6c8f777cc85a356e8cfd03078d3119eeecaa76f326aac365e67c91c724a8ae
https://github.com/RustPython/RustPython/pull/9520/files#diff-4b6c8f777cc85a356e8cfd03078d3119eeecaa76f326aac365e67c91c724a8ae
https://github.com/RustPython/RustPython/pull/9520/files#diff-4b6c8f777cc85a356e8cfd03078d3119eeecaa76f326aac365e67c91c724a8ae
extra_tests/snippets/stdlib_math.pyhttps://github.com/RustPython/RustPython/pull/9520/files#diff-84b443313ccbd86f8736dd3bfe22a8c6c8495932473dc366a7ee96aab2c51aef
View file https://github.com/jseop-lim/RustPython/blob/83c315ed2f06f3659579a2e061b72fd7a17e10fc/extra_tests/snippets/stdlib_math.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9520/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9520/files#diff-84b443313ccbd86f8736dd3bfe22a8c6c8495932473dc366a7ee96aab2c51aef
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9520/files#r4434544364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/a08bbb8a949f7033433a88444eeae385ff6a5e599d92f878fb05fa85707b7816/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50312d6f72616e67653f7374796c653d666c6174
AGENTS.md:L280-L282https://github.com/RustPython/RustPython/blob/83c315ed2f06f3659579a2e061b72fd7a17e10fc/AGENTS.md#L280-L282
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9520/files
jseop-limhttps://github.com/jseop-lim
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9520/files#r4434560560
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9520/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9520/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.