René's URL Explorer Experiment


Title: Check `n` before `iter()` in `itertools.tee()` and re-check the iterator by jseop-lim · Pull Request #9518 · RustPython/RustPython · GitHub

Open Graph Title: Check `n` before `iter()` in `itertools.tee()` and re-check the iterator by jseop-lim · Pull Request #9518 · RustPython/RustPython

X Title: Check `n` before `iter()` in `itertools.tee()` and re-check the iterator by jseop-lim · Pull Request #9518 · RustPython/RustPython

Description: Closes #9512 This PR follows our AI policy Summary TeeArgs binds iterable as PyIter, so iter() runs while the arguments are bound, before tee checks n. tee then copies an iterator that has __copy__ directly, and PyItertoolsTee::from_iter stores any other iterator without calling iter() on it. In CPython the argument clinic rejects a negative n, and itertools_tee_impl returns () for zero before calling iter(), then buffers the iterator in a tee object, whose tee_fromiterable calls iter() on it again. AS-IS >>> import itertools >>> itertools.tee(NoneIter(), -1) # __iter__ returns None TypeError: NoneIter.__iter__() must return an iterator, not NoneType >>> itertools.tee(NoneIter(), 0) TypeError: NoneIter.__iter__() must return an iterator, not NoneType >>> type(itertools.tee(BadIterable())) # its iterator's __iter__ returns None TO-BE >>> itertools.tee(NoneIter(), -1) ValueError: n must be >= 0 >>> itertools.tee(NoneIter(), 0) () >>> type(itertools.tee(BadIterable())) TypeError: BadIterator.__iter__() must return an iterator, not NoneType (matching CPython's exception types; CPython 3.15 words the first message n cannot be negative) Changes In crates/vm/src/stdlib/itertools.rs, bind iterable as PyObjectRef. tee checks n, returns an empty tuple for zero, and only then calls iter(). Drop the __copy__ shortcut, so every iterator goes through PyItertoolsTee::from_iter, which now calls iter() on the iterator it is given. A tee object is still copied rather than wrapped. An iterator's own __copy__ is no longer called, as in CPython since gh-123884. Extend extra_tests/snippets/stdlib_itertools.py with a negative and a zero n on a broken iterable, an iterator whose __iter__ returns a non-iterator, and an iterator whose __copy__ raises. Test plan Built and run on macOS aarch64 against upstream/main 713e14c, using the CI feature set --no-default-features --features stdlib,importlib,stdio,encodings,sqlite,ssl-rustls-aws-lc,host_env,doc,ucd_3_2_0, plus threading, compared with CPython 3.15.2. The extended extra_tests/snippets/stdlib_itertools.py fails on an unpatched build of that commit (at tee(NoneIter(), -1)) and passes with the patch and under CPython 3.15.2. rustpython -m test test_itertools: 137 run, 22 skipped, all pass. pytest -k rustpython in extra_tests: 248 pass. cargo fmt --check clean, cargo clippy -p rustpython-vm -- -Dwarnings reports nothing, and the pre-commit hooks pass on both changed files. I used Claude Code (claude-opus-5-5) to draft the analysis, the patch and this description; I reviewed the change and ran every command above myself. Summary by CodeRabbit Bug Fixes Improved iterator duplication to accept iterable inputs and handle invalid iterators with a clear error. Requesting zero iterators now returns an empty result without requiring a valid input iterator. Iterator duplication no longer fails solely because an input’s copy operation raises an error.

Open Graph Description: Closes #9512 This PR follows our AI policy Summary TeeArgs binds iterable as PyIter, so iter() runs while the arguments are bound, before tee checks n. tee then copies an iterator that has __copy...

X Description: Closes #9512 This PR follows our AI policy Summary TeeArgs binds iterable as PyIter, so iter() runs while the arguments are bound, before tee checks n. tee then copies an iterator that has __copy...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9518

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c09555cc-a0f6-e95e-f977-b5faed808d8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB3E:382318:41BD40:527D63:6B01FE53
html-safe-nonce4ac11157b906d3bae1a9b9a0a2b8690ced9efc3f856b9474182c1dff569eec55
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjNFOjM4MjMxODo0MUJENDA6NTI3RDYzOjZCMDFGRTUzIiwidmlzaXRvcl9pZCI6IjY5MDIzNjg0OTkyNTYxMzExNTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac42c0e083d983025e37b2bca2ff1fea7fcf292cfc46e593db720340231f0710a8
hovercard-subject-tagpull_request:5104357392
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9518/files
twitter:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
og:image:altCloses #9512 This PR follows our AI policy Summary TeeArgs binds iterable as PyIter, so iter() runs while the arguments are bound, before tee checks n. tee then copies an iterator that has __copy...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9518/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9518%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9518%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9518/files
Reloadhttps://github.com/RustPython/RustPython/pull/9518/files
Reloadhttps://github.com/RustPython/RustPython/pull/9518/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/itertools-teehttps://github.com/jseop-lim/RustPython/tree/fix/itertools-tee
Conversation 3 https://github.com/RustPython/RustPython/pull/9518
Commits 1 https://github.com/RustPython/RustPython/pull/9518/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9518/checks
Files changed https://github.com/RustPython/RustPython/pull/9518/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9518/files
Check n before iter() in itertools.tee() and re-check the iterator https://github.com/RustPython/RustPython/pull/9518/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9518/files
c2b8a24 Check tee() n before iter() and re-check the iterator jseop-lim Oct 31, 2026 https://github.com/RustPython/RustPython/pull/9518/commits/c2b8a2469136d6e3b036bcb49c4a77318bb988b5
Clear filters https://github.com/RustPython/RustPython/pull/9518/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9518/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9518/files
itertools.rs https://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
stdlib_itertools.py https://github.com/RustPython/RustPython/pull/9518/files#diff-4e7aac46413819169f405d74449119f5a3fb6ac758d7ad63a4841cc468b53ac3
crates/vm/src/stdlib/itertools.rshttps://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
View file https://github.com/jseop-lim/RustPython/blob/c2b8a2469136d6e3b036bcb49c4a77318bb988b5/crates/vm/src/stdlib/itertools.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9518/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
https://github.com/RustPython/RustPython/pull/9518/files#diff-327f924a0e1982a4aa3d49157129811604b589ade7716766a67653a16e0bf101
extra_tests/snippets/stdlib_itertools.pyhttps://github.com/RustPython/RustPython/pull/9518/files#diff-4e7aac46413819169f405d74449119f5a3fb6ac758d7ad63a4841cc468b53ac3
View file https://github.com/jseop-lim/RustPython/blob/c2b8a2469136d6e3b036bcb49c4a77318bb988b5/extra_tests/snippets/stdlib_itertools.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9518/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9518/files#diff-4e7aac46413819169f405d74449119f5a3fb6ac758d7ad63a4841cc468b53ac3
https://github.com/RustPython/RustPython/pull/9518/files#diff-4e7aac46413819169f405d74449119f5a3fb6ac758d7ad63a4841cc468b53ac3
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9518/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.