René's URL Explorer Experiment


Title: Hash a non-str name in `csv.get_dialect()` and `csv.unregister_dialect()` by jseop-lim · Pull Request #9514 · RustPython/RustPython · GitHub

Open Graph Title: Hash a non-str name in `csv.get_dialect()` and `csv.unregister_dialect()` by jseop-lim · Pull Request #9514 · RustPython/RustPython

X Title: Hash a non-str name in `csv.get_dialect()` and `csv.unregister_dialect()` by jseop-lim · Pull Request #9514 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Closes csv.get_dialect() and csv.unregister_dialect() raise csv.Error for an unhashable name instead of the hashing error #9507 This PR follows our AI policy Summary get_dialect and unregister_di...

X Description: Closes csv.get_dialect() and csv.unregister_dialect() raise csv.Error for an unhashable name instead of the hashing error #9507 This PR follows our AI policy Summary get_dialect and unregister_di...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9514

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e69aea53-0dfe-643b-5ada-0115b405c1b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83F8:24645:F51D85:143BD62:6B01D7BE
html-safe-noncedf868d17d73e249b5d51503cca92f6e51903c3500f6ace433c12808b1b45ee84
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0Y4OjI0NjQ1OkY1MUQ4NToxNDNCRDYyOjZCMDFEN0JFIiwidmlzaXRvcl9pZCI6IjY3ODQzOTgxMTI4NDU4NDY0NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb832498a6a2d9487e04e86e56d367bb311ef973da4d5dbb9375756ddc4148ff7
hovercard-subject-tagpull_request:5104356059
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/9514/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9d5a8030e6b593ce446cf869d9b55e1a2c40e09d530b772b6c9ce3fef4589088/RustPython/RustPython/pull/9514
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d5a8030e6b593ce446cf869d9b55e1a2c40e09d530b772b6c9ce3fef4589088/RustPython/RustPython/pull/9514
og:image:altCloses csv.get_dialect() and csv.unregister_dialect() raise csv.Error for an unhashable name instead of the hashing error #9507 This PR follows our AI policy Summary get_dialect and unregister_di...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejseop-lim
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9514#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9514
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9514
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9514
Reloadhttps://github.com/RustPython/RustPython/pull/9514
Reloadhttps://github.com/RustPython/RustPython/pull/9514
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/csv-dialect-name-hashhttps://github.com/jseop-lim/RustPython/tree/fix/csv-dialect-name-hash
Conversationhttps://github.com/RustPython/RustPython/pull/9514
Commits2 (2)https://github.com/RustPython/RustPython/pull/9514/commits
Checkshttps://github.com/RustPython/RustPython/pull/9514/checks
Files changedhttps://github.com/RustPython/RustPython/pull/9514/files
Hash a non-str name in csv.get_dialect() and csv.unregister_dialect()https://github.com/RustPython/RustPython/pull/9514#top
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/csv-dialect-name-hashhttps://github.com/jseop-lim/RustPython/tree/fix/csv-dialect-name-hash
https://github.com/jseop-lim
jseop-limhttps://github.com/jseop-lim
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9514#issue-6143217110
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
csv.get_dialect() and csv.unregister_dialect() raise csv.Error for an unhashable name instead of the hashing error #9507https://github.com/RustPython/RustPython/issues/9507
AI policyhttps://github.com/RustPython/.github/blob/main/AI_POLICY.md
get_dialecthttps://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L218-L230
unregister_dialecthttps://github.com/RustPython/RustPython/blob/713e14cfc78d06372c68a1804240de52a8340548/crates/stdlib/src/csv.rs#L232-L249
PyDict_GetItemRefhttps://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L162-L170
PyDict_Pophttps://github.com/python/cpython/blob/v3.15.2/Modules/_csv.c#L1652-L1666
713e14chttps://github.com/RustPython/RustPython/commit/713e14cfc78d06372c68a1804240de52a8340548
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/jseop-lim
Hash non-str csv dialect names before lookuphttps://github.com/RustPython/RustPython/pull/9514/commits/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1
04d83eehttps://github.com/RustPython/RustPython/pull/9514/commits/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9514#issuecomment-6553404014
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
Your team has set up Codex to review pull requests in this repohttps://chatgpt.com/codex/cloud/settings/general
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9514#issuecomment-6553408188
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://app.coderabbit.ai/change-stack/RustPython/RustPython/pull/9514?scope=ghh_OusAJGA4HG8ljoOV0wJvVx8NmnZIjc2DdjmxOu0xZWA&cs_source=review_comment
RustPython/RustPythonhttps://github.com/RustPython/RustPython
mainhttps://github.com/RustPython/RustPython/tree/main
.coderabbit.ymlhttps://github.com/RustPython/RustPython/blob/88f373357f40923c7b1bb533072e7962790e2663/.coderabbit.yml
88f3733https://github.com/RustPython/RustPython/commit/88f373357f40923c7b1bb533072e7962790e2663
04d83eehttps://github.com/RustPython/RustPython/commit/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1
2ba1bf9https://github.com/RustPython/RustPython/commit/2ba1bf9903fc2b1015b87e9d86a44f5455a22d28
https://camo.githubusercontent.com/8f159bbb8848bd140c752331ef9b58f49be054035a4d90b12ab90a8478776bde/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7761726e696e672e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
https://camo.githubusercontent.com/52c6b786492f6f8748feb782ecaf3a1d3152ec095001b1a26170cc7cbe533212/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f636f64657261626269745f7075626c69635f6173736574732f7072652d6d657267652d636865636b732d7061737365642e737667
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=RustPython/RustPython&utm_content=9514
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 1, 2026 https://github.com/RustPython/RustPython/pull/9514#pullrequestreview-5726456621
View reviewed changes https://github.com/RustPython/RustPython/pull/9514/files/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
https://github.com/RustPython/RustPython/pull/9514#pullrequestreview-5726456621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Your team has set up Codex to review pull requests in this repohttps://chatgpt.com/codex/cloud/settings/general
@codexhttps://github.com/codex
@codexhttps://github.com/codex
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
extra_tests/snippets/stdlib_csv.pyhttps://github.com/RustPython/RustPython/pull/9514/files/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1#diff-3d834bd9b008124d1d115c12c5a34a5b18603e108f9ea2ea03f9d506bd9161bd
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
crates/stdlib/src/csv.rshttps://github.com/RustPython/RustPython/pull/9514/files/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/apps/codspeed
codspeedhttps://github.com/apps/codspeed
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9514#issuecomment-6553643956
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
1https://github.com/RustPython/RustPython/pull/9514#user-content-fn-skipped-6f4d22f8792b91615ecf9db8670015fb
2ba1bf9https://github.com/RustPython/RustPython/commit/2ba1bf9903fc2b1015b87e9d86a44f5455a22d28
88f3733https://github.com/RustPython/RustPython/commit/88f373357f40923c7b1bb533072e7962790e2663
https://app.codspeed.io/RustPython/RustPython/branches/jseop-lim%3Afix%2Fcsv-dialect-name-hash?utm_source=github&utm_medium=comment-v2&utm_content=button
click here and archive them to remove them from the performance reportshttps://app.codspeed.io/RustPython/RustPython/branches/jseop-lim%3Afix%2Fcsv-dialect-name-hash?q=is%3Askipped&utm_source=github&utm_medium=comment-v2&utm_content=archive
↩https://github.com/RustPython/RustPython/pull/9514#user-content-fnref-skipped-6f4d22f8792b91615ecf9db8670015fb
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/jseop-lim
Skip hashing a dialect name when the registry is emptyhttps://github.com/RustPython/RustPython/pull/9514/commits/2ba1bf9903fc2b1015b87e9d86a44f5455a22d28
2ba1bf9https://github.com/RustPython/RustPython/pull/9514/commits/2ba1bf9903fc2b1015b87e9d86a44f5455a22d28
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Nov 1, 2026 https://github.com/RustPython/RustPython/pull/9514#pullrequestreview-5727325453
View reviewed changes https://github.com/RustPython/RustPython/pull/9514/files/2ba1bf9903fc2b1015b87e9d86a44f5455a22d28
https://github.com/youknowone
youknowonehttps://github.com/youknowone
4591756https://github.com/RustPython/RustPython/commit/4591756d3f878d8ca586f9ffa2c34d4eb0ff7d25
Nov 1, 2026https://github.com/RustPython/RustPython/pull/9514#event-34823101087
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/jseop-lim
jseop-limhttps://github.com/jseop-lim
November 1, 2026 16:25https://github.com/RustPython/RustPython/pull/9514#event-34841407697
Assorted CPython compatibility divergences (18 items) #9913 https://github.com/RustPython/RustPython/issues/9913
Hash a str subclass name in the csv dialect registry #9918 https://github.com/RustPython/RustPython/pull/9918
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9514
https://github.com/apps/chatgpt-codex-connector
chatgpt-codex-connector[bot] https://github.com/apps/chatgpt-codex-connector
https://github.com/RustPython/RustPython/pull/9514/files/04d83ee5d4a0ab2b102c75c1fab51977e78e28e1
https://github.com/youknowone
youknowone https://github.com/youknowone
https://github.com/RustPython/RustPython/pull/9514/files/2ba1bf9903fc2b1015b87e9d86a44f5455a22d28
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
csv.get_dialect() and csv.unregister_dialect() raise csv.Error for an unhashable name instead of the hashing error https://github.com/RustPython/RustPython/issues/9507
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9514
https://github.com/jseop-lim
https://github.com/youknowone
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.