René's URL Explorer Experiment


Title: Match mmap constructor audit ordering and argument conversion by youknowdot · Pull Request #9489 · RustPython/RustPython · GitHub

Open Graph Title: Match mmap constructor audit ordering and argument conversion by youknowdot · Pull Request #9489 · RustPython/RustPython

X Title: Match mmap constructor audit ordering and argument conversion by youknowdot · Pull Request #9489 · RustPython/RustPython

Description: Summary Emit mmap.__new__ at CPython's platform-specific point: after argument validation/access normalization on Unix, before access/length/tag validation on Windows. Preserve requested length and propagate hook refusal before host mapping operations. Convert access using getargs.c's signed-int contract (C-long conversion followed by C-int bounds), without prematurely validating its enum. Use truth testing for trackfd. Restore the existing test_audit.AuditTest.test_mmap using scripts/update_lib migrate, retaining unrelated test adaptations. Source comparison: pinned CPython new_mmap_object, Unix and Windows implementations, getargs.c signed-int conversion, and PyLong_AsLong. No storage/locking/GC changes, global argument-converter refactor, or flush changes. The existing conditional flush-test skip remains untouched. The existing Windows Rust fixture only receives the matching constructor field types. Validation Scoped Cargo check, strict Clippy, and CLI build passed. 31 finite Linux observations per engine matched pinned CPython exactly. Four successful anonymous 8-byte mappings were explicitly closed; all remaining cases were hook-refused or preflight-rejected. Count, denial, length, and closed-state assertions were enforced. Normal configured commit hooks passed after a rustfmt-only retry. Canonical formatting of the preserved tested source is byte-identical to the committed source; no behavioral source change followed validation. Windows-specific ordering was source-reviewed, not emulated locally. Canonical subprocess tests and whole suites were not run locally; hosted CI is pending. AI assistance OpenAI Codex assisted with implementation, CPython source comparison, and validation. The model version was unavailable. Summary by CodeRabbit Bug Fixes Memory-mapped file access arguments now report overflow errors when values exceed supported integer bounds and ValueError for access modes outside the supported range. The trackfd argument is now interpreted as a boolean on both Unix and Windows.

Open Graph Description: Summary Emit mmap.__new__ at CPython's platform-specific point: after argument validation/access normalization on Unix, before access/length/tag validation on Windows. Preserve requested lengt...

X Description: Summary Emit mmap.__new__ at CPython's platform-specific point: after argument validation/access normalization on Unix, before access/length/tag validation on Windows. Preserve requested l...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9489

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:72f4658e-4e0e-4392-93ce-6613d65212ef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB49E:97D39:B92C7D:F4A655:6B01F3B0
html-safe-noncec8e803a2d28ade918edf580b617f12bb8e319dac039b5823dda7c29cf03d9110
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDlFOjk3RDM5OkI5MkM3RDpGNEE2NTU6NkIwMUYzQjAiLCJ2aXNpdG9yX2lkIjoiNDQyNjQwNDk3NTA2ODk2Nzg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b5e54c7e48bc99e748dbf0b785db96d39f10020e08a1bd81a5c2a3f20d3d5bc
hovercard-subject-tagpull_request:5086084091
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9489/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Emit mmap.__new__ at CPython's platform-specific point: after argument validation/access normalization on Unix, before access/length/tag validation on Windows. Preserve requested lengt...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9489/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9489%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9489%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9489/files
Reloadhttps://github.com/RustPython/RustPython/pull/9489/files
Reloadhttps://github.com/RustPython/RustPython/pull/9489/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:py315-mmap-constructor-audit-20261030https://github.com/youknowdot/RustPython/tree/py315-mmap-constructor-audit-20261030
Conversation 4 https://github.com/RustPython/RustPython/pull/9489
Commits 1 https://github.com/RustPython/RustPython/pull/9489/commits
Checks 29 https://github.com/RustPython/RustPython/pull/9489/checks
Files changed https://github.com/RustPython/RustPython/pull/9489/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9489/files
Match mmap constructor audit ordering and argument conversion https://github.com/RustPython/RustPython/pull/9489/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9489/files
2012e06 Match mmap constructor audit ordering and argument conversion codex Oct 30, 2026 https://github.com/RustPython/RustPython/pull/9489/commits/2012e06aee9d612e9cb84032f69a812386380a2b
Clear filters https://github.com/RustPython/RustPython/pull/9489/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9489/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9489/files
test_audit.py https://github.com/RustPython/RustPython/pull/9489/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
mmap.rs https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
Lib/test/test_audit.pyhttps://github.com/RustPython/RustPython/pull/9489/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
View file https://github.com/youknowdot/RustPython/blob/2012e06aee9d612e9cb84032f69a812386380a2b/Lib/test/test_audit.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9489/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9489/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
https://github.com/RustPython/RustPython/pull/9489/files#diff-9e6a1e498511d9e674d9697d12f4b152dd3539cf13ec953b857ed118a5c57353
crates/stdlib/src/mmap.rshttps://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
View file https://github.com/youknowdot/RustPython/blob/2012e06aee9d612e9cb84032f69a812386380a2b/crates/stdlib/src/mmap.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9489/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
https://github.com/RustPython/RustPython/pull/9489/files#diff-f019287585dfa476feb78beedd3e67b25292c5da5514fccbff2981bd8e0dc0df
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9489/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.