René's URL Explorer Experiment


Title: Match CPython group id conversion and update grp tests by youknowdot · Pull Request #9462 · RustPython/RustPython · GitHub

Open Graph Title: Match CPython group id conversion and update grp tests by youknowdot · Pull Request #9462 · RustPython/RustPython

X Title: Match CPython group id conversion and update grp tests by youknowdot · Pull Request #9462 · RustPython/RustPython

Description: Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPython's signed long and unsigned long conversion paths rather than collapsing out-of-range gids into KeyError. Migrate the whole Lib/test/test_grp.py using scripts/update_lib; the resulting file is byte-identical to pinned CPython and retires its sole expected-failure marker. CPython basis Pinned source: d220409a13b77de7a6c30abe16ea90db01528edc. grp_getgrgid_impl _Py_Gid_Converter Canonical group tests Validation Scoped cargo check and strict Clippy passed with a dedicated worktree target and fresh stdlib artifacts. CLI build passed; 16 finite invalid-gid cases on each engine produced identical full JSON results against the pinned CPython build. These cases include integer overflow, __index__ failures/non-integer results, and UTF-8-safe type-name truncation; none reaches an OS group database lookup. Normal commit hooks passed, including rustfmt, cspell, Ruff and redundant-test-patch checks. Hook formatting after execution only reformatted the existing missing-group error closure. Canonical test_grp was not run locally: it performs NSS/group-database queries. Actual test_grp execution on Unix CI is required before calling this integration validated. Windows lacks this Unix-only module; a skipped Windows module is not evidence of coverage. Full workspace and C API test suites were not run locally. CI is pending. The underlying host lookup/error handling is otherwise unchanged. This does not claim validation on exotic signed-gid_t targets. Local checks used base f98543dcdbe49fc902c17f28f81cc980fa69dd3f. Latest main observed before publication was d24ca415d8ee8ac439e19ef50e624abb64c48482; intervening changes only touched JSON files, not this patch. Merge-result integration remains a CI responsibility, not a claimed local rebase test. AI assistance: OpenAI Codex; model version unavailable. The commit includes the corresponding Assisted-by trailer. Summary by CodeRabbit Bug Fixes Group lookup now reports invalid argument types as TypeError and out-of-range IDs as OverflowError, rather than treating these cases as missing groups. Missing groups continue to raise KeyError, with the requested group ID included in the message.

Open Graph Description: Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPython...

X Description: Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPytho...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9462

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:912ce484-6e08-432e-6da8-887e4c46e4d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECC4:F8C5C:5F2B15:77FE74:6B01FE98
html-safe-nonceac68966c27d8e5a60df7eff631b20ddad5081e2a96924ef88273091caf497351
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0M0OkY4QzVDOjVGMkIxNTo3N0ZFNzQ6NkIwMUZFOTgiLCJ2aXNpdG9yX2lkIjoiNzM0NDcyNTA0Mzg0MDE1NTI4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a2a2acc6963d407d4a29fd66b23efe5da9cc886fad3bdc8eb816269013b6833
hovercard-subject-tagpull_request:5070822973
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9462/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altSummary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPython...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9462/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9462%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9462%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9462/files
Reloadhttps://github.com/RustPython/RustPython/pull/9462/files
Reloadhttps://github.com/RustPython/RustPython/pull/9462/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:py315-grp-gid-converter-20261029https://github.com/youknowdot/RustPython/tree/py315-grp-gid-converter-20261029
Conversation 6 https://github.com/RustPython/RustPython/pull/9462
Commits 2 https://github.com/RustPython/RustPython/pull/9462/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9462/checks
Files changed https://github.com/RustPython/RustPython/pull/9462/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9462/files
Match CPython group id conversion and update grp tests https://github.com/RustPython/RustPython/pull/9462/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9462/files
dbaeaac Match CPython group id conversion and update grp tests codex Oct 29, 2026 https://github.com/RustPython/RustPython/pull/9462/commits/dbaeaacbccb5262a23d22a0bf2f1e26561977d56
29ced28 Use ArgIndex for group id conversion codex Oct 30, 2026 https://github.com/RustPython/RustPython/pull/9462/commits/29ced2896db156a31df0c26af58a9ad9ca6a84bf
Clear filters https://github.com/RustPython/RustPython/pull/9462/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9462/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9462/files
test_grp.py https://github.com/RustPython/RustPython/pull/9462/files#diff-c7ac0eda54759ea5897a7a97b3627889c6d56c2d107d326d519361d0ab2c936d
grp.rs https://github.com/RustPython/RustPython/pull/9462/files#diff-eedbb58546fe7495149151d7e13c69402b128c556ba0d4608b2d7995e59f04e0
Lib/test/test_grp.pyhttps://github.com/RustPython/RustPython/pull/9462/files#diff-c7ac0eda54759ea5897a7a97b3627889c6d56c2d107d326d519361d0ab2c936d
View file https://github.com/youknowdot/RustPython/blob/29ced2896db156a31df0c26af58a9ad9ca6a84bf/Lib/test/test_grp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9462/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9462/files#diff-c7ac0eda54759ea5897a7a97b3627889c6d56c2d107d326d519361d0ab2c936d
https://github.com/RustPython/RustPython/pull/9462/files#diff-c7ac0eda54759ea5897a7a97b3627889c6d56c2d107d326d519361d0ab2c936d
crates/stdlib/src/grp.rshttps://github.com/RustPython/RustPython/pull/9462/files#diff-eedbb58546fe7495149151d7e13c69402b128c556ba0d4608b2d7995e59f04e0
View file https://github.com/youknowdot/RustPython/blob/29ced2896db156a31df0c26af58a9ad9ca6a84bf/crates/stdlib/src/grp.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9462/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9462/files#diff-eedbb58546fe7495149151d7e13c69402b128c556ba0d4608b2d7995e59f04e0
https://github.com/RustPython/RustPython/pull/9462/files#diff-eedbb58546fe7495149151d7e13c69402b128c556ba0d4608b2d7995e59f04e0
https://github.com/RustPython/RustPython/pull/9462/files#diff-eedbb58546fe7495149151d7e13c69402b128c556ba0d4608b2d7995e59f04e0
youknowonehttps://github.com/youknowone
Oct 30, 2026https://github.com/RustPython/RustPython/pull/9462/files#r4424837563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9462/files
youknowdothttps://github.com/youknowdot
Oct 30, 2026https://github.com/RustPython/RustPython/pull/9462/files#r4425487382
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
29ced2896dhttps://github.com/RustPython/RustPython/commit/29ced2896db156a31df0c26af58a9ad9ca6a84bf
_Py_Gid_Converterhttps://github.com/python/cpython/blob/d220409a13b77de7a6c30abe16ea90db01528edc/Modules/posixmodule.c#L976-L1085
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9462/files
https://github.com/RustPython/RustPython/pull/9462/files#diff-eedbb58546fe7495149151d7e13c69402b128c556ba0d4608b2d7995e59f04e0
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9462/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.