Title: Match CPython group id conversion and update grp tests by youknowdot · Pull Request #9462 · RustPython/RustPython · GitHub
Open Graph Title: Match CPython group id conversion and update grp tests by youknowdot · Pull Request #9462 · RustPython/RustPython
X Title: Match CPython group id conversion and update grp tests by youknowdot · Pull Request #9462 · RustPython/RustPython
Description: Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPython's signed long and unsigned long conversion paths rather than collapsing out-of-range gids into KeyError. Migrate the whole Lib/test/test_grp.py using scripts/update_lib; the resulting file is byte-identical to pinned CPython and retires its sole expected-failure marker. CPython basis Pinned source: d220409a13b77de7a6c30abe16ea90db01528edc. grp_getgrgid_impl _Py_Gid_Converter Canonical group tests Validation Scoped cargo check and strict Clippy passed with a dedicated worktree target and fresh stdlib artifacts. CLI build passed; 16 finite invalid-gid cases on each engine produced identical full JSON results against the pinned CPython build. These cases include integer overflow, __index__ failures/non-integer results, and UTF-8-safe type-name truncation; none reaches an OS group database lookup. Normal commit hooks passed, including rustfmt, cspell, Ruff and redundant-test-patch checks. Hook formatting after execution only reformatted the existing missing-group error closure. Canonical test_grp was not run locally: it performs NSS/group-database queries. Actual test_grp execution on Unix CI is required before calling this integration validated. Windows lacks this Unix-only module; a skipped Windows module is not evidence of coverage. Full workspace and C API test suites were not run locally. CI is pending. The underlying host lookup/error handling is otherwise unchanged. This does not claim validation on exotic signed-gid_t targets. Local checks used base f98543dcdbe49fc902c17f28f81cc980fa69dd3f. Latest main observed before publication was d24ca415d8ee8ac439e19ef50e624abb64c48482; intervening changes only touched JSON files, not this patch. Merge-result integration remains a CI responsibility, not a claimed local rebase test. AI assistance: OpenAI Codex; model version unavailable. The commit includes the corresponding Assisted-by trailer. Summary by CodeRabbit Bug Fixes Group lookup now reports invalid argument types as TypeError and out-of-range IDs as OverflowError, rather than treating these cases as missing groups. Missing groups continue to raise KeyError, with the requested group ID included in the message.
Open Graph Description: Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPython...
X Description: Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPytho...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9462
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:912ce484-6e08-432e-6da8-887e4c46e4d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECC4:F8C5C:5F2B15:77FE74:6B01FE98 |
| html-safe-nonce | ac68966c27d8e5a60df7eff631b20ddad5081e2a96924ef88273091caf497351 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0M0OkY4QzVDOjVGMkIxNTo3N0ZFNzQ6NkIwMUZFOTgiLCJ2aXNpdG9yX2lkIjoiNzM0NDcyNTA0Mzg0MDE1NTI4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4a2a2acc6963d407d4a29fd66b23efe5da9cc886fad3bdc8eb816269013b6833 |
| hovercard-subject-tag | pull_request:5070822973 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9462/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Summary Match CPython's grp.getgrgid() conversion through __index__, including overflow versus missing-group errors, the -1 sentinel, and bounded type names in diagnostics. Preserve CPython... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width